From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BC52C2BB1D for ; Wed, 15 Apr 2020 01:51:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 53CEE20737 for ; Wed, 15 Apr 2020 01:51:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392755AbgDOBvn (ORCPT ); Tue, 14 Apr 2020 21:51:43 -0400 Received: from mga11.intel.com ([192.55.52.93]:4241 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387766AbgDOBvl (ORCPT ); Tue, 14 Apr 2020 21:51:41 -0400 IronPort-SDR: 6NHwnvVpa4O27Yb1dCn5zYOD+7WpuHTbptzvqEz9Xdfx9bqVt74CjwkBqMtSSFVfZzcdLpYx1A NZcLZ0CP2vJA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2020 18:51:40 -0700 IronPort-SDR: oNyv8pcwMJmynapfKtQ0XsbFivhe1B0qmEbjepMC1qvn4eCXwy6Ki4qR6KZypWCVy2mi8zrETg d/N11J3ZPtDQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,385,1580803200"; d="scan'208";a="288403966" Received: from linux.intel.com ([10.54.29.200]) by fmsmga002.fm.intel.com with ESMTP; 14 Apr 2020 18:51:39 -0700 Received: from [10.213.147.143] (thiphuo2-mobl4.ccr.corp.intel.com [10.213.147.143]) by linux.intel.com (Postfix) with ESMTP id 2640E5802C9; Tue, 14 Apr 2020 18:51:23 -0700 (PDT) Subject: Re: [PATCH v1 1/2] dt-bindings: mtd: Add YAML for Nand Flash Controller support To: Boris Brezillon Cc: linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, arnd@arndb.de, brendanhiggins@google.com, tglx@linutronix.de, anders.roxell@linaro.org, masonccyang@mxic.com.tw, piotrs@cadence.com, robh+dt@kernel.org, andriy.shevchenko@intel.com, qi-ming.wu@intel.com, cheol.yong.kim@intel.com References: <20200414022433.36622-1-vadivel.muruganx.ramuthevar@linux.intel.com> <20200414022433.36622-2-vadivel.muruganx.ramuthevar@linux.intel.com> <20200414090459.3c37c961@collabora.com> From: "Ramuthevar, Vadivel MuruganX" Message-ID: <9b638a65-04b7-5708-ea00-0e6dd47bab8c@linux.intel.com> Date: Wed, 15 Apr 2020 09:51:22 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200414090459.3c37c961@collabora.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Boris,     Thank you so much for the review comments and your time... On 1 4/4/2020 3:04 pm, Boris Brezillon wrote: > On Tue, 14 Apr 2020 10:24:32 +0800 > "Ramuthevar,Vadivel MuruganX" > wrote: > >> From: Ramuthevar Vadivel Murugan >> >> Add YAML file for dt-bindings to support NAND Flash Controller >> on Intel's Lightning Mountain SoC. >> >> Signed-off-by: Ramuthevar Vadivel Murugan >> --- >> .../devicetree/bindings/mtd/intel,lgm-nand.yaml | 61 ++++++++++++++++++++++ >> 1 file changed, 61 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/mtd/intel,lgm-nand.yaml >> >> diff --git a/Documentation/devicetree/bindings/mtd/intel,lgm-nand.yaml b/Documentation/devicetree/bindings/mtd/intel,lgm-nand.yaml >> new file mode 100644 >> index 000000000000..361e5051c602 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/mtd/intel,lgm-nand.yaml >> @@ -0,0 +1,61 @@ >> +# SPDX-License-Identifier: GPL-2.0 >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/mtd/intel,lgm-nand.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Intel LGM SoC NAND Controller Device Tree Bindings >> + >> +allOf: >> + - $ref: "nand-controller.yaml" >> + >> +maintainers: >> + - Ramuthevar Vadivel Murugan >> + >> +properties: >> + compatible: >> + const: intel,lgm-nand > intel,lgm-nand-controller Noted, will update in the next patch. Regards Vadivel >> + >> + reg: >> + maxItems: 1 >> + >> + clocks: >> + maxItems: 1 >> + >> + dmas: >> + maxItems: 2 >> + >> + dma-names: >> + enum: >> + - rx >> + - tx >> + >> + pinctrl-names: true >> + >> +patternProperties: >> + "^pinctrl-[0-9]+$": true >> + >> + "^nand@[a-f0-9]+$": >> + type: object >> + properties: >> + reg: >> + minimum: 0 >> + maximum: 7 >> + >> + nand-ecc-mode: true >> + >> + nand-ecc-algo: >> + const: hw >> + >> + additionalProperties: false >> + >> +required: >> + - compatible >> + - reg >> + - clocks >> + - clock-names >> + - dmas >> + >> +additionalProperties: false >> + >> +...