From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753481AbcKOOYx (ORCPT ); Tue, 15 Nov 2016 09:24:53 -0500 Received: from mail-sn1nam02on0045.outbound.protection.outlook.com ([104.47.36.45]:43776 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751088AbcKOOYv (ORCPT ); Tue, 15 Nov 2016 09:24:51 -0500 X-Greylist: delayed 938 seconds by postgrey-1.27 at vger.kernel.org; Tue, 15 Nov 2016 09:24:51 EST Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Thomas.Lendacky@amd.com; Subject: Re: [PATCH] amd-xgbe: fix unsigned comparison against less than zero To: Colin King , References: <20161115121842.5774-1-colin.king@canonical.com> CC: From: Tom Lendacky Message-ID: <9b6547cf-a37e-e7b2-d725-4bccc1fb2dfc@amd.com> Date: Tue, 15 Nov 2016 08:09:06 -0600 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161115121842.5774-1-colin.king@canonical.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: SN1PR12CA0001.namprd12.prod.outlook.com (10.162.96.139) To CY4PR12MB1141.namprd12.prod.outlook.com (10.168.163.149) X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1141;2:bmcBF5wJbNi6eovmA75x98v1dCZFYZtdNzdo4V7/u8dvkNDJ5O6YSNvSQkCaf/6oZBDCkMa9ibojdkhbBbUjIjr/gyXghafVT9e8pMoh2Ii0WVpqg+ZbPk8FyVU8P89FLu8mS3Yoczhp0lWhq7xp20kt4m0juLPkXI69669d6Yo=;3:EGtfya3CGbQNh4tJDcsiBFB5WNAHTltZmxR5QB/tX6gJvuADSyCHqemQ70taYbwojTpjngaDnNgsYWGcEza6e6V9j2vdpINjdFYM5BJUy52U5KaCbpOB3ZL5EnXDifvdeLAD+P43r8MweKksIC77Oqh7cp58vTRNKQpqYOlnLT0= X-MS-Office365-Filtering-Correlation-Id: c9302518-2249-46dc-ddd3-08d40d60f8bb X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:CY4PR12MB1141; X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1141;25:drGBdkrl63RxdH5qCfSaGHio+4ccL0qtHbBD/ucmwweyqa2ituBRg1vdvRkGim/UvXY8Ptj3wMvjduRiMYN14x2zNCfVIHhlHV0j/F3OQuU9Dmonqn90CM9IueO87CO59P/t1gEsxsz/BkTg3kYNEokUoa8RHlXQmSTSTb4XqJQOyTCy7LZtRSP/UhoUUab3M+IaBWuYVJUsP9v7ItvUsjpgqqHHloAY5JsRDA0BkEag7ajvmH4lmpozJfH4mU/Q8DsMtVuo6MOYLYocNorS5D6a85eYuH9PcXk/fVDCfQofjikaYjUJXf7DLuuLB6gZQAB3nSdAWXxnlk71QwWqX2SAdckkwesUXcygpUdFW6ymWmq9PLGkGvM2HCJtJj7t6WHFRgxak0vdAazLhPDmUniaTIlbLvO0Pf+ysd3/C+/F0Wpm5F6iNUnR1YOjwheWq4bWsVXbH0Qf/DLY4H9AWqZt1HySEGQAsh3ZAYNzzOMdlTbNpjd5zcXD0lbqWKDpbVIpjEmRdUmJouq7oliJthKKde+QQCWQELRx+WR0ucRjwd5TlfQWC8fGSha8QvoAURO1zW5XmWFZztViEkkw/4NwO4wEoVCiOIIi06lwiscAquc1ZA8TBpcBIQA4e7eWGkEOZHuJ2HvV2FR9XIN3Wq996mfOVElrstZt2iQHjJsyiagYeqZqQKvjK1chbVxwTREGpEj89gi0RCWhT/GrewupbLttEmekUUa43pqBrm4= X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1141;31:Fd/Z3byX7rWq0Kofo1dxEQN4k3VbZdd1KHkOFRuAzZUkZS/iZdW7mRIEaSog00RNUkY+AZtlQGoZU7t3P0ggUqn12e4XyrW32v1Ob8D7SvYY8PmrYeDIhEI30Dk/HbV2WRj+1oe2sK5t4duFQdGfXGG5MhrACsrWIjg6HpRlSOHuLIJnVD3GktSLsiZcFCV/IsBPDCH50F5WZt0WKs7Nv2vhY0GWHxk7Ql/nxUpf3AH6KjeliuWMWw1Ulf5shQB8ZINFWrx+rumsp7GyzIYZnw==;20:Vg9YHRarMjusv7dQIkvTLZ38koBZNM5lu9DF2f8SOXmLmtffOp6f6Gr+C+NVIoXrDSyR/WWIXkWzb38HPEGtVVqCYH0jcBSewaHYNzHf7cnmR4/s+8LbxbM23eYmCFV5QDbKulpgd1CY+7iZmGFMgc+YZtmT7YPsxrWm6e6dC30wi9j3tzQ9cUZEHuXUunsrxfLdM/P/Pf0tEEvKPBRhjH9uUCKmJPwgA06FiBqgssBjCESEg79vD7hW7KR+ql8ZXJzagmNDArqiqn3HHW7I9XtKflyqsUO1CPEhSIa6RnokHcje80nJ+1R2btGvZ1nZLwaRyt8WnMW9I5MM1+aNXa8HsG3Dot/9zr+NR6NSWwCyOqj0zREP58zoW7I0UEw5NW6Ae7TBxGChEK1lFzW/GdREYE1yPPTEMljVsOelyl3R9BWBB9ry0XsMVQd/34x+5XCgyIQ2W+gnGqm5GjGCSc50j1KKKFZLRkwUsM5ixeqWD3zvMIZ06/sD2NR7ypaZ X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(198206253151910); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6060326)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6055026)(6061324);SRVR:CY4PR12MB1141;BCL:0;PCL:0;RULEID:;SRVR:CY4PR12MB1141; X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1141;4:Y3kL4J8jNTRMfdNgC7QwxlRR7il0Q70S8WCyHc76xEE8+K8v1fk9hkYBaX7HnPz4ZbIOd6VaDQP8USuD4DGc/9Pu6gEQI8qBDy4JJtzx5atq3JaIwXnl75TKjtvHkyemjOlR3BsnnWCpKHhmB2cgmpfZjvypl3QATzfM9eMm3ooWJqMBhoBeDMQ+o3qeXjBcXwI4rUn/GbGwcVrDoREEVCGLxl+qel2+J1z3/y9W7j+KyPGbBm1l1Shs0c5Le7uTlAzxxPOxEWtuFKW1V25HFKW6rTewS9UQ2ufNjXcqDqjPQujSsOMMj0Kim3UyUM0EG2NBf5Y5CaQKhTZyNmBDlTo1/Ry3eXoHfPCWQcBKxDoK51jfsamDrBQyjNq7ioz9RS+Y04bnFw1LwlbnmqpGb/kZBr0nF0SqqKTiyP3EmT/rkSYM9jdxze2M1DvKL5aVaXPTOni1D3CC+2vJRuSVpcKxt5v/sJPNPHfDzf259eU= X-Forefront-PRVS: 012792EC17 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6049001)(6009001)(7916002)(24454002)(377454003)(189002)(199003)(31686004)(8676002)(105586002)(5001770100001)(83506001)(92566002)(97736004)(7846002)(81166006)(47776003)(66066001)(23676002)(6116002)(189998001)(3846002)(33646002)(42186005)(65806001)(68736007)(2950100002)(65826007)(65956001)(101416001)(4001350100001)(2906002)(106356001)(7736002)(230700001)(81156014)(76176999)(305945005)(54356999)(31696002)(5660300001)(50986999)(86362001)(4326007)(6666003)(229853002)(36756003)(64126003)(77096005)(50466002);DIR:OUT;SFP:1101;SCL:1;SRVR:CY4PR12MB1141;H:[10.236.64.222];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTRQUjEyTUIxMTQxOzIzOlZpVHkvc012RWJEWjd5TTRORmxvSWxQSkN1?= =?utf-8?B?U2p4NGM4OUQ3ZGR6aXZnWXIwL3NXUHRDUjZvRnJET0prN2FsN2d2dVRkM0JI?= =?utf-8?B?T3RHeG4yU3V1b0VHU3N3U2RDaWxDd3F5QWZ6YXhVTHd3T1NsNURVM2JaM1pk?= =?utf-8?B?aGlMSXRWZTRXNW51ZmVQL2ZHb0NsdlF1ZWxVRDVMOUJ5VW9CVC9EcUwxTmFC?= =?utf-8?B?L0htK3RVVXhGT3FBekFIZlBpcGc1d0NzOGhxMDlZcVhPY1VWS0NHRmhvWVJp?= =?utf-8?B?UlIvKzhOM3NRQ1pHN2c2TGJPZXZiSTFnanVHSjFINGI5Z2VBdWR6U1NmcFd3?= =?utf-8?B?NnNjNHlBcEZZNVVCTlNPRTQyWkRZbzR5SjhhQUN1QVhSMjZ1RHdweWw4Y0d4?= =?utf-8?B?bTdhQTF0b0h2QnVWNW1HOVFtZ1gzZGFBV29sQlR2Z2NibGRpTXp4Y2o2SlpH?= =?utf-8?B?dnJOQkJPTjlHcEU3cVJXK09hT2R6SHNZbTZlMjhPd0VubU1ZeGJkTW8yK2hm?= =?utf-8?B?NnA1NlNjTWVVdWdWdmlXWElrbXJiZ2hrejEvTUNPZ1hiUmVCbE9UbzhHZFk1?= =?utf-8?B?YVlJUnlGVjh3OGxRR3IyTWJRZmhCVzFIaGNtY3E2M0src2xrNHlEeGs4cE94?= =?utf-8?B?eHR6T0RQek10MndvZEdTbHRLemhmZ3QrN3hOTkcrdUJpeWVFOFEwQjNRYnh3?= =?utf-8?B?OTZ6ZGN4bk9jZUxhSWw4U2JTLytId3RHNlRSQUpUbFR0akRyYXZTYk9mam1x?= =?utf-8?B?Q1QxNmc2em9JTHBaMWprb1N1TytwTlRDTDFDUVpiZERyREMxbml2MzhRcEJy?= =?utf-8?B?L2xYUEpVVHo5Yk04VThITHUxZlYzZVJPU0tEeGNCcnZYazhaYmZBZGpzT2Nt?= =?utf-8?B?OUR5em15TkxOWElDRFB1Tnc2bFc4S09sWjBoaG8xV0ZmblZGekRuZSs0ejJW?= =?utf-8?B?UU1kc0trQkl0TnNmTm5XeEcxWHlFdFdUaGRXT29DWFo5TlZXUG0vNGtES3ZN?= =?utf-8?B?QlEzUFA2ZUxOa3dDNFpYT3cwLzZPT0h5REsyemtiMllndHd4WjVTM2tiN0hr?= =?utf-8?B?WWczUjRQTGNDVU1oUlRETGJTUHhPbWFCdUJ2dEJUOWtVYnVyNVlTRGUrU3Jw?= =?utf-8?B?SkRXdkxwOVVweXR0azV6czRSNGlYMjZmZ2c4Wi9TRWFCQW5IU0lBU25YZzVZ?= =?utf-8?B?dTdDVnRaWmlHOVVUTk1nWHVUQlhSL2VHSXpjYTJXV2FnUW9EU25BYmxIOGd2?= =?utf-8?B?Z3NneUE3dkNvbmZVT1VQUVMveGQ2MWZpU1JPbnhpWDZUNTBmOEpSUXNFOEUr?= =?utf-8?B?VW45bjNsME5nZVI3NDJqdFFRTHRCY0xNbEZlVXJSS0hLYm5GSmd4dGZMdlp1?= =?utf-8?B?QWJNYzVXTlNVV0k5aHBZQ1ZBMUVqRzNsQWFNS080aGkyenlkdklZUnhtSnUy?= =?utf-8?B?OXBCcDM5Z2pXY1RDNDdMbXozNHM1UTQvZ3FIRzNRa0RaaWwrcWNSeW90cVB6?= =?utf-8?B?eUU0RlBkdGFNdWtOcG8rRkovSlJMS1hOMmRZZHBJZ0hERWpxK2dYM3lzK0ty?= =?utf-8?B?ZUpLcFhCbmVpWUZ2RkVjd1JzdjZITCtOdmNTS1haSkVBNFRVcC9mUzR1Z1lI?= =?utf-8?B?K0JZelp1RTFVNUxtdEZRRVdXQUJBdlhta1BqZnU1Vkh0WkNoYjhDK3lkMzJK?= =?utf-8?Q?0iJa/NcTqs680VTx9WQDYa/2nukI6+1qaG6dE0t?= X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1141;6:wZNi7K69+kZjYlE2APHw/mt1d8N3Az6Omw6VWNzeVGgcx0RAOoyKkG1XfmURFAweEMDuWpB+8PwmoCnJW5d2LqvyJOCKAsYvbjQflzcpdWyqvT9EZdSfdtgFqf5uCjsu8Z4+Y0Wk7vd5v0Ov1PdbS3HWh29pFVhcQLDZ5IyAFFKmJmticTrccpjE2zgvqfRBbSIMv3X9zlkwZ3IJK0jF88AkODZw22KXyd8d8Jj1iuZViCdCo4WHFQlUIx/rIs02oINfrE3iA/EG58BtU410MV3qRaw/RS+CsD5ss7Eo/3iXESZ+BQgd257Nnbfy5t1TFDa4WM6jc8+SxSwyPPcnsVK/I8F024fzFS9N8EsyxfT6v5H+x0GiiRv86dRvmnLx;5:/oMAvx1hR3zmFDMaehRGOtGK1OlnxmELBblqIBwVoPr68+965lH0NUy45B4hAzTR1OknIKMlNv9pDVDqzU2cW08YRtWpzOgmczcQfoSmt+QoIVe3cxpNQaW3P42cEgtuCZeXR/xMjr1Lwe7+0l86SA==;24:mRWLUcqkDy0FjOnloBCz971WKyWoPArP0q0xm8KHwTy4pTpmHasyR5I3dR9KHs4ICF5stwzTTxKsx96CX3TwnDAtO2iUkacDHn76fZlKAbo= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1141;7:AJEKfAEnvexAetRaOWcIIZon9KTqzYZQXbOVR1iEHlKKXWZgjSLpDZd6da63VAKL5F7nwjEhq/ly00YoJxRBTrT9zY5at3RN/QyAudKREseVTA7UFIvpIXXhswmmmE3BWVD+8xyTCpZ93SmXYl97cjyhBuysRh21Nb7mMt8Y6CHNe5edmq0zNlelrkafdSxkgSXIku2vk3Z9pc+iobGASrNQqbRTxdmnoO9LVisEziCiez0q4yA9N4KAz0yl8FpRu3M8aWaEAjMI1Afj52MYFEWj9DDRpbsNXiWCP4dsgzBcBfkJQUgMWQ5Css2dAh0avTLWIGrmIzQM2DIRgSl1gdc2pfxCcgpMxiN/6mihMmk=;20:lRj2emlVPyf/4Txdj84MOiLnLghbfVE8ecPkN4mWwT0HYczgqWLDhmrSZiivWo2K0040IbYEMDaVxtCSEqtvcBob4CohlN01TCIqpcS4O2agUxk9ORTOlUFrRpzMp4CnBShQOJw+mS7pFLU/fo1n2R5BIlXsW+ZRdn8wCrtWuueJgTHZtFwrZZJ/YbS+g4FPj3LyNMBuwMoKaLb0aaArM4UfdYEj5+kB8fdShYXECMy8dYqqTuzSD4tCoRPzCg1K X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2016 14:09:10.4963 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1141 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/15/2016 6:18 AM, Colin King wrote: > From: Colin Ian King > > Comparing unsigned int ret to less than zero for an error status > check is never true. Fix this by making ret a signed int. Reduce > scope of ret too. > > Found with static analysis by CoverityScan, CID 1377750 Thanks Colin, this was already identified by someone else and I submitted the patch yesterday. Thanks, Tom > > Signed-off-by: Colin Ian King > --- > drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c b/drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c > index 4ba4332..168507e 100644 > --- a/drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c > +++ b/drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c > @@ -2346,7 +2346,7 @@ static bool xgbe_phy_valid_speed(struct xgbe_prv_data *pdata, int speed) > static int xgbe_phy_link_status(struct xgbe_prv_data *pdata, int *an_restart) > { > struct xgbe_phy_data *phy_data = pdata->phy_data; > - unsigned int ret, reg; > + unsigned int reg; > > *an_restart = 0; > > @@ -2365,7 +2365,8 @@ static int xgbe_phy_link_status(struct xgbe_prv_data *pdata, int *an_restart) > > if (phy_data->phydev) { > /* Check external PHY */ > - ret = phy_read_status(phy_data->phydev); > + int ret = phy_read_status(phy_data->phydev); > + > if (ret < 0) > return 0; > >