From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BCD0243D4FA for ; Tue, 16 Jun 2026 14:12:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781619132; cv=none; b=qyyvizaLIULFCKd5VL7g8e/7JsYkD0hbCDD9xBTOHraS/YkG9Znn3XSc7av0qOsr5GMb/rlSyCaKwonO8ZpgsPx8PRE5wb08v7UMr4lKIrig8a6939kDkAn4BpT8Zj1MVbAQy06hOAEht2aq8xtm3s16mGb0ki6/3Bazzedxo+o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781619132; c=relaxed/simple; bh=x8yUfoFxAhFDRRTit9rI8yq1i0xp7HebowNy8+VsCYA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=UF4djso9AIfFhOdMhUr9aq7BMPAujKsmVVjIHgHC5ZKr4czygjpJxKZTLt3oqk9NYqd3vjZluyNQw7G8Wzdf/GSHU5I4cLwjecIrKsddAsiEA4DHBITRw71scHTwSs1wwxLFHLowGKnTB2/4F3xMDymSeUImEiIcU7IK0Ei2KwA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=aR8e4pR9; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=eUgaf8K1; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="aR8e4pR9"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="eUgaf8K1" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65GDxYQh3969896 for ; Tue, 16 Jun 2026 14:12:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ZNKddDCUUUEc5ctuxhNZJ1Zf0qD7W5gI4Bn6S7GosKM=; b=aR8e4pR9e2/VkYxN 4kR47l7J4EwdQ25zsKydqm2Sf32Qa1+lzPsRyA76Qaya007y8eUI58+9AFn8Qk8K yj1Mh3xo0nP8LLnmgpKFIa2AMam800PN2VeOobtlh5LmRGdfDWMIQ1IyD26WJR9Q pt5M3qGVQiTxTmBQX3lXTAns1yf2ulBDiZJ4K4GR+uU164ZqFdQhaIe82rjo3715 p9P4XhDqGfh3ymsIY7NtQ54V5+78POHI4oaUM8QTvvP7o0KvpIN5SUk/nmajRpR/ 4EPSqxpd25YnjfuEeBNnrDDkFVQwYV9W3OXM/b1sstcLQVMt5K8w6OF5ettMDXEA xXlpXQ== Received: from mail-ua1-f70.google.com (mail-ua1-f70.google.com [209.85.222.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eu4dkh42g-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 16 Jun 2026 14:12:10 +0000 (GMT) Received: by mail-ua1-f70.google.com with SMTP id a1e0cc1a2514c-966ca0f25a4so25023241.0 for ; Tue, 16 Jun 2026 07:12:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781619130; x=1782223930; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ZNKddDCUUUEc5ctuxhNZJ1Zf0qD7W5gI4Bn6S7GosKM=; b=eUgaf8K1uDckH63M9yi6YPpVLNNAWGGLRWXhj3/pjoI7nz1714Z/aYMlMi+VCtKN7L zTabLasRESRdOWufiu3/bOCeYUNBlzjGwQVKGhjm7bu+jagyUWQ58uVQcEJt3rw66md9 xK00xPrfVNKI8rNZYhrGxktHcFpdZWdyc3wwdKBvE2MVB0FeFcGE1k9m1LUDB1j9HdBw b0ppg4b4weKhRtlH2t+c0dG8WgFZ10Au+9gz7zBre4aJ7wawQsTeertUxoeCMcGeIsBk ICJEuNq/+258Eq+Hi9W/oqzhUInF6WJsgiVvdNg1EEjKvvytSzWSzddZL1akQM7dxUXc zM6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781619130; x=1782223930; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZNKddDCUUUEc5ctuxhNZJ1Zf0qD7W5gI4Bn6S7GosKM=; b=Q/++ld5snXhs5o25NWEvD9DhkANYmfZmNZ3NSZruHPZNkkxDcN+cc5yxrkha++XngJ nyHANYY5ZVAfzsNZRUTJet4cxjVst8dAjdKji+SsqHJRifi2dS8Rkk2Rya+ArWjnr9Ou wp5D6wncYDc1NDRAEVG6tsVFRFdL8+QwI1MHQiTIP/YdSoj5LCPwIlcGwguLXTUyCfYh zd2VbrczGBrzdXbvt9oKfZ+e6/GezqfjYPjVr/pZ+6/pDli0BFsvqoawK5MGQegY/aqN OOTmop7mPTJb61Pzq/6e1rTDbjgBK796GQ6rIFy7Uw478hDEgXsVYOd/pGx0DOC1FwLB a/vA== X-Forwarded-Encrypted: i=1; AFNElJ//4c8IbYVV5kS8Vx0GVlJsJWcjiKcEsBh1qLv/BSdNdzRoGGEYI4px5DiTCfw1/gns6XaMWOzzap+o/rI=@vger.kernel.org X-Gm-Message-State: AOJu0YxcdTAFTqPt6+cHmvWeGE42iw/zYAojx5hFXgWKb/ELVb3UnXee w/CkH7WTvxEFJX0h4o9YAQivLygBt55ADSY+QE9WuvHAvISUKCNcWl7F4F96XqcFEAJ1DpecZ6s hTgD67vAH6LEk/NOOgsbk++GJnXcPFfgjiRx8xL66o6kpHIDcZfrFMwNKzgN2ZQ+cRm8= X-Gm-Gg: Acq92OEkPTjjTMJf6NMwZjZWMuKsS1MkYX8/XaWcLPDwJCjNt9Yr7dQ+B0touXQJdsk IJOr/wpf2j1CI4StZ7sdFCRgbQFEGY7ElPvqVMtGY5myFhH1/+L1U03gwoVrPvuKPvRtAuF2qd+ GVKGgw7ihEP4mJ8gmOffC3uodPCL13kCqUFBMW82V1l50k3efddtIHY9EczHl+EYsdJEYp78Q7I 9LtM0oTAftl+Cm2nV4VNf5iIKF1a64DgikG/s5MGL1Iyy7YTDpYSdiPB31ADM0EUbXu9ILLZZwz nsgBk+e37v25Y+7GotALKe0vEzgfiexyDZVLzVZjIEN35//6+jZwAmAZS2qc8tAmFCFM3ULebQQ 7b1xzWtlCWDHS/fnCAZlTY5U9UIQq3ZZpu/kKtRfXQHB1Kw== X-Received: by 2002:a05:6102:3913:b0:634:11ac:12ca with SMTP id ada2fe7eead31-71e88f90c91mr3142974137.5.1781619130028; Tue, 16 Jun 2026 07:12:10 -0700 (PDT) X-Received: by 2002:a05:6102:3913:b0:634:11ac:12ca with SMTP id ada2fe7eead31-71e88f90c91mr3142950137.5.1781619129480; Tue, 16 Jun 2026 07:12:09 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bfdb5103710sm656788966b.22.2026.06.16.07.12.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Jun 2026 07:12:08 -0700 (PDT) Message-ID: <9b66d6f8-7eda-4eca-ac3d-e1dc8306c677@oss.qualcomm.com> Date: Tue, 16 Jun 2026 16:12:06 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] clk: qcom: regmap-phy-mux: Rework the implementation To: Dmitry Baryshkov , Bjorn Andersson Cc: Michael Turquette , Stephen Boyd , Taniya Das , Jagadeesh Kona , Konrad Dybcio , usb4-upstream@oss.qualcomm.com, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260409-topic-phy_fastclk-v1-1-6b4aaee56b90@oss.qualcomm.com> <178093139446.244194.9422100472802070367.b4-ty@kernel.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: Rd9xonSjeYUNtyATp1z8VxHZ03LdqdW2 X-Proofpoint-ORIG-GUID: Rd9xonSjeYUNtyATp1z8VxHZ03LdqdW2 X-Authority-Analysis: v=2.4 cv=Ibi3n2qa c=1 sm=1 tr=0 ts=6a3159ba cx=c_pps a=R6oCqFB+Yf/t2GF8e0/dFg==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=jjNbzz9fy_0zEZUIXogA:9 a=QEXdDO2ut3YA:10 a=TD8TdBvy0hsOASGTdmB-:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE2MDE0NCBTYWx0ZWRfXzJRXpTKYsd5X q1FgroN8eG601yG7bjiU82FZHXCOFZTR1JPz6KWaqhz4s6YtUIw0CYP83tlMlL7z7elYWR3fKMr s75K/MY5CZM0ZmYtnir4WsdC+PGATZ1sBC8KrA3HlpYsLfAlkzE6OlDLE9ETjVN5xVbX91/+o2B IYtObmcgJ8LH0XfNHQhkCOpYrQ/F48bzAuQyvbtdm/QrDje605y0uBOiwY3OYN048+sdkaUdojn xPoQTkOP7xSx01IpX8J2ZOEhRYaL8Pfub+ick6GyfpwLxZEB8naelc9rcf54tNzjH6GzVjixon0 u2nonqoE5BOwwFsL6godl92eUcQ5yUpi8hmwsti472ILjYgD8XABRZLiOf1R+YbQGMVm7Rpo5Cv 4z069Ge7CeleBATgxK8Wrc7EX47qNDryHVrHxyMFqYc9/dXaUvGApfx+NaBkLxFUuF4fGcS5cCK NiAyLFyG+N/t6sQ/hgw== X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE2MDE0NCBTYWx0ZWRfX3fmWzt64w1Xw uamWLWZaqCXNjI06JAGPfFsQw1Uat7hl4tjyiWAibV3R5aHlpYr14K3JE2jCtj+n0qiQkfNRX70 K7rj8cT6+CISRH8JdVctdXj51EwsoZs= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-16_04,2026-06-15_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 bulkscore=0 clxscore=1015 priorityscore=1501 suspectscore=0 lowpriorityscore=0 impostorscore=0 spamscore=0 malwarescore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606160144 On 6/11/26 9:38 PM, Dmitry Baryshkov wrote: > On Mon, Jun 08, 2026 at 10:09:55AM -0500, Bjorn Andersson wrote: >> >> On Thu, 09 Apr 2026 13:57:45 +0200, Konrad Dybcio wrote: >>> The sole reason this hw exists is to let the branch clock downstream of >>> it keep running, with the PHY disengaged. This is not possible with the >>> current implementation, as the enabled status is hijacked to mean >>> "enabled" = "use fast/PHY source" and "disabled" = "use XO source". >>> >>> This is an issue, since the mux enable state follows that of the child >>> branch, making the desired "child enabled, MUX @ XO" combination >>> impossible. >>> >>> [...] >> >> Applied, thanks! >> >> [1/1] clk: qcom: regmap-phy-mux: Rework the implementation >> commit: e108373c54fbc844b7f541c6fd7ecb31772afd3c > > This breaks at PCIe at least on SM8350. The attached WiFi card is > not detected anymore. Rewerting the patch makes it work again. Hm, that's anticlimactic. Can you please dump: gcc_pcie_0_pipe_clk_src: gcc+0x6b054 gcc_pcie_0_pipe_clk: gcc+0x52008 gcc_pcie_1_pipe_clk_src: gcc+0x8d054 gcc_pcie_1_pipe_clk: gcc+0x52000 Konrad