From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932237AbdJXIJY (ORCPT ); Tue, 24 Oct 2017 04:09:24 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:48205 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751604AbdJXIJS (ORCPT ); Tue, 24 Oct 2017 04:09:18 -0400 X-Google-Smtp-Source: ABhQp+RaQh7URoU1HVj5SgVjEPW3GZIWsPjNBunt2u5lchvF/KQo9ZIpnncR15f3jt78PKv9U8QqfQ== Subject: Re: [PATCH 2/4] dt-bindings: display: amlogic, meson-dw-hdmi: Add optional HDMI 5V regulator To: Rob Herring Cc: airlied@linux.ie, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org References: <1508227664-11171-1-git-send-email-narmstrong@baylibre.com> <1508227664-11171-3-git-send-email-narmstrong@baylibre.com> <20171023224625.oiswnpgmxzhg7aep@rob-hp-laptop> From: Neil Armstrong Organization: Baylibre Message-ID: <9b69d42b-ffc5-32cf-1509-ec8e74fc3825@baylibre.com> Date: Tue, 24 Oct 2017 10:09:15 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171023224625.oiswnpgmxzhg7aep@rob-hp-laptop> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24/10/2017 00:46, Rob Herring wrote: > On Tue, Oct 17, 2017 at 10:07:42AM +0200, Neil Armstrong wrote: >> On reference boards and derivatives, the HDMI Logic is powered by an external >> 5V regulator. >> This regulator was set by the Vendor U-Boot, add optional support for it. >> >> Signed-off-by: Neil Armstrong >> --- >> Documentation/devicetree/bindings/display/amlogic,meson-dw-hdmi.txt | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/display/amlogic,meson-dw-hdmi.txt b/Documentation/devicetree/bindings/display/amlogic,meson-dw-hdmi.txt >> index 7f040ed..bf4a180 100644 >> --- a/Documentation/devicetree/bindings/display/amlogic,meson-dw-hdmi.txt >> +++ b/Documentation/devicetree/bindings/display/amlogic,meson-dw-hdmi.txt >> @@ -48,6 +48,10 @@ Required properties: >> Documentation/devicetree/bindings/reset/reset.txt, >> the reset-names should be "hdmitx_apb", "hdmitx", "hdmitx_phy" >> >> +Optional properties: >> +- hdmi-supply: Optional phandle to an external 5V regulator to power the HDMI >> + logic, as described in the file ../regulator/regulator.txt > > 5V into a modern SoC sounds strange. Is this really for the chip or for > 5V to the connector? The latter should be in the connector node. > > Rob > Hi Rob, The chip does not get the 5V but multiple derived voltages, but depends on the 5V regulator to enable this power supply for the connector and to the hdmi io bank. So in my opinion it's not related to the connector but to the HDMI logic. Neil