From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2233C433EF for ; Fri, 15 Apr 2022 08:13:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351344AbiDOIQE (ORCPT ); Fri, 15 Apr 2022 04:16:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48484 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233212AbiDOIP7 (ORCPT ); Fri, 15 Apr 2022 04:15:59 -0400 Received: from mailgw01.mediatek.com (unknown [60.244.123.138]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 496E5369EA; Fri, 15 Apr 2022 01:13:27 -0700 (PDT) X-UUID: 8abe4c720f0946c484fbce4e5ca84cf0-20220415 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.4,REQID:2c2c4a2e-b4d2-4e51-83d6-68e165bf66ee,OB:0,LO B:0,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,RULE:Release_Ham,ACTI ON:release,TS:0 X-CID-META: VersionHash:faefae9,CLOUDID:154e3ea9-d103-4e36-82b9-b0e86991b3df,C OID:IGNORED,Recheck:0,SF:nil,TC:nil,Content:0,EDM:-3,File:nil,QS:0,BEC:nil X-UUID: 8abe4c720f0946c484fbce4e5ca84cf0-20220415 Received: from mtkexhb01.mediatek.inc [(172.21.101.102)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1508866549; Fri, 15 Apr 2022 16:13:22 +0800 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.3; Fri, 15 Apr 2022 16:13:20 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Fri, 15 Apr 2022 16:13:20 +0800 Message-ID: <9b6a3c4b403d15c08f5c4693549fadde50f5bca3.camel@mediatek.com> Subject: Re: [PATCH v18 08/10] soc: mediatek: add DDP_DOMPONENT_DITHER0 enum for mt8195 vdosys0 From: Jason-JH Lin To: Rex-BC Chen , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , Chun-Kuang Hu , AngeloGioacchino Del Regno CC: Philipp Zabel , Maxime Coquelin , David Airlie , Daniel Vetter , Fabien Parent , CK Hu =?UTF-8?Q?=28=E8=83=A1=E4=BF=8A=E5=85=89=29?= , "Yongqiang Niu =?UTF-8?Q?=28=E7=89=9B=E6=B0=B8=E5=BC=BA=29?=" , "hsinyi@chromium.org" , "fshao@chromium.org" , Moudy Ho =?UTF-8?Q?=28=E4=BD=95=E5=AE=97=E5=8E=9F=29?= , "Roy-CW Yeh =?UTF-8?Q?=28=E8=91=89=E4=B8=AD=E7=91=8B=29?=" , Nancy Lin =?UTF-8?Q?=28=E6=9E=97=E6=AC=A3=E8=9E=A2=29?= , Singo Chang =?UTF-8?Q?=28=E5=BC=B5=E8=88=88=E5=9C=8B=29?= , "devicetree@vger.kernel.org" , "linux-stm32@st-md-mailman.stormreply.com" , "linux-arm-kernel@lists.infradead.org" , "linux-mediatek@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , Project_Global_Chrome_Upstream_Group Date: Fri, 15 Apr 2022 16:13:20 +0800 In-Reply-To: <542a3946c33b4a2e7cbb160f0e3bd4479a863ddb.camel@mediatek.com> References: <20220412103114.19922-1-jason-jh.lin@mediatek.com> <20220412103114.19922-9-jason-jh.lin@mediatek.com> <542a3946c33b4a2e7cbb160f0e3bd4479a863ddb.camel@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rex, Thank for the reviews. On Fri, 2022-04-15 at 14:24 +0800, Rex-BC Chen wrote: > On Tue, 2022-04-12 at 18:31 +0800, jason-jh.lin wrote: > > The mmsys routing table of mt8195 vdosys0 has 2 DITHER components, > > so mmsys need to add DDP_COMPONENT_DITHER1 and change all usages of > > DITHER enum form DDP_COMPONENT_DITHER to DDP_COMPONENT_DITHER0. > > > > But its header need to keep DDP_COMPONENT_DITHER enum > > until drm/mediatek also changed it. > > Hello Jason, > > IMO, it's strange. > In this case , I think you sholud squash [v18,08/10] and [v18,09/10]. > Therefore, you don't need to describe this here. > As the CK reply before: https://patchwork.kernel.org/project/linux-mediatek/patch/20220407030409.9664-4-jason-jh.lin@mediatek.com/#24806029 [v18,08/10] and [v18,09/10] belong to 2 different trees, so I add the description here. Regards, Jason-JH.Lin > BRs, > Rex > -- Jason-JH Lin