From: Ping-Ke Shih <pkshih@realtek.com>
To: Zhao Li <enderaoelyther@gmail.com>
Cc: Bernie Huang <phhuang@realtek.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] wifi: rtw89: update PN state only from correctly decrypted frames
Date: Mon, 16 Nov 2026 08:04:21 +0000 [thread overview]
Message-ID: <9b6df144207a4427bc63959a064f6a22@realtek.com> (raw)
In-Reply-To: <20261115172754.35124-1-enderaoelyther@gmail.com>
Zhao Li <enderaoelyther@gmail.com> wrote:
> diff --git a/drivers/net/wireless/realtek/rtw89/core.c b/drivers/net/wireless/realtek/rtw89/core.c
> index 58ee5efc3b5e..a173253d51ff 100644
> --- a/drivers/net/wireless/realtek/rtw89/core.c
> +++ b/drivers/net/wireless/realtek/rtw89/core.c
> @@ -3950,7 +3950,8 @@ static bool rtw89_core_skb_pn_valid(struct rtw89_dev *rtwdev,
> if (!ieee80211_is_data_qos(hdr->frame_control))
> return true;
>
> - if (!desc_info->hw_dec || !desc_info->addr1_match)
> + if (!desc_info->hw_dec || desc_info->sw_dec || desc_info->icv_err ||
> + desc_info->crc32_err || !desc_info->addr1_match)
This patch is OK to me, but can you keep existing two conditions unchanged?
Just add three new conditions.
Or any reason you want move addr1_match to be the last one?
> return true;
>
> guard(rcu)();
>
> base-commit: 5dbf2415ca9821a611d09308e3b29d2c37e7cd77
> --
> 2.56.1
prev parent reply other threads:[~2026-11-16 8:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-15 17:27 Zhao Li
2026-11-16 8:04 ` Ping-Ke Shih [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b6df144207a4427bc63959a064f6a22@realtek.com \
--to=pkshih@realtek.com \
--cc=enderaoelyther@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=phhuang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®