From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FE4B35B644 for ; Mon, 16 Mar 2026 20:55:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773694540; cv=none; b=ItpOZBGgxZwzdxCfWJscA+FvNW0clIiHczirMjPvycEoACPe1JotVWvSiJqSC3ujX77INW1To+6OpqNajEK2o1lBoL0hkWlG3oN2utBBs5GNWVdqA0WaOIdUceoe8ALPPj225zUgjvwv1DeYPrC9fnNP+OJa4OpzhMoFEdJL8+c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773694540; c=relaxed/simple; bh=C+kZu4Yw0goKEbItW66yOGCB2ZUBvnUYDHZ2/fg0u0I=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jniU1qScKml2XnrsKpyFiv5ycBHjh5OWipaFZUNNllgH/Tb/nMrWI/lZL8ZiwRkuIxC+baU5eZENROZguG2uiZvhbYaKaBRGuqmYmxr5dnHsquvK3cLKe1nLYbDxgHERJrdHhml6GZCM97H2VBsrb//wfUvMYffXquaUJxqZQJQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=XHAcJTnV; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=SI2Q9Ddc; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="XHAcJTnV"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="SI2Q9Ddc" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62GF4PBw795495 for ; Mon, 16 Mar 2026 20:55:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= J8ltMeCUJ0Nsuy3U77T/BrncqvvnFsJLNLRyPi9NiG8=; b=XHAcJTnVlXHdRzQ4 7IaKVN/vHTyrTCr39y8CPlkBgJRQZ2egZCafDTmXuPNfAvk7lpy0lx2d0rNIlwpj gqrZOR0nDJLQCJ2A9kvk/7IGG/PXC4C5jakmXuyD3J/VjzvjHi2OKscokepNfXO0 hgnkNxIb6y6U+Hpsztan4feSvLgXUcMgPXFN9Fq5rp4D6GXF4iFvKZE4x43ekrVj muPEQkkgjrnX/0PxDO250/BtsXqCG5ILYta0NC/J9935EoEx8j5ME7ayxGKR9mvm 4iLQZnNSZtcIJsnGOjVrExrAO8I3yfDNrvUErQicXwRhCLYvKV/zctOKUpYSGlwX rgdlUg== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cxm6d16k3-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 16 Mar 2026 20:55:36 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2aec3f67844so52916025ad.3 for ; Mon, 16 Mar 2026 13:55:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773694536; x=1774299336; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=J8ltMeCUJ0Nsuy3U77T/BrncqvvnFsJLNLRyPi9NiG8=; b=SI2Q9Ddc7AqJ9ws2Z0Wv43ppL17UayvF/J+NEKF2tTH9v1eMEKeI6S9gvrSQnL3vLg alfU5JReL0Mwj/8UAGFR6OPh07x81K80t2B3XcK7iHCkhK1pB1NGWDu9mp2v1AOQUx1L rLyZ666Xmh+CHKBGRSijrMejYnX2G72AhrLqOpc/LANYt+lZegRnMNxAXBROb4CQ8JmG OxHmSPhBwSOl5EM/8F6JueCORNGQ5AGAhvBQTZ0aBbpudgWY7WKDYOiJr5MAOjasP0U5 Oa4kA33H8jtP0rgJYnJcJWc/kTr1dNI2sh/cR+2/UchCk4ywGlKywI+1XDcGioP4wBRW UDiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773694536; x=1774299336; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=J8ltMeCUJ0Nsuy3U77T/BrncqvvnFsJLNLRyPi9NiG8=; b=ZIBGAE8WWUsnAB/aFcDQ8GkLpljCkCGKq7SW42jnTs7MLzMsuIqpBEFMdhpofQRVsB ElifYSLDEcBNPEKWghKvWsunbWHZN3Itr1XY7Poir0awiBJibYwpXyiPDH7yTaW5TeOH xJZJH8qkocb3ePm5uNNXE31HEzVLtqV9wYJ0WthS261ED42/AJwTbVTl7TPQ3v6l4ZV8 k2NssT9RWnnG5RyXsNRgutz7tu8LovNSrJY7cCGQ2rz27DDSgpf+rOlIU/eCftxTxb4v 9pdCjLM/sSTLz/Ze0lju5eP9cvLyOJCaearTpfEgZlaGdVjmV7pVDgjZrtG2LUi9JUiz l5gQ== X-Forwarded-Encrypted: i=1; AJvYcCXDb7Wm56eb0jKoNllL1d5Y4XQ9WdXkAQEbDbSnPR0ibBLDKQ7a6yxOYliNOJkzZ2f63QBpEugNz7nteR0=@vger.kernel.org X-Gm-Message-State: AOJu0YwmiF9NXwTekuBg8VWtUyEqoMl7WQTvmUhCBSlfpTA4qVWYPNGH SheMK1ZZy36eZwTcHcoqBfjVinkmlJN3XGNov4HHGmqxm9rwUl02ONBx4NjSy7Nr2ksOWrtUWhD B0auqA4EqSib3r0mt5miqZRq1W6Ay+ZqbYHJV7SGWIzY0jLN8yHqjKLdhCWFA42oevPw= X-Gm-Gg: ATEYQzxRpwZluaRUnBHDaFIyXL+K0tP6wk2zErsFpNa6juBjsYcYZCEaXVeJue5gemM 6EVKh17HdCQXGp/sMKrFtf0QxzAsm7jxcFl615kFPchVv8YkMV5YuJ4w9UHS7kyZADerMjmten6 zrsImq+BOZOyD/FZtr/nb65E9F7lrJy/GjO7kx0TLGrCcrhIDKiK32K9H+pj7NqURG6iTAin7Bs xUmovHlG1IK6BPIf8Lj3JtqDMhnJ2CA8uGrK4unM6rgX1WkTxNJxVO5xGVaGDiQmUSilYZOaR/l rvfvvdZfnqXHFjqmBpwCWmbHfC363ECWCloTw/YVimbTzhDh8Amffsx+eICu4r5Vcf3M6rG4cxh TkSU9XS7ah69j7smQkGmH8a9Z4GcI2BqOYnHeAQZA5UoTAg4LXGjD5TFUJyy9WmFQQ8SUcD2Lgh lLKav8 X-Received: by 2002:a17:903:1aa7:b0:2ae:6012:3168 with SMTP id d9443c01a7336-2aecab1e84bmr145221295ad.32.1773694535621; Mon, 16 Mar 2026 13:55:35 -0700 (PDT) X-Received: by 2002:a17:903:1aa7:b0:2ae:6012:3168 with SMTP id d9443c01a7336-2aecab1e84bmr145220905ad.32.1773694535126; Mon, 16 Mar 2026 13:55:35 -0700 (PDT) Received: from ?IPV6:2401:4900:1c27:17c8:7897:b4f6:fc6e:b55? ([2401:4900:1c27:17c8:7897:b4f6:fc6e:b55]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2aece7ee6c6sm119821975ad.48.2026.03.16.13.55.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Mar 2026 13:55:34 -0700 (PDT) Message-ID: <9b788a02-2b43-427e-9358-483e8dcff3b3@oss.qualcomm.com> Date: Tue, 17 Mar 2026 02:25:28 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/msm: Fix GMEM_BASE for A650 To: Alexander Koskovich Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Rob Clark , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter References: <20260314-fix-gmem-base-a650-v1-1-3308f60cf74c@pm.me> From: Akhil P Oommen Content-Language: en-US In-Reply-To: <20260314-fix-gmem-base-a650-v1-1-3308f60cf74c@pm.me> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=c7+mgB9l c=1 sm=1 tr=0 ts=69b86e48 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=e0mgrY8X18LXsc_zQXUA:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-ORIG-GUID: aw5rk4HJXdoWU54zzYcA7_opiMPRPBGZ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE2MDE3MCBTYWx0ZWRfX/b1Xo6mjdlfT EqVY1sJMnYnMhjBFqCgZF8YU/jtFekrsXJ+A1h5sHyLNjEtTniHwafFlDbjz6rEN1mKUz9wDaKx CcL6ehS8Tfah6WtbYTC9tXG7FodNnTnY7JQtCrlqCD0TJTwbvrwSBVI1zZ7Y0G4eKmpHT9dGN52 fGbLnCPcJWXqg/8Y/kGvj1VK4+8kxJo7+LWeFgMJ+Ntivh8yT6q8jh+xiojlOW2ltEs6AaqnVWl BKnNKvK3sFSOWYNmUsuwZFXxJ5JN/VlPIOvpcAtLYtIJwu/CZp3/VdWV2Ph+F5Q0hsHZ5RELZQt D4hhximRSNJ66PnHfmudCT3IHclEtgibKI8B4nks0L9XD8bTop2+iwlQkRTx+wHYVtsegf3qlW6 NlT7N7Bhq15Ryp5uG0ha6ZVcTxg6jWqpuWmdJMRVNs04ZkNTcQqnLPrGnzxTg/FaNfWCuEM5yRR UEeOpQTfyQxUhSWhCIA== X-Proofpoint-GUID: aw5rk4HJXdoWU54zzYcA7_opiMPRPBGZ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-16_05,2026-03-16_06,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 bulkscore=0 priorityscore=1501 suspectscore=0 phishscore=0 clxscore=1015 lowpriorityscore=0 spamscore=0 malwarescore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603160170 On 3/14/2026 9:44 AM, Alexander Koskovich wrote: > Commit dc220915ddb2 ("drm/msm: Fix GMEM_BASE for gen8") changed the > GMEM_BASE check from adreno_is_a650_family() & adreno_is_a740_family() > to family >= ADRENO_6XX_GEN4. > > This inadvertently excluded A650 (ADRENO_6XX_GEN3), causing it to report > an incorrect GMEM_BASE which results in severe rendering corruption. > > Update check to also include ADRENO_6XX_GEN3 to fix A650. > > Fixes: dc220915ddb2 ("drm/msm: Fix GMEM_BASE for gen8") > Signed-off-by: Alexander Koskovich Reviewed-by: Akhil P Oommen -Akhil > --- > drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/adreno/adreno_gpu.c > index d5fe6f6f0dec..0ac3fba5c277 100644 > --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c > +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c > @@ -376,7 +376,7 @@ int adreno_get_param(struct msm_gpu *gpu, struct msm_context *ctx, > *value = adreno_gpu->info->gmem; > return 0; > case MSM_PARAM_GMEM_BASE: > - if (adreno_gpu->info->family >= ADRENO_6XX_GEN4) > + if (adreno_gpu->info->family >= ADRENO_6XX_GEN3) > *value = 0; > else > *value = 0x100000; > > --- > base-commit: 1f318b96cc84d7c2ab792fcc0bfd42a7ca890681 > change-id: 20260314-fix-gmem-base-a650-cfd9bfcea425 > > Best regards,