From: Jeff Layton <jlayton@kernel.org>
To: xiubli@redhat.com
Cc: idryomov@gmail.com, vshankar@redhat.com,
ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ceph: remove unused CEPH_MDS_LEASE_RELEASE related code
Date: Mon, 28 Mar 2022 17:41:37 -0400 [thread overview]
Message-ID: <9b799a29ec8bc87386bc370a03a11b33ac948209.camel@kernel.org> (raw)
In-Reply-To: <20220328131026.923174-1-xiubli@redhat.com>
On Mon, 2022-03-28 at 21:10 +0800, xiubli@redhat.com wrote:
> From: Xiubo Li <xiubli@redhat.com>
>
> ceph_mdsc_lease_release was removed by commit 8aa152c77890 (ceph:
> remove ceph_mdsc_lease_release). ceph_mdsc_lease_send_msg will never
> call this function with CEPH_MDS_LEASE_RELEASE.
>
> Signed-off-by: Xiubo Li <xiubli@redhat.com>
> ---
> fs/ceph/mds_client.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/fs/ceph/mds_client.c b/fs/ceph/mds_client.c
> index 459c6f23915f..a89ee866ebbb 100644
> --- a/fs/ceph/mds_client.c
> +++ b/fs/ceph/mds_client.c
> @@ -4424,12 +4424,6 @@ void ceph_mdsc_lease_send_msg(struct ceph_mds_session *session,
> memcpy((void *)(lease + 1) + 4,
> dentry->d_name.name, dentry->d_name.len);
> spin_unlock(&dentry->d_lock);
> - /*
> - * if this is a preemptive lease RELEASE, no need to
> - * flush request stream, since the actual request will
> - * soon follow.
> - */
> - msg->more_to_follow = (action == CEPH_MDS_LEASE_RELEASE);
>
> ceph_con_send(&session->s_con, msg);
> }
Reviewed-by: Jeff Layton <jlayton@kernel.org>
prev parent reply other threads:[~2022-03-28 22:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-28 13:10 xiubli
2022-03-28 21:41 ` Jeff Layton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b799a29ec8bc87386bc370a03a11b33ac948209.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=ceph-devel@vger.kernel.org \
--cc=idryomov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vshankar@redhat.com \
--cc=xiubli@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®