Re: [PATCH v7 14/14] arm64: dts: rockchip: enable vicap dvp on wolfvision pf5 io expander

[Gerald Loacker <gerald.loacker@wolfvision.net>]

Hi Michael,

Am 14.05.2025 um 17:41 schrieb Michael Riesch via B4 Relay:
> From: Michael Riesch <michael.riesch@wolfvision.net>
> 
> The Digital Video Port (DVP, the 16-bit variant) of the RK3568 VICAP
> is broken out to the PF5 mainboard expansion header.
> Enable it in the device tree overlay for the WolfVision PF5 IO
> Expander board.
> 
> Signed-off-by: Michael Riesch <michael.riesch@wolfvision.net>
> Signed-off-by: Michael Riesch <michael.riesch@collabora.com>
> ---
>  .../rockchip/rk3568-wolfvision-pf5-io-expander.dtso  | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3568-wolfvision-pf5-io-expander.dtso b/arch/arm64/boot/dts/rockchip/rk3568-wolfvision-pf5-io-expander.dtso
> index 048933de2943..8cfce71dd318 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3568-wolfvision-pf5-io-expander.dtso
> +++ b/arch/arm64/boot/dts/rockchip/rk3568-wolfvision-pf5-io-expander.dtso
> @@ -11,6 +11,7 @@
>  #include <dt-bindings/clock/rk3568-cru.h>
>  #include <dt-bindings/gpio/gpio.h>
>  #include <dt-bindings/interrupt-controller/irq.h>
> +#include <dt-bindings/media/video-interfaces.h>
>  #include <dt-bindings/pinctrl/rockchip.h>
>  
>  &{/} {
> @@ -134,3 +135,22 @@ &usb2phy0_host {
>  	phy-supply = <&usb_host_vbus>;
>  	status = "okay";
>  };
> +
> +&vicap {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&cif_clk &cif_dvp_clk &cif_dvp_bus16>;
> +	status = "okay";
> +};
> +
> +&vicap_dvp {
> +	vicap_dvp_input: endpoint {
> +		bus-type = <MEDIA_BUS_TYPE_BT656>;
> +		bus-width = <16>;
> +		pclk-sample = <MEDIA_PCLK_SAMPLE_DUAL_EDGE>;
> +		rockchip,dvp-clk-delay = <10>;
> +	};
> +};
> +
> +&vicap_mmu {
> +	status = "okay";
> +};
> 

Reviewed-by: Gerald Loacker <gerald.loacker@wolfvision.net>
Tested-by: Gerald Loacker <gerald.loacker@wolfvision.net>

Regards,
Gerald