From: Yureka <yuka@yuka.dev>
To: samuel.thibault@ens-lyon.org
Cc: w.d.hubbs@gmail.com, chris@the-brannons.com,
chris@the-brannons.com, gregkh@linuxfoundation.org,
speakup@linux-speakup.org, linux-kernel@vger.kernel.org
Subject: [PATCH] speakup: remove usage of non-standard u_char
Date: Tue, 11 Oct 2022 02:17:43 +0200 [thread overview]
Message-ID: <9b7e4894-deec-39ba-bb7c-3c6d6427fa1d@yuka.dev> (raw)
From: Yureka Lilian <yuka@yuka.dev>
This code is included in the build tools makemapdata and genmap, and it
expects that libc exposes a definition of u_char. But u_char is not
defined in either C or POSIX standards, and some systems don't have it.
Namely this breaks the build on hosts using musl libc, because musl only
exposes u_char if _GNU_SOURCE is defined.
Signed-off-by: Yureka Lilian <yuka@yuka.dev>
---
drivers/accessibility/speakup/utils.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/accessibility/speakup/utils.h b/drivers/accessibility/speakup/utils.h
index 4bf2ee8ac..4ce9a12f7 100644
--- a/drivers/accessibility/speakup/utils.h
+++ b/drivers/accessibility/speakup/utils.h
@@ -54,7 +54,7 @@ static inline int oops(const char *msg, const char *info)
static inline struct st_key *hash_name(char *name)
{
- u_char *pn = (u_char *)name;
+ unsigned char *pn = (unsigned char *)name;
int hash = 0;
while (*pn) {
--
2.37.3
next reply other threads:[~2022-10-11 0:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-11 0:17 Yureka [this message]
2022-10-11 0:24 ` Samuel Thibault
[not found] ` <Y0UKhAzH+RSGyhKi@kroah.com>
2022-10-15 12:34 ` Yureka
2022-11-09 14:20 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b7e4894-deec-39ba-bb7c-3c6d6427fa1d@yuka.dev \
--to=yuka@yuka.dev \
--cc=chris@the-brannons.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=samuel.thibault@ens-lyon.org \
--cc=speakup@linux-speakup.org \
--cc=w.d.hubbs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®