From: Rinat Gadelshin <rgadelsh@gmail.com>
To: Chris Riches <chris.riches@nutanix.com>,
audit@vger.kernel.org, Paul Moore <paul@paul-moore.com>,
Eric Paris <eparis@redhat.com>
Cc: jonathan.davies@nutanix.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] audit: Send netlink ACK before setting connection in auditd_set
Date: Wed, 18 Oct 2023 16:19:06 +0300 [thread overview]
Message-ID: <9b82b0df-c4a9-40bc-8980-ac2494073fcd@gmail.com> (raw)
In-Reply-To: <cdcd0b8a-1098-470f-86ba-dcc858ac4cd3@nutanix.com>
On 18.10.2023 15:49, Chris Riches wrote:
>
> On 18/10/2023 13:11, Rinat Gadelshin wrote:
>>> -static void audit_receive(struct sk_buff *skb)
>>> +static void audit_receive(struct sk_buff *skb)
>>> {
>>> struct nlmsghdr *nlh;
>>> + bool ack;
>> Maybe we should initialize 'ack' as 'true' here?
> That doesn't feel particularly useful to me. In fact, I think it's
> actually clearer
> uninitialised as a never-used initialisation could look like an
> actually-used default.
> We're guaranteed to initialise before use.
>
> - Chris
Sorry, you are right.
I've missed the following line:
ack = nlh->nlmsg_flags & NLM_F_ACK;
- Rinat
next prev parent reply other threads:[~2023-10-18 13:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-22 15:27 [RFC PATCH] " Chris Riches
2023-09-26 21:27 ` Paul Moore
2023-10-11 17:55 ` Paul Moore
2023-10-16 17:11 ` Chris Riches
2023-10-16 20:16 ` Paul Moore
2023-10-17 13:49 ` Chris Riches
2023-10-17 21:20 ` Paul Moore
2023-10-18 9:23 ` [PATCH v2] " Chris Riches
2023-10-18 12:11 ` Rinat Gadelshin
2023-10-18 12:49 ` Chris Riches
2023-10-18 13:19 ` Rinat Gadelshin [this message]
2023-11-01 9:59 ` Chris Riches
2023-11-02 0:24 ` Paul Moore
2023-11-07 23:31 ` Paul Moore
2023-11-13 3:36 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b82b0df-c4a9-40bc-8980-ac2494073fcd@gmail.com \
--to=rgadelsh@gmail.com \
--cc=audit@vger.kernel.org \
--cc=chris.riches@nutanix.com \
--cc=eparis@redhat.com \
--cc=jonathan.davies@nutanix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paul@paul-moore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®