From: Hannes Reinecke <hare@suse.de>
To: alistair23@gmail.com, kbusch@kernel.org, axboe@kernel.dk,
hch@lst.de, sagi@grimberg.me, kch@nvidia.com,
linux-nvme@lists.infradead.org
Cc: linux-kernel@vger.kernel.org,
Alistair Francis <alistair.francis@wdc.com>
Subject: Re: [PATCH] nvmet-auth: update sc_c in target host hash calculation
Date: Wed, 29 Oct 2025 09:10:17 +0100 [thread overview]
Message-ID: <9b8d8baf-022a-49a9-b8b9-db699125e064@suse.de> (raw)
In-Reply-To: <20251029045327.2035337-1-alistair.francis@wdc.com>
On 10/29/25 05:53, alistair23@gmail.com wrote:
> From: Alistair Francis <alistair.francis@wdc.com>
>
> Commit 7e091add9c43 "nvme-auth: update sc_c in host response" added
> the sc_c variable to the dhchap queue context structure which is
> appropriately set during negotiate and then used in the host response.
>
> This breaks secure concat connections with a Linux target as the target
> code wasn't updated at the same time. This patch fixes this by adding a
> new sc_c variable to the host hash calculations.
>
> Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
> ---
> drivers/nvme/host/auth.c | 1 +
> drivers/nvme/target/auth.c | 3 ++-
> drivers/nvme/target/fabrics-cmd-auth.c | 1 +
> drivers/nvme/target/nvmet.h | 1 +
> 4 files changed, 5 insertions(+), 1 deletion(-)
>
I've already send a similar patch for this, which actually should
already have been merged.
Can you check if that works for you?
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich
next prev parent reply other threads:[~2025-10-29 8:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-29 4:53 alistair23
2025-10-29 8:10 ` Hannes Reinecke [this message]
2025-10-29 11:20 ` Alistair Francis
2025-10-29 11:33 ` Hannes Reinecke
2025-11-03 2:28 ` Alistair Francis
2025-11-03 13:57 ` Hannes Reinecke
2025-10-30 6:48 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b8d8baf-022a-49a9-b8b9-db699125e064@suse.de \
--to=hare@suse.de \
--cc=alistair.francis@wdc.com \
--cc=alistair23@gmail.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®