From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Abel Vesa <abel.vesa@oss.qualcomm.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2] dt-bindings: spmi: qcom,x1e80100-spmi-pmic-arb: Document Eliza compatible
Date: Wed, 11 Mar 2026 14:43:27 +0100 [thread overview]
Message-ID: <9b8ea7a8-80bd-4aba-89c3-6dbe9d43c41d@oss.qualcomm.com> (raw)
In-Reply-To: <20260311-eliza-bindings-spmi-v2-1-12783c6759d9@oss.qualcomm.com>
On 3/11/26 2:29 PM, Abel Vesa wrote:
> The SPMI multi-master Arbiter found on Eliza is version 7.2.0, yet
> driver-wise, still compatible with the one featured on Hamoa (X1E80100),
> which is 7.0.1.
>
> So document the Eliza compatible and allow Hamoa one as fallback.
>
> Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
> ---
> Changes in v2:
> - Instead of reworking the whole oneOf for compatibles,
> add Eliza similar to sar2130p.
> - Link to v1: https://patch.msgid.link/20260311-eliza-bindings-spmi-v1-1-1a20eec1179e@oss.qualcomm.com
> ---
> .../devicetree/bindings/spmi/qcom,x1e80100-spmi-pmic-arb.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/spmi/qcom,x1e80100-spmi-pmic-arb.yaml b/Documentation/devicetree/bindings/spmi/qcom,x1e80100-spmi-pmic-arb.yaml
> index 08369fdd2161..4152469b3880 100644
> --- a/Documentation/devicetree/bindings/spmi/qcom,x1e80100-spmi-pmic-arb.yaml
> +++ b/Documentation/devicetree/bindings/spmi/qcom,x1e80100-spmi-pmic-arb.yaml
> @@ -23,6 +23,9 @@ allOf:
> properties:
> compatible:
> oneOf:
> + - items:
> + - const: qcom,eliza-spmi-pmic-arb
> + - const: qcom,x1e80100-spmi-pmic-arb
> - items:
> - const: qcom,sar2130p-spmi-pmic-arb
> - const: qcom,x1e80100-spmi-pmic-arb
I think Krzysztof's comment was meant to suggest you shouldn't add an
intermittent items: entry for a single const (lone-x1e compatible), instead
passing:
oneOf:
- items:
- enum:
- foo
- bar
- const: x1e
...
- const: x1e
Konrad
next prev parent reply other threads:[~2026-03-11 13:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-11 13:29 Abel Vesa
2026-03-11 13:43 ` Konrad Dybcio [this message]
2026-03-11 13:57 ` Abel Vesa
2026-03-11 14:01 ` Konrad Dybcio
2026-03-13 8:34 ` Krzysztof Kozlowski
2026-03-13 9:02 ` Abel Vesa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b8ea7a8-80bd-4aba-89c3-6dbe9d43c41d@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=abel.vesa@oss.qualcomm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®