From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 04864435526 for ; Mon, 10 Aug 2026 18:13:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786385598; cv=none; b=sLfzgigslq47QlTCJISMSfXCy7XcJazkBL9HwP+hSA6LuOg+dFxkj6+du+yieBUXIgkgb1XsP+J/6BP2Fam+j0blpxsC71Bf8IHG3KEh6n4/UZJAdPcYs2w3z7kcVtZFNwNtzhAA3ptn87jNb50TwXHDgkVBTAAEYrkQRmZedYQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786385598; c=relaxed/simple; bh=3vlw48vVVYMDsIfSnw51xnY2eWgPtcDwS/T3cZE/dy8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iDQwnrN43vyklDwHI+Lj+zn/rmDrdZRzA/2/acusBpVAHqGpesVhqcP5fDiGd16vUoZXVRe3ZmQF/qeBZFvbZarDA9eoWv0xnvd910ktFXJ7DhS2hLOUbP4xOmMLPPjObpfCEZKk/EoFk7+l8KocVg3j+doNAHyph5aw+R1rvxQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bCHhbj8b; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bCHhbj8b" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-38dfe7eb825so1849552a91.0 for ; Mon, 10 Aug 2026 11:13:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786385596; x=1786990396; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=WujUIY65y0KmxCJIWe2PeDrhDspA8W9feQaFaQQ0mOg=; b=bCHhbj8bZhIBloQtuZeShK4J2b+KOCMH65h1FUx3ZlvZ7A5wpob5wAuNEJjtcBTZ6O gv6fj6yVZz1EhdKTJ2MkOsgzEFHlQBLKN2FjfR9diepuch5iYjnlD/iKalMh6c58Ka5W g+kOJGB566k0rpT+2zcaBCjCauULRi6X/hxJUvDYWI2VCQGFsQ6pimddFGHGNL0EAIf3 Zr+TpeJcO76uKzeGnZA5nCRiZY2S7UIBKLc/N2EUIUbDnu6L6L2PyWJWbddVksgnkFXi +85a4SESG4dVC+XcJZdOgGYEWllPhqoxYElTBx90AI4yg28m+66BMPOWWPCMk79WKKHl Q2RQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786385596; x=1786990396; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=WujUIY65y0KmxCJIWe2PeDrhDspA8W9feQaFaQQ0mOg=; b=ljFiy1ydVwkdJPm0Rsk632B/STlM0KtqhdjHOoARja2ebRV6rz/H0qNlscSWonqCCm c091GlsIXIihKz81V3FSv6o93tRF1XtUQXywk3QWE/46X3thitaKPsot5bEwrDWEs0bA NsqSaFqX76B4oZ6pEUa+gj+WpMUtizS5TWUPkjEbaX70C5vmAAiXvRbUnXMgjcpUG27b qoXjreaSeoy0FRPoHSQdNHTPxLWqNrCXWJaudkZeL+E9FEL6awYPsM/fq7B8ImXeIcbv GbM4MvV6MrY6x/bbYtQ4SzbyM3wm3wksK62UIboPW3ZoNp1eGiu21qHjzM71wHBRja5K Aurg== X-Forwarded-Encrypted: i=1; AHgh+RpT55CBOtSHOJDZLsga2YV35Da02uF3s0nXs6M0xT9keHcGum5jTq6vTtK8h9dhbjdCvVwUAbM2tSD86Ik=@vger.kernel.org X-Gm-Message-State: AOJu0YyoLySJKmLlvuUTUnTnR6GrpU9aQOXWk5rKlVqebRPHkXOHD/10 wad4B9Xnt4965w5+JqhnPbrkOvj4Ba28QHnE6IA9Vl7HQt/aR0zI7gYj X-Gm-Gg: AR+sD110v2XsavfQGWvg9xSVD+Ns4UcLLln5pBZi9dU/1naoVDbdfxe9qQMVVnemi9B 1v4t6s153k+FlOmlWa0LpbCFhia25gf2mBQmVK9gK7y3GpXdgYVxi7/U3p6V4XSquK9kOrCeC4C tjdjz32GD5G2aGmm1P1zaLSD7nvEpgXAC0uQbcwo5V5/f7ffMQWZ+YUpWDljBg3KSYPokEf/yya i9+KB9eUT1o9C+bj5JrYTCNxwd0eyHkwQWmII26G9CEsQLP/CUnkdqmm5blt1+5WJWxisc2/5cX DiMuYCzD8KvhGffHRoOyKRxjeu7LZaOJrW/PBWTSzaY6FZdIprReNfrkPKLPo5oF2kf00Y2UmQh geAHzYJ+Uzv+UD2SvbBBOpNK2cQIeNQMHejH0l+7hJcI/FjyBBbDm6CL2N+crMZ8GiXTjBuczZ6 QojedM4KWEh3fpgmO/TT+r9fOPZNrh0rtQhc1pRmF8hkJkpHDMfK1VEQ6uZY4kEkk= X-Received: by 2002:a17:90b:2242:b0:37f:c28a:de61 with SMTP id 98e67ed59e1d1-3909d8e4c62mr27816069a91.17.1786385596135; Mon, 10 Aug 2026 11:13:16 -0700 (PDT) Received: from cryptic.lan ([2001:569:7fa9:fa00:b1a9:6513:83c6:1d23]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-392d53b873asm472795a91.17.2026.08.10.11.13.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2026 11:13:15 -0700 (PDT) From: Allen Pais To: Vinod Koul , Frank Li Cc: Allen Pais , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, Arnd Bergmann , Kees Cook , Logan Gunthorpe Subject: [PATCH v3 27/34] dmaengine: plx_dma: use channel BH helpers Date: Mon, 10 Aug 2026 11:09:28 -0700 Message-ID: <9b931c21648cdee0e5db08642861b532b6b040d5.1786384169.git.allen.lkml@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace the device tasklet with the per-channel BH helper so completion callbacks run via dmaengine_*_bh. Signed-off-by: Allen Pais Reviewed-by: Logan Gunthorpe --- drivers/dma/plx_dma.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/dma/plx_dma.c b/drivers/dma/plx_dma.c index 84941a918b01..a9a798c54ef1 100644 --- a/drivers/dma/plx_dma.c +++ b/drivers/dma/plx_dma.c @@ -105,7 +105,6 @@ struct plx_dma_dev { struct dma_chan dma_chan; struct pci_dev __rcu *pdev; void __iomem *bar; - struct tasklet_struct desc_task; spinlock_t ring_lock; bool ring_active; @@ -241,9 +240,10 @@ static void plx_dma_stop(struct plx_dma_dev *plxdev) rcu_read_unlock(); } -static void plx_dma_desc_task(struct tasklet_struct *t) +static void plx_dma_desc_task(struct dma_chan *chan) { - struct plx_dma_dev *plxdev = from_tasklet(plxdev, t, desc_task); + struct plx_dma_dev *plxdev = container_of(chan, struct plx_dma_dev, + dma_chan); plx_dma_process_desc(plxdev); } @@ -366,7 +366,7 @@ static irqreturn_t plx_dma_isr(int irq, void *devid) return IRQ_NONE; if (status & PLX_REG_INTR_STATUS_DESC_DONE && plxdev->ring_active) - tasklet_schedule(&plxdev->desc_task); + dmaengine_schedule_bh(&plxdev->dma_chan); writew(status, plxdev->bar + PLX_REG_INTR_STATUS); @@ -471,7 +471,7 @@ static void plx_dma_free_chan_resources(struct dma_chan *chan) if (irq > 0) synchronize_irq(irq); - tasklet_kill(&plxdev->desc_task); + dmaengine_kill_bh(&plxdev->dma_chan); plx_dma_abort_desc(plxdev); @@ -510,7 +510,7 @@ static int plx_dma_create(struct pci_dev *pdev) goto free_plx; spin_lock_init(&plxdev->ring_lock); - tasklet_setup(&plxdev->desc_task, plx_dma_desc_task); + dmaengine_init_bh(&plxdev->dma_chan, plx_dma_desc_task); RCU_INIT_POINTER(plxdev->pdev, pdev); plxdev->bar = pcim_iomap_table(pdev)[0]; -- 2.43.0