From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD8C441754 for ; Fri, 12 Dec 2025 04:16:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765512993; cv=none; b=RAyq8UaSSlmgSqq3407LHoTOx8lvkdq0zTymaaWaScEFCqYQWF8PBCDeah1oaEFky9XzklHgCopputg/xzqjzZOBU6Ljy8oCZiBnx7ldS0ACTT/D4gBGFwSpXdHExfVJEo//4Er1eddA3LkGrcgIuZ0OY3kkji0LkEW4IVdzE1w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765512993; c=relaxed/simple; bh=xWIFQqIxMumrVX7ZZvMeE96zUwRwQLLXppHqbSwC+Js=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RWzSF1lCzK/NylSx5pG0OC+VJN/f43o2vJDJqUTImVxXQmeSawFtQ/aqyKAheOO1O/RPtPpPp4yp9c3kdcEhgebTacKOuG40+BS9indFcwobI/lJ4IFR38uzQYh7nCyCAlMAz5ZfGXBT62XyrzvbQj5s5eBlq40rp6bUCNJoD/s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=U65uVlwE; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Qj34J4XE; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="U65uVlwE"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Qj34J4XE" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BBNfHLV2606498 for ; Fri, 12 Dec 2025 04:16:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 8H7l4dMATXmn+Ign2HivCF9nu4t/RGn8au+x0IyH66k=; b=U65uVlwEmwWoDuv0 X7Cs2GoEkpke+VoRijDqgpn8xfCI6UISQCCzlp8AaGkyntEyP8BblMUGst1jwGcS K36wMlTvrYxXKhBu/d1TKIcCEfbxErKknnJFenRlHgETDHj9z2dus0hccs+lAyid XeNuvFQnsdZzRAf2/CJDGaWVp81Fd1VrenB6/UqRAH3ys0zLCpx9eXipj8QM2PzA 5G1P9esSY65+7/n9e3zzhsdOB3pC2wLIpg4mgnIqRxhvNsDqO+1hPSytlOAFqLYQ A2UThqXA3PKFTYk7ClK8l0v0pWgN50EKBkZh0EKJrrQdRy+4XikfZU9M1gqn7h6F A2SvHA== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b07u40hak-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 12 Dec 2025 04:16:30 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-340c07119bfso1510958a91.2 for ; Thu, 11 Dec 2025 20:16:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1765512989; x=1766117789; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8H7l4dMATXmn+Ign2HivCF9nu4t/RGn8au+x0IyH66k=; b=Qj34J4XE4F2aOQPMmC2T5uQ+ckXOhhObP1GbZChhoGHP5nD1NHhOK3pLJNQSRriVCH hnQ8p5lOOQRjriVAWP4DqYFJW9Et/fufQtDPfWIpmyI3f2CA2fqv4a2rg+ggzy/ylcyx pJhdjaTgXKQ7KeSmJGSR9yO7WdmUV6o/RIgYURK5WsVphFM5HEL6Rz0FyViYZ9ul+Ofx plfWomh47Cf8856/YC1k19L6NL7QlX0EkULpLtv5jXU5+7K1rEltRvekdA7fX2J4e88y JxXHAsHIWHGs3lHV9n3Xhny4lrZPCH69dtaEQON1t4QsLCSLuMAx7wbBkePquf2l6LIp LYow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765512989; x=1766117789; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8H7l4dMATXmn+Ign2HivCF9nu4t/RGn8au+x0IyH66k=; b=AdIa8Zm9KbFqHo/bF9vOYEx8HcZSXiAWP/ap4sxoTT07cxEWt7sVaxh198Hk/v+YoL 6RdeaUqv01a7VnTfOQrtoNNPNGP8B7NLMDa0E1Eq31E5bYuUJOy3ep3tRSlDsZclShUq bEV6EtMX4Opzc/2pFXVMPnklX2524yvincrL5HD1BDiikH59zSwfSRu3h12YkEm8u04k 3AuXZgBRvI8JpgJgUUsCJKyWTXYiFlJHu9Ksfi1zP7zwPtV6kscpotystC2zzH0myH9m X9QC06wLB56pX1VyBYMfYmRKvkUcaph+isfdGxU68fUzY+xI89MKmLfk4A0EVuYLRdhF 7RUA== X-Forwarded-Encrypted: i=1; AJvYcCVeSrRQZYUcAT+WaQEYMyXaJoxIIlPryGfjabJ77F8jNOH/5mzSaZQDAuyRG3RyDQqYICNd72XuK970kCk=@vger.kernel.org X-Gm-Message-State: AOJu0Yy2hSbm1fJLyJjMPJFFgOXtJ4x3QTE5I99LhaDiFX8JeKfjuorJ G4ZXIvWmb5/rPbfuuRoprYU/alfjBkiDKkCBjVMaUG+SSdNFcmHAsq/MVvuk9XC62RCQ/tOgtOk DYMqkzANzqU3wOIduIvUoEYWsPgqr9v2srGbM4CbUqXbCvqA064ItKv4rVqkswnZ+OlLEb57FhO w= X-Gm-Gg: AY/fxX5ex1+WsuIbTKnoRwHinmI2eEJ7dZCTYoqqukWmACb2qVdhv7SyuWgEzRUKPhZ yYCWujqK7CSaUKCbcuCaznRr0k4EghsvyuI35Ifs0mTwJvHXsweZWVHXZ6/ORlgQAKnETfK1kQL 0HULIfZC2gFp44cxkL97WYsIWz7jzCniLj/JnpufcRwsrYDtc7Cnzl0V+U+VmCja+imBGynHJWC JVEB77r08892eJgwleVLxo492b9B0y2BxwJxUHfSg2KQzREvsyD77I6a3aH5FEhtf0Z3zTBWVw2 7/s095MK0mJwMQmJDED8f7Zgdp/yEDYd9jbaU5G1xT62wVldByLfGHMUvcFkCN5hYUmt2UH4p/S E9lPp0YThCaFARnBbOG7egbQYtrYbf3VcKED3BqxnWa9g X-Received: by 2002:a17:90b:3912:b0:335:2eef:4ca8 with SMTP id 98e67ed59e1d1-34abd77fbbdmr863885a91.33.1765512988834; Thu, 11 Dec 2025 20:16:28 -0800 (PST) X-Google-Smtp-Source: AGHT+IF6+ZpVLE7EmjUp5GR7pVB1C+4LCPd1tpZ73cx+V9RyBoa0VhQ4D+R4YvqelK8mimG3RNxnpw== X-Received: by 2002:a17:90b:3912:b0:335:2eef:4ca8 with SMTP id 98e67ed59e1d1-34abd77fbbdmr863863a91.33.1765512988342; Thu, 11 Dec 2025 20:16:28 -0800 (PST) Received: from [192.168.0.171] ([49.205.251.140]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-34abe218312sm484957a91.6.2025.12.11.20.16.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Dec 2025 20:16:27 -0800 (PST) Message-ID: <9b952190-4862-42f6-8079-ab48e6ada786@oss.qualcomm.com> Date: Fri, 12 Dec 2025 09:46:23 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] media: venus: vdec: fix error state assignment for zero bytesused To: Bryan O'Donoghue , Renjiang Han , Dikshita Agarwal , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251211-fix-error-state-v3-1-b429262d151c@oss.qualcomm.com> <784ded76-227c-4968-a9f2-eb97822404bf@kernel.org> Content-Language: en-US From: Vikash Garodia In-Reply-To: <784ded76-227c-4968-a9f2-eb97822404bf@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: JoyC0s-P8Lut715vICYCj0kFcM61am_V X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjEyMDAzMiBTYWx0ZWRfXwlsR0g/MVVOF qCqbA8QjNE734nQphxk9r48UNjTqcKyyb/PUPNtkF6kZqGJMF9NFTOCpUufOd30d81H4VfrMSb1 uHw9lGzGWLzNhIOw+Xz1ELKVaG2fizKP1/uaB3RtGRA3u8L0i9J2ExDWfWdLeHLmlGj27h7lr3h aplFTfBhlOZxFOyw6IrreUvgn6tSWpR5mLGII+3Min/e43J010Kd3izLvf/31cwZP/L8m4omahi W8Il2+mWKWLHrhBnVv8+JMVpWtzYdT5gJRv/StwfMGbQxzmS4cok0lhqlNrhVP6KjZjmiUlxdi6 lS56N6+9xhZNGEQRQHfyg0x2WXCS3/s3eZ1j9U1Kw72TWlA4sE4Z7I77mVzYrXp6NDm+YrzjDBy sos1TXJPvBKct8oHRn6h/7uUcJ0X3g== X-Proofpoint-ORIG-GUID: JoyC0s-P8Lut715vICYCj0kFcM61am_V X-Authority-Analysis: v=2.4 cv=f/lFxeyM c=1 sm=1 tr=0 ts=693b971e cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=oHgmLS9T6KHqMfKxrEeemw==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=2f0GM3lUfm5oml4ENckA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-12_01,2025-12-11_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 priorityscore=1501 suspectscore=0 lowpriorityscore=0 impostorscore=0 malwarescore=0 bulkscore=0 adultscore=0 spamscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512120032 Hi Bryan, On 12/12/2025 7:45 AM, Bryan O'Donoghue wrote: > On 11/12/2025 09:50, Renjiang Han wrote: >> When hfi_session_flush is issued, all queued buffers are returned to >> the V4L2 driver. Some of these buffers are not processed and have >> bytesused = 0. Currently, the driver marks such buffers as error even >> during drain operations, which can incorrectly flag EOS buffers. >> >> Only capture buffers with zero payload (and not EOS) should be marked >> with VB2_BUF_STATE_ERROR. The check is performed inside the non-EOS >> branch to ensure correct handling. >> >> Fixes: 51df3c81ba10b ("media: venus: vdec: Mark flushed buffers with >> error state") >> Signed-off-by: Renjiang Han >> --- >> The error state assignment in the Venus vdec driver for Qualcomm >> platforms is updated to ensure that VB2_BUF_STATE_ERROR is applied >> only to non-EOS capture buffers with zero bytesused. Ensures false >> error reports do not occur during drain operations. >> --- >> Changes in v3: >> - 1, Update commit message. >> - 2, Move empty line between tags. >> - 3, Update cover letter message. >> - Link to v2: https://lore.kernel.org/r/20251208-fix-error-state- >> v2-1-255b62ee2eb6@oss.qualcomm.com >> >> Changes in v2: >> - 1. Update commit message. >> - 2. Add a Fixes tag. >> - Link to v1: https://lore.kernel.org/r/20251126-fix-error-state- >> v1-1-34f943a8b165@oss.qualcomm.com >> --- >>   drivers/media/platform/qcom/venus/vdec.c | 6 +++--- >>   1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/media/platform/qcom/venus/vdec.c b/drivers/media/ >> platform/qcom/venus/vdec.c >> index >> 4a6641fdffcf79705893be58c7ec5cf485e2fab9..d0bd2d86a31f9a18cb68b08ba66affdf8fc5092d 100644 >> --- a/drivers/media/platform/qcom/venus/vdec.c >> +++ b/drivers/media/platform/qcom/venus/vdec.c >> @@ -1440,10 +1440,10 @@ static void vdec_buf_done(struct venus_inst >> *inst, unsigned int buf_type, >>                   inst->drain_active = false; >>                   inst->codec_state = VENUS_DEC_STATE_STOPPED; >>               } >> +        } else { >> +            if (!bytesused) >> +                state = VB2_BUF_STATE_ERROR; >>           } >> - >> -        if (!bytesused) >> -            state = VB2_BUF_STATE_ERROR; >>       } else { >>           vbuf->sequence = inst->sequence_out++; >>       } >> >> --- >> base-commit: 663d0d1af3faefe673cabf4b6b077149a87ad71f >> change-id: 20251126-fix-error-state-24183a8538cd >> >> Best regards, >> -- >> Renjiang Han >> > > Dikshita, Vikash. > > This change makes sense to me. If you are NAKing please do so now. > This is good to go. Regards, Vikash