From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 208742EC09B for ; Fri, 20 Feb 2026 17:05:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771607107; cv=none; b=SKQRr8cZkpxGE64UGYgxEgkEQWMY/Av1Z99anF444SREfnjLgQ0k+Q837KBCDpqai3GvoZQR/9Wp3trXgHiQ9Xzbg7cdIouRz4etsuYM2YFc8da6E4CHceqbYn5hb+hcofGKG0anlz5xKZ8oriQ4fwWcXZM9pjo6OBkZo30u5PY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771607107; c=relaxed/simple; bh=MTApqRTnVBk2bB6Gv0prHnu3TpW6pirTowt6gmjeBvM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lkzMp5Ns4KwJOy8pJxRVR86qVEhIoj6dFrM9Eijpn6wM2YO6PwUQtIfOmPxjZX6QW+pbYx2ySQ4lyqc9u29+jHCu7/9Cm8ZAoN2LJyI4bkDBqKN/RePBsCjkHt/hBwgNHreTv4sSttl7kb0CmlsNhajYW5fbdHN/XC7OEafoCaw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=K1JD7Y1L; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="K1JD7Y1L" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-43945763558so1401435f8f.3 for ; Fri, 20 Feb 2026 09:05:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771607104; x=1772211904; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=o+HBjN23l1KfsJluyfGxMQlJXd1Qi9Br3IvjbInHA4Q=; b=K1JD7Y1Liz9mCLu6tNxtji2JlvVJnSS1lOYp4ImfmjJZ+wbG+GfJ2uTa4LHSs/5JGi R6mygQuXBlVvREQX36XfXxOb8HUIbzXwWHGuSEcIK3gMjOEYepe18WxgzRjlwG/9Qkiv PYv+Q7rVUpjk5iVkkCo0qYRuIcqwdp0hB00OC1+NfKr/05Dxsiy81RMUPtXDv+Qju8+P mDvoYs8XMndSIpnMZZIW1dJkhl52oDEzYYqwfi8k8fsEWRRmMdE+7H8o8RqKreN5tmsA BXlER423O3BxE7kpr55eyxg5OMsQ+M1fO3SsqeByiHJoyhStPWeBVAF6mPcPLBwkIyMS BW1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771607104; x=1772211904; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=o+HBjN23l1KfsJluyfGxMQlJXd1Qi9Br3IvjbInHA4Q=; b=C11i/BGpezNYx0YZWVhtwdzLL7Oyw0E5Gtzhzn6k5DugE0djvZ/giVmFVf6Sf363fA lMT01VPvkYN7wc8f8GZL0NBK7yc/t0bPObRR+/L/QfEhuFyL8PWRslvomlYrFRKimG9O q9J2WvmMqBvUNK4akKJwNkoNCuCEQdndQ+fO4FLMJHCxzsWrcOQZbE62sFm57+o0LHbG qw95i8+3DXQ/yuS440XtrhM/sUOAmiAfxqa6hlzGv7Fs8Y0VenaI+qk9VfTQQEj/HTJH dT1YveeZDC64mSl7/taAjzgtmXBZ9YyN7FNQ49gwZfE9JXc8/ZF211dh+4KqpsQsufUl +f7g== X-Forwarded-Encrypted: i=1; AJvYcCVuuTuvwihA62R80Eod341wLqi1A5JEGDRg5eox5mUH+DTAxw1axC4m/7wilScUWx999KTIlzoxW6JNpHo=@vger.kernel.org X-Gm-Message-State: AOJu0YzqP4HoJga3/EtCzXCCDJ0s4HXfngme1BNuw+OJVlvYd9Tapam0 gM10x9eN5gRHNHASid9lQC2ZAjIBMqsIf6vpRC2Drxkw9KAzDEKElLfx X-Gm-Gg: AZuq6aKITMYw9PVlsdo0raUOA6TnZcOqYD5bUd5d5qBiipJMrjGiucvnahY+r9GY4rc wobH9Yh72hQGIQap5LXbsy1Fr9srp2Kj8kWM8MzwUC+TAULtwzQC1mj2QdbW8ZpCN158SAb8ZfM 6vyfP3lH8xlrVrWAFpKuj9v/ThDzxyKXGxJuThY2oTiadZPmegjzhkw+oraCqVuGKlgQSlUeCTn 2S+UOyCdRwMhBvv53WseNlCQS/o9HZXl6mKXG6q5Ncy16E+ZIlArMgKZ71j41P5aLpwDnJIFCrK /HENDGFBO7M7kai2DVR6pgcqFB3cqhBNqqnma9mfKvwX/18LvcaKiosUPd5txmxLRHZoOCD8Llm A9ijaB60XvXiuUTzvDgf/LoghksN949A8aObw8qLHKgXdGuGAgFuJgNlAp/hQH8+2SBLtFnpLWC 4kNEBE4tOJDOBEjpwGKWs/tVUnRcoT3wtjN7qBhpxZPUmIul56fbmlWWUfWmVMC1C8Mwlz5A== X-Received: by 2002:a05:6000:26cd:b0:436:369f:39f9 with SMTP id ffacd0b85a97d-4396f1a70b5mr1003099f8f.57.1771607104091; Fri, 20 Feb 2026 09:05:04 -0800 (PST) Received: from [10.247.12.125] ([129.234.0.168]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43796ac8075sm54619238f8f.29.2026.02.20.09.05.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Feb 2026 09:05:03 -0800 (PST) Message-ID: <9b952d44-6fc6-4594-9e16-78d529290c9d@gmail.com> Date: Fri, 20 Feb 2026 17:05:03 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v2 1/3] drm/syncobj: Add flag DRM_SYNCOBJ_QUERY_FLAGS_ERROR to query errors To: =?UTF-8?Q?Christian_K=C3=B6nig?= , michel.daenzer@mailbox.org Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org, david.hunter.linux@gmail.com References: <20260220022631.2205037-1-yiconghui@gmail.com> <20260220022631.2205037-2-yiconghui@gmail.com> Content-Language: en-US From: Yicong Hui In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit >> + >> /** >> * dma_fence_chain_find_seqno - find fence chain node by seqno >> * @pfence: pointer to the chain node where to start >> diff --git a/drivers/gpu/drm/drm_syncobj.c b/drivers/gpu/drm/drm_syncobj.c >> index 2d4ab745fdad..322f64b72775 100644 >> --- a/drivers/gpu/drm/drm_syncobj.c >> +++ b/drivers/gpu/drm/drm_syncobj.c >> @@ -1654,14 +1654,17 @@ int drm_syncobj_query_ioctl(struct drm_device *dev, void *data, >> { >> struct drm_syncobj_timeline_array *args = data; >> struct drm_syncobj **syncobjs; >> + unsigned int valid_flags = DRM_SYNCOBJ_QUERY_FLAGS_LAST_SUBMITTED | >> + DRM_SYNCOBJ_QUERY_FLAGS_ERROR; >> uint64_t __user *points = u64_to_user_ptr(args->points); >> + uint64_t __user *handles = u64_to_user_ptr(args->handles); >> uint32_t i; >> int ret; >> >> if (!drm_core_check_feature(dev, DRIVER_SYNCOBJ_TIMELINE)) >> return -EOPNOTSUPP; >> >> - if (args->flags & ~DRM_SYNCOBJ_QUERY_FLAGS_LAST_SUBMITTED) >> + if (args->flags & ~valid_flags) >> return -EINVAL; >> >> if (args->count_handles == 0) >> @@ -1680,6 +1683,22 @@ int drm_syncobj_query_ioctl(struct drm_device *dev, void *data, >> uint64_t point; > > Make a local variable "int error" here. > > ... > >> + int64_t error = 0; > > The error code is an int and only 32bits. Understood, will change that! > >> + >> + if (fence) >> + error = dma_fence_chain_find_error(fence); >> + >> + ret = copy_to_user(&handles[i], &error, sizeof(int64_t)); > > The handles are also only 32bits! Ah, that's my mistake. Was thrown off by the __u64 in the struct definition but it is obvious now that it is a u32. Fixed as well! > >> + ret = ret ? -EFAULT : 0; >> + if (ret) { >> + dma_fence_put(fence); >> + break; >> + } >> + >> + } >> + >> chain = to_dma_fence_chain(fence); >> if (chain) { > > In this code path whenever point is assigned something do a "error = dma_fence_get_status(fence);" and then eventually copy the error to userspace after copying the point. > Hi! Were you thinking something that looks a little bit like this? diff --git a/drivers/gpu/drm/drm_syncobj.c b/drivers/gpu/drm/drm_syncobj.c index 2d4ab745fdad..b74e491f9d8b 100644 --- a/drivers/gpu/drm/drm_syncobj.c +++ b/drivers/gpu/drm/drm_syncobj.c @@ -1654,14 +1654,17 @@ int drm_syncobj_query_ioctl(struct drm_device *dev, void *data, { struct drm_syncobj_timeline_array *args = data; struct drm_syncobj **syncobjs; + unsigned int valid_flags = DRM_SYNCOBJ_QUERY_FLAGS_LAST_SUBMITTED | + DRM_SYNCOBJ_QUERY_FLAGS_ERROR; uint64_t __user *points = u64_to_user_ptr(args->points); + uint32_t __user *handles = u64_to_user_ptr(args->handles); uint32_t i; - int ret; + int ret, error; if (!drm_core_check_feature(dev, DRIVER_SYNCOBJ_TIMELINE)) return -EOPNOTSUPP; - if (args->flags & ~DRM_SYNCOBJ_QUERY_FLAGS_LAST_SUBMITTED) + if (args->flags & ~valid_flags) return -EINVAL; if (args->count_handles == 0) @@ -1681,6 +1684,7 @@ int drm_syncobj_query_ioctl(struct drm_device *dev, void *data, fence = drm_syncobj_fence_get(syncobjs[i]); chain = to_dma_fence_chain(fence); + if (chain) { struct dma_fence *iter, *last_signaled = dma_fence_get(fence); @@ -1688,6 +1692,8 @@ int drm_syncobj_query_ioctl(struct drm_device *dev, void *data, if (args->flags & DRM_SYNCOBJ_QUERY_FLAGS_LAST_SUBMITTED) { point = fence->seqno; + error = dma_fence_get_status(fence); + } else { dma_fence_chain_for_each(iter, fence) { if (iter->context != fence->context) { @@ -1702,16 +1708,28 @@ int drm_syncobj_query_ioctl(struct drm_device *dev, void *data, point = dma_fence_is_signaled(last_signaled) ? last_signaled->seqno : to_dma_fence_chain(last_signaled)->prev_seqno; + + error = dma_fence_get_status(last_signaled); } dma_fence_put(last_signaled); } else { point = 0; + error = fence ? dma_fence_get_status(fence) : 0; } dma_fence_put(fence); + ret = copy_to_user(&points[i], &point, sizeof(uint64_t)); ret = ret ? -EFAULT : 0; if (ret) break; + + if (args->flags & DRM_SYNCOBJ_QUERY_FLAGS_ERROR) { + ret = copy_to_user(&handles[i], &error, sizeof(*handles)); + + ret = ret ? -EFAULT : 0; + if (ret) + break; + } } drm_syncobj_array_free(syncobjs, args->count_handles);