From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3122DC00140 for ; Mon, 15 Aug 2022 12:31:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241894AbiHOMbE (ORCPT ); Mon, 15 Aug 2022 08:31:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42286 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242525AbiHOMa4 (ORCPT ); Mon, 15 Aug 2022 08:30:56 -0400 Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8651F6544; Mon, 15 Aug 2022 05:30:54 -0700 (PDT) Received: by mail-pf1-x42b.google.com with SMTP id k14so6539119pfh.0; Mon, 15 Aug 2022 05:30:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=8N0tZJ261i5HWc8SMb6PjhSY6p7VWzYFeTIP4nzrRk8=; b=b1VEzYtVLOWAkOAKzwtxHu0/dhDervAoBVp+iDeFrqBqqYvQgea5BC9AleuQ7U6n83 pFbAzPEp4GiLFrrCVvV4qFxOhbUlQ4WMDyCuzCqOOwxwljV/c9auB3Tkj8eoW8aOTyys vIE6Th4LpTQMdHdli/19h0T4vFhtYAoSmEskq/n/QZh7rhaRwxKe0nRbciC21MvB8S/2 HWlWBwS1b3GYCeQ6fw1ptUyJcXq1BYZVi2plVVIZbN95g/4usQEerhG3FCsEr8EgAbTV eWYKn2umZVbwM3L+EvzsLxrUXsrwfyznDHa75rdFrMXWVHrtc3uD5VaYEZFoU60hl99w LpeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=8N0tZJ261i5HWc8SMb6PjhSY6p7VWzYFeTIP4nzrRk8=; b=gFhfDY7M70X55w3udF3eiKx1ta5n9QFjGxvn4ACYNqRdHX/76UVa0V6GdDMjJ/kGmD 2w8alHkQGNtG/lC5Etm8nMLJxTYqVJA+7h/089R8MVBLWya+hMULQVssHLsiwtqQFNZp h5i1ObfwMJJV23eikDQzVSdQ4miaRon9J3nknrza9rRNUdACkiq3zu1nX4k4eQ7+IeCt b816f/v4PIvcph5YYHaBq6D9etp0ay4y2eaSMmMfjWt5ktzEWD8C3twyhT/S3zzCzF8X hQZ7zGfgZp9kzgjorgTPwd4RkHqisEKM9MCL29gQTSmlzdti62/DPAjXI5LPavzC+iYo sAEw== X-Gm-Message-State: ACgBeo3pMq2EauqeGIn2wy5GHR4+4QUrAuQFtkkmA2uY7vKXfAGRKuA0 KOrDPBRUU5OhMqF6sRv5sGA= X-Google-Smtp-Source: AA6agR6n+V5MTGdGpk2hwvi18leQKPRw9rMleuhjBbyrOaibWzPzTsNiVU8zXcFHe6aFt9r5FDsqRQ== X-Received: by 2002:a05:6a00:c96:b0:52e:979c:dd63 with SMTP id a22-20020a056a000c9600b0052e979cdd63mr16400289pfv.50.1660566653967; Mon, 15 Aug 2022 05:30:53 -0700 (PDT) Received: from [192.168.0.110] ([103.159.189.152]) by smtp.gmail.com with ESMTPSA id z25-20020a656659000000b00419b66846fcsm5726173pgv.91.2022.08.15.05.30.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Aug 2022 05:30:53 -0700 (PDT) Message-ID: <9b993aa6-f432-89f6-9195-05b584398df2@gmail.com> Date: Mon, 15 Aug 2022 18:30:44 +0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [RFC PATCH] Soundwire: Initialize multi_link with fwnode props Content-Language: en-US To: Greg KH Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, Heikki Krogerus , "Rafael J . Wysocki" , Pierre-Louis Bossart , Daniel Scally , Vinod Koul , Sakari Ailus , Sanyog Kale , Andy Shevchenko , Bard Liao , Len Brown References: <20220814080416.7531-1-khalid.masum.92@gmail.com> From: Khalid Masum In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/15/22 12:37, Greg KH wrote: > On Mon, Aug 15, 2022 at 10:08:07AM +0600, Khalid Masum wrote: >> On 8/14/22 15:45, Greg KH wrote: >>> On Sun, Aug 14, 2022 at 02:04:15PM +0600, Khalid Masum wrote: >>>> According to the TODO, In sw_bus_master_add, bus->multi_link is to be >>>> populated with properties from FW node props. Make this happen by >>>> creating a new fwnode_handle flag FWNODE_FLAG_MULTI_LINKED and use >>>> the flag to store the multi_link value from intel_link_startup. Use >>>> this flag to initialize bus->multi_link. >>>> >>>> Signed-off-by: Khalid Masum >>>> --- >>>> I do not think adding a new flag for fwnode_handle is a good idea. >>>> So, what would be the best way to initialize bus->multilink with >>>> fwnode props? >>>> >>>> -- Khalid Masum >>>> >>>> drivers/soundwire/bus.c | 4 ++-- >>>> drivers/soundwire/intel.c | 1 + >>>> include/linux/fwnode.h | 1 + >>>> 3 files changed, 4 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c >>>> index a2bfb0434a67..80df1672c60b 100644 >>>> --- a/drivers/soundwire/bus.c >>>> +++ b/drivers/soundwire/bus.c >>>> @@ -74,9 +74,9 @@ int sdw_bus_master_add(struct sdw_bus *bus, struct device *parent, >>>> /* >>>> * Initialize multi_link flag >>>> - * TODO: populate this flag by reading property from FW node >>>> */ >>>> - bus->multi_link = false; >>>> + bus->multi_link = (fwnode->flags & FWNODE_FLAG_MULTI_LINKED) >>>> + == FWNODE_FLAG_MULTI_LINKED; > > I missed that this was an if statement here, please write this to be > more obvious and readable. > >>>> if (bus->ops->read_prop) { >>>> ret = bus->ops->read_prop(bus); >>>> if (ret < 0) { >>>> diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c >>>> index 505c5ef061e3..034d1c523ddf 100644 >>>> --- a/drivers/soundwire/intel.c >>>> +++ b/drivers/soundwire/intel.c >>>> @@ -1347,6 +1347,7 @@ int intel_link_startup(struct auxiliary_device *auxdev) >>>> */ >>>> bus->multi_link = true; >>>> bus->hw_sync_min_links = 1; >>>> + dev->fwnode->flags |= FWNODE_FLAG_MULTI_LINKED; >>>> } >>>> /* Initialize shim, controller */ >>>> diff --git a/include/linux/fwnode.h b/include/linux/fwnode.h >>>> index 9a81c4410b9f..446a52744953 100644 >>>> --- a/include/linux/fwnode.h >>>> +++ b/include/linux/fwnode.h >>>> @@ -32,6 +32,7 @@ struct device; >>>> #define FWNODE_FLAG_NOT_DEVICE BIT(1) >>>> #define FWNODE_FLAG_INITIALIZED BIT(2) >>>> #define FWNODE_FLAG_NEEDS_CHILD_BOUND_ON_ADD BIT(3) >>>> +#define FWNODE_FLAG_MULTI_LINKED BIT(4) >>> >>> What does this commit actually change? >> >> The new flag will lets us save if the device has multilink in fwnode_handle >> whenever needed. >> Then for soundwire/intel, save the multi_link flag into fwnode during >> startup. >> Later at master_add, as written in todo, initialize the multilink flag with >> fwnode's flag property. > > And what does that allow to happen? What changes with all of this? As suggested by Pierre-Louis Bossart these changes are not necessary and the TODO is to be removed. Earlier my intention was to create a new flag that lets us know whether multi_link is to be read from sdw_bus_master_add just as instructed in TODO. I shall send another patch, that removes the TODO, as suggested by Pierre-Louis Bossart. > > thanks, > > greg k-h thanks, -- Khalid Masum