From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8145DC25B67 for ; Fri, 27 Oct 2023 11:21:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345713AbjJ0LVQ (ORCPT ); Fri, 27 Oct 2023 07:21:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39878 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230101AbjJ0LVO (ORCPT ); Fri, 27 Oct 2023 07:21:14 -0400 Received: from mail-pf1-x42a.google.com (mail-pf1-x42a.google.com [IPv6:2607:f8b0:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E38F9DE for ; Fri, 27 Oct 2023 04:21:10 -0700 (PDT) Received: by mail-pf1-x42a.google.com with SMTP id d2e1a72fcca58-6b36e1fcee9so1852632b3a.3 for ; Fri, 27 Oct 2023 04:21:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tweaklogic.com; s=google; t=1698405670; x=1699010470; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=OpDUNO6+wJLZCjUYYtsZ7P6CGyOdEndsDNhhPRxxHyU=; b=gFo5EbVYclVt2BOhHsAfhX1lwRYLEnz4iJ5cx2jcyKjqZ/gkajsCeWlkCiS35b/Pfh cIFLn/t8uig2fMxYU6SRCEoEp0ulYFoyF4Gp1r4BvrepjzNzwnWNUXlOKKt2m5OaKGe3 voI1twkrqkfpGTCFYU2IZ5qKvhDxw4rFKar6+A577ypKyMD62TGp9+g/rk7WMbkkkHv2 RYgbFOiSww6nMEzyLj90LnQeJKbvwVYcn64nWm+0U/IPWwEhDZj71pNpBW0JgX0ToKDc Hhrcqmi9NwG2tWXXNNuvoTsRj/hGWOtFI74t8m8RfxHg3R48anqLokUE69owhnud5Y0i /5Yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698405670; x=1699010470; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=OpDUNO6+wJLZCjUYYtsZ7P6CGyOdEndsDNhhPRxxHyU=; b=OeAZp33d7QnTzO886KisrB+9Evh/Cwb3VyDs8LI7imea5KBAWZPNtQlgAKntlnUKp7 l0R/Q9RLqj6BlC/Xw3YdUWLieQECR6wa38cNpHC6cqjzdG+iDKkBb7H2q2yjklFyCWxk ZtLSos0MbxkzBnjYjUlW3CR5Njaj8nhQohxoHsJ8+O9pEfnNgAbIRMzZHajlN17iYWXE 45Uy6d3KGpttQhVRAMgo/XDEkWaqykYPqRJOz6EQtysyE12QVHJjyrEZPdyk04TGHnPl S8Agm2jeCyoAdr5wTWLZPhnHELP3C8OdGBqzr3+Bath0sgLPZxmU3hRQtDRY1Som7bhI 3/pg== X-Gm-Message-State: AOJu0YyFZzwTi9QZX9LNGl9+hkxPW1yZ0af9+OdeHn1+gnDNadxl2sem ITc9Zlg14I5QPwMYiHMh4NHIhw== X-Google-Smtp-Source: AGHT+IHr0HKYNWFJCCBhhVhyiRbjtCdvuHG6iPglG2lzT2vGoYkwfMDkR0h8WZF0FS9efvG0I5A3lQ== X-Received: by 2002:a05:6a20:428a:b0:16b:cc6c:d728 with SMTP id o10-20020a056a20428a00b0016bcc6cd728mr3267886pzj.44.1698405670213; Fri, 27 Oct 2023 04:21:10 -0700 (PDT) Received: from ?IPV6:2403:580d:82f4:0:c232:f53e:32d4:5510? (2403-580d-82f4-0-c232-f53e-32d4-5510.ip6.aussiebb.net. [2403:580d:82f4:0:c232:f53e:32d4:5510]) by smtp.gmail.com with ESMTPSA id n3-20020a170902e54300b001b9d335223csm1324994plf.26.2023.10.27.04.21.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Oct 2023 04:21:09 -0700 (PDT) Message-ID: <9b9addeb-230c-48f0-9e50-78d30adeaf9d@tweaklogic.com> Date: Fri, 27 Oct 2023 21:51:02 +1030 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 2/2] iio: light: Add support for APDS9306 Light Sensor Content-Language: en-US To: Matti Vaittinen , Jonathan Cameron , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andy Shevchenko , Paul Gazzillo Cc: Matt Ranostay , Stefan Windfeldt-Prytz , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20231026143532.39660-1-subhajit.ghosh@tweaklogic.com> <20231026143532.39660-3-subhajit.ghosh@tweaklogic.com> <341cb934-2e91-442a-a4db-2f69f79ad0b6@gmail.com> From: Subhajit Ghosh In-Reply-To: <341cb934-2e91-442a-a4db-2f69f79ad0b6@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Hi Subhajit, > > It's nice to see the GTS helpers are used (and hopefully helpful). I didn't have the time to go through everything with full focus - so please just tell me if some of my questions are silly :) The comments I marked as 'nit' aren't really important - feel free to use your judgement on them :) Thank you Matti for the review. Acknowledging all your comments, updates will be in the next version. I am glad that you liked it. GTS helpers are great. It saved me a lot of complex and error prone mathematical calculations and coding. I was surprised to get consistent Lux values in userspace across all scale ranges which closely matched with my entry level Lux meter readings after using the GTS implementation. Great work. Regards, Subhajit Ghosh