From: Vineet Gupta <Vineet.Gupta1@synopsys.com>
To: Necip Fazil Yildiran <fazilyildiran@gmail.com>
Cc: "linux-snps-arc@lists.infradead.org"
<linux-snps-arc@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"paul@pgazz.com" <paul@pgazz.com>,
"jeho@cs.utexas.edu" <jeho@cs.utexas.edu>
Subject: Re: [PATCH] arc: plat-hsdk: fix kconfig dependency warning when !RESET_CONTROLLER
Date: Mon, 14 Sep 2020 19:50:43 +0000 [thread overview]
Message-ID: <9ba22ab1-560e-3c1b-dfdc-77ebc609d41b@synopsys.com> (raw)
In-Reply-To: <20200914114651.105219-1-fazilyildiran@gmail.com>
On 9/14/20 4:46 AM, Necip Fazil Yildiran wrote:
> When ARC_SOC_HSDK is enabled and RESET_CONTROLLER is disabled, it results
> in the following Kbuild warning:
>
> WARNING: unmet direct dependencies detected for RESET_HSDK
> Depends on [n]: RESET_CONTROLLER [=n] && HAS_IOMEM [=y] && (ARC_SOC_HSDK [=y] || COMPILE_TEST [=n])
> Selected by [y]:
> - ARC_SOC_HSDK [=y] && ISA_ARCV2 [=y]
>
> The reason is that ARC_SOC_HSDK selects RESET_HSDK without depending on or
> selecting RESET_CONTROLLER while RESET_HSDK is subordinate to
> RESET_CONTROLLER.
>
> Honor the kconfig menu hierarchy to remove kconfig dependency warnings.
>
> Fixes: a528629dfd3b ("ARC: [plat-hsdk] select CONFIG_RESET_HSDK from Kconfig")
> Signed-off-by: Necip Fazil Yildiran <fazilyildiran@gmail.com>
Applied to for-curr
Thx,
-Vineet
> ---
> arch/arc/plat-hsdk/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arc/plat-hsdk/Kconfig b/arch/arc/plat-hsdk/Kconfig
> index ce8101834518..6b5c54576f54 100644
> --- a/arch/arc/plat-hsdk/Kconfig
> +++ b/arch/arc/plat-hsdk/Kconfig
> @@ -8,5 +8,6 @@ menuconfig ARC_SOC_HSDK
> select ARC_HAS_ACCL_REGS
> select ARC_IRQ_NO_AUTOSAVE
> select CLK_HSDK
> + select RESET_CONTROLLER
> select RESET_HSDK
> select HAVE_PCI
prev parent reply other threads:[~2020-09-14 19:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-14 11:46 Necip Fazil Yildiran
2020-09-14 19:50 ` Vineet Gupta [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ba22ab1-560e-3c1b-dfdc-77ebc609d41b@synopsys.com \
--to=vineet.gupta1@synopsys.com \
--cc=fazilyildiran@gmail.com \
--cc=jeho@cs.utexas.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=paul@pgazz.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®