From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B76539A7F4 for ; Mon, 27 Apr 2026 09:32:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777282354; cv=none; b=pEFpIpJ15R5ub0k1Op7kXkO3QVL0M3ZX57AG1+POX+VZE1i9nJQIuWrx2EdtAUShly8Ojqk06hzQhEz4tV7t5LC8OI7kcksJTaJL3FAAUgUhFt5Fyks5LQYHOuIdjEfWF/AGr3UrUIMoI4dppcnaFI4BvycEHEMs0wqMTZOMhYo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777282354; c=relaxed/simple; bh=9wTw4cSIVdKTZ30GQrfhR8pxMdm96q7pSl6gYFes1AM=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=EXmwKPIKqKYD4OU4xsS31XEYTJM6vMW5/aM0Im1T7TRNmmRSeBcjQ+m9QeV5DHVMqXPbXJ6AaN+0EwLm/tzc7kLVsU4zW36C3D34ffndOgDdQZ5+GlPmkDoDP8z4nW6BAM3gE1/hW05J+Tm8kWSYs+QqEOWRL0sI+HCVUlML/dI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=H/aLECrk; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=krJ3FqC+; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="H/aLECrk"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="krJ3FqC+" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777282351; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DZgJ8cDpzqz4seiWnL8vet6Bd8LTiDArtz8YZYnTyjA=; b=H/aLECrk0QMUJ9dO3j7P6N+hcDo980aN7aKfn82s7L8iQoVwynHCOZt6YSk11Zo/xot/fU 2We6yGxhSjAJv/khdB3zpfrY/WRB3iwQNO3oEclnkgcB6qbAEBDCNz5gr7hjrzQAiChOcX na2J0FvB5E9XiQLU62xhVwj4zB9yKIQ= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-515-4dVxG-duO1ymFkxBJjmXpw-1; Mon, 27 Apr 2026 05:32:28 -0400 X-MC-Unique: 4dVxG-duO1ymFkxBJjmXpw-1 X-Mimecast-MFC-AGG-ID: 4dVxG-duO1ymFkxBJjmXpw_1777282348 Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8d4c2906fdfso1026656385a.2 for ; Mon, 27 Apr 2026 02:32:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1777282348; x=1777887148; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=DZgJ8cDpzqz4seiWnL8vet6Bd8LTiDArtz8YZYnTyjA=; b=krJ3FqC+hoW0IMhXq9Eu6j5LVRD/aQ4eFdsaIaAzi7mdK5Nen81R+ysAVcGwahdjYg Tc/PwrYJ7xzc2VQ03i/5Fd18Gpssgr3nPs+T56hVDqP7Bx+aLOnC3cdFfASDMrTlj96D tsxxTWtqb3byA46Gk/7KJJyf+CqKwvpiO9nma64442d65Bk/Oy2jE04xt+8qqjMxUPuD apaxA2ZeMm+Jy4ddb8SzjcvFkBM8/jy1MLkYLY0YGtz5ekjNjA0HbM0xGenSX4Zfb+xl TllvljLRWxQSQ6rXOjtmaeI7Vrze4tL062G+BHY4WcUk7IfXP+Th7mAhzesnEx/BvpzN kNCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777282348; x=1777887148; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DZgJ8cDpzqz4seiWnL8vet6Bd8LTiDArtz8YZYnTyjA=; b=VBVkukttGl56OsRj6emVlsfypZVBSvgnJOkxlnCFNNFb8qhBeVH5bi9a5SR1yFjD8s sa/onWCpEtnbytW7TyC4UD7E2TgWmZDt+HJ081wUFzRipkmq4vpMXj1fwBxiY1pJlBM4 vlMlbehepB5jI9ULHXR6TEt2P5pKY5EkddzFzJO+9mEp1AhrPes6lj+WHrccDRKCMTsc RwsH1HuRbre3e2vPjvpfU216AgHU28+hTMpifjdAscPLcyNzsU8TPiuUwyUtRHyRY450 Ye4VIGT2lrVwSE11PQnY8mHye3uH7kScBY4a4MtLIlbuApira6/OxIolExbt7gyJgCDF sk9A== X-Forwarded-Encrypted: i=1; AFNElJ+Y3EC330RNh3pzlaYSqwrFOM4tB4hQgqt/HWh8dchH+mpvVLeloqYRD2oXNfYd/flkAlbCSiLiQs9EScU=@vger.kernel.org X-Gm-Message-State: AOJu0YwVFzlK2K8a1chhwce75vj5bAN09O57kMsddT55Hd2ga7L4BQlN zWohOwY7L+fIav7hbjgOOzWRC+Sx/5shwNGRjLeNVVH0a7iSKH7UmAVuTA+36B0K3khFiuacl75 zPhAbgvnxnpW6+u9OPif6HrtevL0PLk/v/nyKY8CUFOJ5zTVz/F7nb3PT+lEJPW8jcI+IDGOTPA == X-Gm-Gg: AeBDiesFNoTx5A6rO5tvvefp5qZb6SPHxyXQ51xxJi2qt0fzpUnmI/eCGu1dHHtOAZl tMITMgmNylqm47syOnTiiTvpQj9hsOF6hBEGfp2lwZRO+zPmUEQc/wywRTyfyTLIL6qM2xdXU4J nRnA+Xpt2wR9GLOAzsqVLMu43WRj6r4pQaclcHGg0oLZEr5ed3XeBqRh5AwsgjMLwuzim144rYw u28bx2DErFOyrl/2K0nB2flXEDNKapUWdqcnvtdXJtBTZMnek4xwyXeuUZRlKEgVJ5a6sLajEcD qNvb90rAV9gdSFX9TpLCRHcLRHyy4RDAD1lY08mJrzptgaoQ/N66C/D7+6NDBGzyay8JVneJLLw sQ9cDzAxKQA3FqfHwn0/Q7IqrvwEUPfJArnwj X-Received: by 2002:a05:620a:4555:b0:8f0:a3f8:fb2d with SMTP id af79cd13be357-8f0a3f914f3mr2890305385a.2.1777282347855; Mon, 27 Apr 2026 02:32:27 -0700 (PDT) X-Received: by 2002:a05:620a:4555:b0:8f0:a3f8:fb2d with SMTP id af79cd13be357-8f0a3f914f3mr2890302385a.2.1777282347355; Mon, 27 Apr 2026 02:32:27 -0700 (PDT) Received: from [192.168.1.167] ([185.168.96.228]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8ee67115aeasm1746799885a.44.2026.04.27.02.32.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Apr 2026 02:32:26 -0700 (PDT) Message-ID: <9baaa22d80fdd2dc7a15d2db9318a921b7d661bb.camel@redhat.com> Subject: Re: [PATCH 1/1] tools/rv: ensure monitor name and desc are NUL-terminated From: Gabriele Monaco To: unknownbbqrx Cc: rostedt@goodmis.org, linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 27 Apr 2026 11:32:23 +0200 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.3 (3.58.3-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Thu, 2026-04-23 at 17:19 +0300, unknownbbqrx wrote: >=20 > ikm_fill_monitor_definition() copies monitor name and description > with > strncpy(), but does not guarantee NUL termination when source strings > are > equal to or longer than the destination buffers. >=20 > Clamp copies to sizeof(dst) - 1 and explicitly append '\0' for both > fields > to keep them safe for later string operations. Hi, thanks for the fix! Looks good to me. Reviewed-by: Gabriele Monaco Fixes: 6d60f89691fc9 ("tools/rv: Add in-kernel monitor interface") On a side note, you sent 2 patches and you apparently sent them both twice (did you issue git send-email twice? They seem equivalent to me), next time you could merge them in the same series, just preparing them in the same branch and passing them all to git format-patch/send-email [1]. In general you'd also add a cover letter, can be very simple in this case. That's usually tidier and easier to apply for maintainers/reviewers. (You can ignore it this time) Also add the Fixes: tag if you're fixing something (e.g. a potential buffer overflow in this case), I did it for you now but you can find the commit you're fixing using git blame. [1] - https://www.kernel.org/doc/html/latest/process/submitting-patches.html >=20 > Signed-off-by: unknownbbqrx > --- > =C2=A0tools/verification/rv/src/in_kernel.c | 7 ++++--- > =C2=A01 file changed, 4 insertions(+), 3 deletions(-) >=20 > diff --git a/tools/verification/rv/src/in_kernel.c > b/tools/verification/rv/src/in_kernel.c > index 4bb746ea6..d32453824 100644 > --- a/tools/verification/rv/src/in_kernel.c > +++ b/tools/verification/rv/src/in_kernel.c > @@ -215,10 +215,11 @@ static int ikm_fill_monitor_definition(char > *name, struct monitor *ikm, char *co > =C2=A0 return -1; > =C2=A0 } > =C2=A0 > - strncpy(ikm->name, nested_name, MAX_DA_NAME_LEN); > + strncpy(ikm->name, nested_name, sizeof(ikm->name) - 1); > + ikm->name[sizeof(ikm->name) - 1] =3D '\0'; > =C2=A0 ikm->enabled =3D enabled; > - strncpy(ikm->desc, desc, MAX_DESCRIPTION); > - > + strncpy(ikm->desc, desc, sizeof(ikm->desc) - 1); > + ikm->desc[sizeof(ikm->desc) - 1] =3D '\0'; > =C2=A0 free(desc); > =C2=A0 > =C2=A0 return 0;