mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paolo Abeni <pabeni@redhat.com>
To: DelphineCCChiu <delphine_cc_chiu@wiwynn.com>,
	patrick@stwcx.xyz, Samuel Mendoza-Jonas <sam@mendozajonas.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] net/ncsi: Fix the multi thread manner of NCSI driver
Date: Mon, 27 May 2024 11:11:25 +0200	[thread overview]
Message-ID: <9bb0e47adf20c5524b45712fc92a37f2dae568be.camel@redhat.com> (raw)
In-Reply-To: <20240522012537.2485027-1-delphine_cc_chiu@wiwynn.com>

Hi,

On Wed, 2024-05-22 at 09:25 +0800, DelphineCCChiu wrote:
> Currently NCSI driver will send several NCSI commands back to back without
> waiting the response of previous NCSI command or timeout in some state
> when NIC have multi channel. This operation against the single thread
> manner defined by NCSI SPEC(section 6.3.2.3 in DSP0222_1.1.1)
> 
> According to NCSI SPEC(section 6.2.13.1 in DSP0222_1.1.1), we should probe
> one channel at a time by sending NCSI commands (Clear initial state, Get
> version ID, Get capabilities...), than repeat this steps until the max
> number of channels which we got from NCSI command (Get capabilities) has
> been probed.
> 
> Signed-off-by: DelphineCCChiu <delphine_cc_chiu@wiwynn.com>

As noted by Jakub, this looks like a fix. Please include a suitable
Fixes tag in the tag area and the target tree 'net' inside the subject
prefix.

Thanks!

Paolo


  reply	other threads:[~2024-05-27  9:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-22  1:25 DelphineCCChiu
2024-05-27  9:11 ` Paolo Abeni [this message]
2024-05-29  7:15   ` Delphine_CC_Chiu/WYHQ/Wiwynn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9bb0e47adf20c5524b45712fc92a37f2dae568be.camel@redhat.com \
    --to=pabeni@redhat.com \
    --cc=davem@davemloft.net \
    --cc=delphine_cc_chiu@wiwynn.com \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=patrick@stwcx.xyz \
    --cc=sam@mendozajonas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®