From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-1704338-1520256981-2-10365877305088810903 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.249, ME_NOAUTH 0.01, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='CN', FromHeader='net', MailFrom='org' X-Spam-charsets: plain='utf-8' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: linux-api-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1520256980; b=R+RkcUeK+PYVL64k1159CZaoFy1OHwcL/qNiDhmx0DibQvw NsyiUDkQdYjR4hb673IUgTIEwxxKastlLQLEnCIf4YGDxvLI42JDYQIcdTfsvJrW AksZOZKNvQhcEkW7W53HyXjC+pPMidU2LgKlypNSkya/rQpzD1jbwKCnltJfWVWv XuDsXNilsAUA6kR+Wrnj1kTP4AwGBMYIR40HUoj5kewVfbr5nVd5PNrWHSKRDDAT ejW1ebDcGDhce6uQM/a/xHjnhvLSmhDFHVM+zxFiNI3FNyvCxerw04El1CX3w6PT btPfTInxWZ2IDEGRSbUz6oHJ9IdtKUHSlX2dWPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=subject:to:cc:references:from:message-id :date:mime-version:in-reply-to:content-type :content-transfer-encoding:sender:list-id; s=arctest; t= 1520256980; bh=A4QLZmgfeOc79wUJvMt2rnDV4oi5Hdf0STGLpjAzjLU=; b=W NVJ5ol60bSZ7LeV3aJ0JdD+jvBNe3PbWrIr4G2O2APcDGHpwAxKh7Rq24gIC8kJV 0nZS6NOvA8252D79MX0EBI1YTU7e/vWOCaG/JgY6NT/iw/GxMrr6IN/lWNyWI+E9 6Ve9myAAf9OiwH66hRd2FVZetblIfXNSXkoLukA9+guSiZoOWvfan4m0ug7SVXAg TQEb5S/P4GD0Knocj+Scmv6TomJXLP9RXenw0COcvj7cGC8Mif13OtO7MKywKZGI /qlDQjlkqeGfXNONeEaY0PC23QPc2SCNi5PsHa0S77hsRjO3HRD+VxButjVpL3kZ n4fIkWiHCzGOQVRdqRkeg== ARC-Authentication-Results: i=1; mx1.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=iogearbox.net; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-api-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-category=clean score=-100 state=0; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=iogearbox.net header.result=pass header_is_org_domain=yes Authentication-Results: mx1.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=iogearbox.net; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-api-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-category=clean score=-100 state=0; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=iogearbox.net header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964881AbeCENgS (ORCPT ); Mon, 5 Mar 2018 08:36:18 -0500 Received: from www62.your-server.de ([213.133.104.62]:40233 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964876AbeCENgR (ORCPT ); Mon, 5 Mar 2018 08:36:17 -0500 Subject: Re: [PATCH bpf-next 0/5] bpf, tracing: introduce bpf raw tracepoints To: Alexei Starovoitov , davem@davemloft.net Cc: torvalds@linux-foundation.org, peterz@infradead.org, mingo@kernel.org, rostedt@goodmis.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com, linux-api@vger.kernel.org References: <20180301041957.399230-1-ast@kernel.org> From: Daniel Borkmann Message-ID: <9bb38939-c357-4db5-6cf4-7b42187f6c7c@iogearbox.net> Date: Mon, 5 Mar 2018 14:36:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20180301041957.399230-1-ast@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net Sender: linux-api-owner@vger.kernel.org X-Mailing-List: linux-api@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On 03/01/2018 05:19 AM, Alexei Starovoitov wrote: > This patch set is a different way to address the pressing need to access > task_struct pointers in sched tracepoints from bpf programs. > > The first approach simply added these pointers to sched tracepoints: > https://lkml.org/lkml/2017/12/14/753 > which Peter nacked. > Few options were discussed and eventually the discussion converged on > doing bpf specific tracepoint_probe_register() probe functions. > Details here: > https://lkml.org/lkml/2017/12/20/929 Ping, Peter/Steven. If you have a chance, please review the series. > Patch 1 is kernel wide cleanup of pass-struct-by-value into > pass-struct-by-reference into tracepoints. > > Patch 2 minor prep work to expose number of arguments passed > into tracepoints. > > Patch 3 introduces BPF_RAW_TRACEPOINT api. > the auto-cleanup and multiple concurrent users are must have > features of tracing api. For bpf raw tracepoints it looks like: > // load bpf prog with BPF_PROG_TYPE_RAW_TRACEPOINT type > prog_fd = bpf_prog_load(...); > > // receive anon_inode fd for given bpf_raw_tracepoint > raw_tp_fd = bpf_raw_tracepoint_open("xdp_exception"); > > // attach bpf program to given tracepoint > bpf_prog_attach(prog_fd, raw_tp_fd, BPF_RAW_TRACEPOINT); > > Ctrl-C of tracing daemon or cmdline tool will automatically > detach bpf program, unload it and unregister tracepoint probe. > More details in patch 3. > > Patch 4, 5 - user space lib and tests > > samples/bpf/test_overhead performance on 1 cpu: > > tracepoint base kprobe+bpf tracepoint+bpf raw_tracepoint+bpf > task_rename 1.1M 769K 947K 1.0M > urandom_read 789K 697K 750K 755K > > Alexei Starovoitov (5): > treewide: remove struct-pass-by-value from tracepoints arguments > tracepoint: compute num_args at build time > bpf: introduce BPF_RAW_TRACEPOINT > libbpf: add bpf_raw_tracepoint_open helper > samples/bpf: raw tracepoint test > > arch/x86/xen/mmu_pv.c | 16 +-- > drivers/gpu/drm/i915/i915_trace.h | 13 +- > drivers/infiniband/hw/hfi1/file_ops.c | 2 +- > drivers/infiniband/hw/hfi1/trace_ctxts.h | 12 +- > drivers/s390/cio/ioasm.c | 18 +-- > drivers/s390/cio/trace.h | 50 ++++---- > fs/dax.c | 2 +- > include/linux/bpf_types.h | 1 + > include/linux/trace_events.h | 57 +++++++++ > include/linux/tracepoint-defs.h | 1 + > include/linux/tracepoint.h | 32 +++-- > include/trace/bpf_probe.h | 87 +++++++++++++ > include/trace/define_trace.h | 15 ++- > include/trace/events/f2fs.h | 2 +- > include/trace/events/fs_dax.h | 6 +- > include/trace/events/rcu.h | 4 +- > include/trace/events/xen.h | 32 ++--- > include/uapi/linux/bpf.h | 11 ++ > kernel/bpf/syscall.c | 108 ++++++++++++++++ > kernel/rcu/tree.c | 10 +- > kernel/trace/bpf_trace.c | 211 +++++++++++++++++++++++++++++++ > kernel/tracepoint.c | 27 ++-- > net/wireless/trace.h | 2 +- > samples/bpf/Makefile | 1 + > samples/bpf/bpf_load.c | 13 ++ > samples/bpf/test_overhead_raw_tp_kern.c | 17 +++ > samples/bpf/test_overhead_user.c | 12 ++ > sound/firewire/amdtp-stream-trace.h | 2 +- > tools/include/uapi/linux/bpf.h | 11 ++ > tools/lib/bpf/bpf.c | 10 ++ > tools/lib/bpf/bpf.h | 1 + > 31 files changed, 677 insertions(+), 109 deletions(-) > create mode 100644 include/trace/bpf_probe.h > create mode 100644 samples/bpf/test_overhead_raw_tp_kern.c >