From: Andy Lutomirski <luto@kernel.org>
To: x86@kernel.org
Cc: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>,
Borislav Petkov <bp@alien8.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Brian Gerst <brgerst@gmail.com>,
Matthew Whitehead <tedheadster@gmail.com>,
Andy Lutomirski <luto@kernel.org>
Subject: [RFC PATCH 6/6] x86/fpu: Fix the "Giving up, no FPU found" test
Date: Mon, 5 Dec 2016 17:01:15 -0800 [thread overview]
Message-ID: <9bb4f6c812ae632ae26676ed6862cc1b51d44657.1480985979.git.luto@kernel.org> (raw)
In-Reply-To: <cover.1480985979.git.luto@kernel.org>
In-Reply-To: <cover.1480985979.git.luto@kernel.org>
We would never print "Giving up, no FPU found" because
X86_FEATURE_FPU was in REQUIRED_MASK on non-FPU-emulating builds, so
the boot_cpu_has() test didn't do anything.
Signed-off-by: Andy Lutomirski <luto@kernel.org>
---
arch/x86/kernel/fpu/init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/fpu/init.c b/arch/x86/kernel/fpu/init.c
index 75e1bf3b0319..d41924a72576 100644
--- a/arch/x86/kernel/fpu/init.c
+++ b/arch/x86/kernel/fpu/init.c
@@ -80,7 +80,7 @@ static void fpu__init_system_early_generic(struct cpuinfo_x86 *c)
}
#ifndef CONFIG_MATH_EMULATION
- if (!boot_cpu_has(X86_FEATURE_FPU)) {
+ if (!test_cpu_cap(&boot_cpu_data, X86_FEATURE_FPU)) {
pr_emerg("x86/fpu: Giving up, no FPU found and no math emulation present\n");
for (;;)
asm volatile("hlt");
--
2.9.3
prev parent reply other threads:[~2016-12-06 1:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-06 1:01 [RFC PATCH 0/6] CPUID and FPU fixes Andy Lutomirski
2016-12-06 1:01 ` [RFC PATCH 1/6] x86/CPU: Add X86_FEATURE_CPUID Andy Lutomirski
2016-12-06 8:08 ` Borislav Petkov
2016-12-06 1:01 ` [RFC PATCH 2/6] x86/cpu: Factor out application of forced cpu caps Andy Lutomirski
2016-12-06 8:32 ` Borislav Petkov
2016-12-06 1:01 ` [RFC PATCH 3/6] x86/cpu: Re-apply forced caps every time cpu caps are re-read Andy Lutomirski
2016-12-06 8:57 ` Borislav Petkov
2016-12-06 1:01 ` [RFC PATCH 4/6] x86/fpu: Fix "x86/fpu: Legacy x87 FPU detected" message Andy Lutomirski
2016-12-06 9:24 ` Borislav Petkov
2016-12-06 17:59 ` Andy Lutomirski
2016-12-06 18:04 ` Borislav Petkov
2016-12-06 1:01 ` [RFC PATCH 5/6] x86/fpu: Fix CPUID-less FPU detection Andy Lutomirski
2016-12-06 9:40 ` Borislav Petkov
2016-12-06 17:52 ` Andy Lutomirski
2016-12-07 9:42 ` Borislav Petkov
2016-12-06 1:01 ` Andy Lutomirski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9bb4f6c812ae632ae26676ed6862cc1b51d44657.1480985979.git.luto@kernel.org \
--to=luto@kernel.org \
--cc=bp@alien8.de \
--cc=brgerst@gmail.com \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=tedheadster@gmail.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®