From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vs1-f44.google.com (mail-vs1-f44.google.com [209.85.217.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3FAAC26ED20 for ; Wed, 22 Oct 2025 13:22:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.217.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761139355; cv=none; b=JjyHPLK+f4Tkf45mABT0aixFtdix1egme7lw7VgsGHewDfbSWduF24BIxGQdkZIddEH89gcqiBWyx/6471aBCJPAsih7y/IpKxfFh9kToZrf54bb26WTm3uzrz0x4Po2ZHUedalc4Ifp4bmxHNM3qSqH0TLxYzAF4q/RoJyBsvc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761139355; c=relaxed/simple; bh=kIgAHNYvOFEuUkO4rNfbG2Xes9Yw1wwtK3/M1F3s6kg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=c/Qnhflg5Vrhp75TXcpnshjnZgDqMn+5u8rh5XaBvObmjj7MxOP0lMTej7qR0/uG9Z8kRAgpERY+IZaFY2ZLL+3/OZ6WsU0wAjoRr5oSCoMg7q4G4gGqEzM/bckGOZFdJfP/B/Hhoi4dJ2ZoGtfp77EN9iwGg0C4x42+8+FrSzM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=i6CYPYac; arc=none smtp.client-ip=209.85.217.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="i6CYPYac" Received: by mail-vs1-f44.google.com with SMTP id ada2fe7eead31-5d980e08e06so1730824137.0 for ; Wed, 22 Oct 2025 06:22:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761139353; x=1761744153; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=kIgAHNYvOFEuUkO4rNfbG2Xes9Yw1wwtK3/M1F3s6kg=; b=i6CYPYacketJEN8ewnxIgtuOlv9M0ZPCQu9F2yWBeCYM2/wUS8gMZijQ47maa6efcG FuIxNW9NmwvXOXFp4kWjmA1IvMgLL0gj1wM+x+4KCG/MgFQmj7NiGrJ2UIfi6V8EWcC0 A4Q/6yf5bddw0QRDqUipGzJY0qP37TESQC/0NBQm3+16j8dPwo2CzBB6DsJWNpzBfoDj pe0e31yuK4DfNVVP9ox1CmldmGawm5ix4PaZSJJrrlzJdaFwxDyIL2IKd/xdA9UPhfTf 0uoJ0z7oPZbWxw0nZKfsat/IPYuSckhl6df0MLwk7mEjyB0OtoTrmK6dVs8QTKZt7U6B pwVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761139353; x=1761744153; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kIgAHNYvOFEuUkO4rNfbG2Xes9Yw1wwtK3/M1F3s6kg=; b=VVFXzq7HCcfQwGw4BP6GprUvqHdqFQ5zVVu8NqBHLHYZVoEQa3olrdnnLAzJzFpm54 c8wy7viDEcYXMWKPcjmWHwzRfYyCRT0pL8rVMZrddjb+OnWss5uVenizs7sKAW/7xI8O wLLz4tVu17Ztz3MN9xLLZmL7sRXUKgXSATX2Cmj3jrtittQUsTrOXkXXwN1JeYojrbbb HWNd76AerhTxXB2CRJMGDjiEbjWezbbPjZccDzLCDzJSRftkRONmCPKQjuOFLYJ/JGAa KeJFDJnVRbk7vnCK0Vh8hMeL3RumJUdgzxV4BMmPkgj96+Z29rkobW/6N7VxHOMmXym/ zMTQ== X-Forwarded-Encrypted: i=1; AJvYcCXAeoNODryX+jgrXV5ekAvUyusw5RRqnuEdiKZY5fZdsJ9qpmJZl6BbY2DoC0dNA3O3W21lWuZnpiVSy8M=@vger.kernel.org X-Gm-Message-State: AOJu0Ywz71GGSMKeWIS99+dZ5uj5wHlzs4Pleh9GMkT2cRI1k9xoL028 TYtM74NzUI+pSNpzqBhnqvvij8zjx0EJdIdvbPOtKrH6bxPn2WUoHNbl X-Gm-Gg: ASbGncvnqT1Xd7R0IlWMZjt3C6vOgXQZi2pyIxydmS5vwQP8OPybY7kZIN7D9+fllcO /oQq68wYj43fa0hQzLa8Iibn/Gf1N9cAN1mRbQ8OtCq49p0QlN50ag6IHCFoyE8SPbcKOLqfKKH Oy9sc1MraEzfk2zvWiXO9SoLywbuAk33j3bkOCKaR0z//axxmFovSEXzqI62QgNyzMqKVjYXFbK DsIxb2zn7tbRqxRssJ7lXe3DqFWWsq0DhhmKIS6VSkcN+IcE60NiyfEDlKeHwBk+Is53IsMKPa4 5f5e74PeOW4Ry4+XfvBQFVZ9bi5fCLyJ1MGYVElnoSkoZoLD0sUzrAje3DmiLjFc68pnM/3EbuG vp+Paqh8ropE3hxOurN48eIuuDIONHGhcpPW/6r/HagLRleBm+qWeK6czsM61w9llot8GO/NWSD ZaNr0Xz5vG2AX3/MHy X-Google-Smtp-Source: AGHT+IEm8L6FEpAdRSZbcd0wF9nqzm1wzgL/FJhZQKf70WgEl9kbX/Hyj0iCqdeQUn2qPBgEF/3rHg== X-Received: by 2002:a05:6102:d8d:b0:5c3:d964:a689 with SMTP id ada2fe7eead31-5d7dd67f8a5mr6408266137.32.1761139352889; Wed, 22 Oct 2025 06:22:32 -0700 (PDT) Received: from [192.168.1.145] ([104.203.11.126]) by smtp.gmail.com with ESMTPSA id a1e0cc1a2514c-932c3e32e11sm4680749241.12.2025.10.22.06.22.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Oct 2025 06:22:32 -0700 (PDT) Message-ID: <9bb82a26-c0e7-4e3f-abce-0ef07e1cff66@gmail.com> Date: Wed, 22 Oct 2025 09:22:28 -0400 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] jfs: validate budmin to prevent shift-out-of-bounds in dbAllocAG() To: sukrut heroorkar Cc: Dave Kleikamp , Rand Deeb , Edward Adam Davis , Ghanshyam Agrawal , Nihar Chaithanya , Vasiliy Kovalev , Arnaud Lecomte , "open list:JFS FILESYSTEM" , open list , skhan@linux.foundation.org, syzbot+4b717071f1eecb2972df@syzkaller.appspotmail.com References: <20251018053029.226506-1-hsukrut3@gmail.com> Content-Language: en-US From: David Hunter In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 10/19/25 05:42, sukrut heroorkar wrote: > Hi David, > On Sun, Oct 19, 2025 at 12:50 AM David Hunter > wrote: >> >> On 10/18/25 01:30, Sukrut Heroorkar wrote: >>> Tested-by: syzbot+4b717071f1eecb2972df@syzkaller.appspotmail.com >> >> >> Hey Sukrut, >> >> Did you do any other testing other than syzbot testing? > I also used the C reproducer to test my fix locally with QEMU and it > no longer triggers error. Do you recommend any > other tests? Please let me know. > Thanks, > Sukrut. >> Thanks, >> David Hunter Hey Sukrut, You always need to do testing to ensure that your code does not bring in regressions into the kernel. If doing things to file systems, xfstests is at least the basic testing that you should do. You can also search to see if any other publicly tools are available and/or applicable, but xfstests are the minimum. Thanks, David Hunter