mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Kairui Song <ryncsn@gmail.com>, Zi Yan <ziy@nvidia.com>
Cc: Shivam Kalra <shivamkalra98@zohomail.in>,
	Kairui Song <kasong@tencent.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Lorenzo Stoakes <ljs@kernel.org>,
	Baolin Wang <baolin.wang@linux.alibaba.com>,
	"Liam R. Howlett" <liam@infradead.org>,
	Ryan Roberts <ryan.roberts@arm.com>, Dev Jain <dev.jain@arm.com>,
	Barry Song <baohua@kernel.org>, Lance Yang <lance.yang@linux.dev>,
	Usama Arif <usama.arif@linux.dev>,
	Vlastimil Babka <vbabka@kernel.org>,
	Mike Rapoport <rppt@kernel.org>,
	Suren Baghdasaryan <surenb@google.com>,
	Michal Hocko <mhocko@suse.com>, Shuah Khan <shuah@kernel.org>,
	Nico Pache <nico.pache@linux.dev>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	linux-kselftest@vger.kernel.org
Subject: Re: [PATCH 0/3] mm: support splitting mappingless swapcache folios
Date: Tue, 8 Sep 2026 16:12:23 +0200	[thread overview]
Message-ID: <9bc5787d-6106-4d0f-816e-cdf5a308abd6@kernel.org> (raw)
In-Reply-To: <anZLkwwxHdhM2M2Q@KASONG-MC4>

On 8/7/26 23:22, Kairui Song wrote:
> On Fri, Aug 07, 2026 at 10:18:05AM +0800, Zi Yan wrote:
>> On Wed Aug 5, 2026 at 11:54 AM EDT, Kairui Song wrote:
>>>
>>> Thanks for the CC, this is actually not hard to implement as shown by
>>> Shivam, I just found the code more and more hard to follow and fragile
>>> as we add more logic to it. And we don't have to reject higher order
>>> split either which can be seen easily if the code is cleaner.
>>>
>>> Personally I think doing some cleanup first is better, I haven't post any
>>> code as right now there doesn't seem to be much user of this. It will be
>>> needed if more clean THP swapcache begin to show up due to things like
>>> THP readahead for swap, which isn't here yet. I think I can send an RFC
>>> tomorrow just for reference. I'm fine if we prefer to remove that TODO
>>> using this smaller change first :)
>>
>> Thanks. Can you also help review this patchset? The changes looks good
>> to me but I am not sure if I get all the details about swapcache handling.
>>
>> -- 
>> Best Regards,
>> Yan, Zi
> 
> Hello,
> 
> Thanks for the reminder, I got a bit busy so delayed for a day on that
> RFC.
> 
> For this series I think it's functionally fine, just the split logic is
> a bit complex to follow and we still have restriction on swap cache
> for order 0 uniform split only. I'll have a closer look later. Also
> let me know how you think about that RFC.

How does this patch set relate to your split cleanups? Is it still applicable
independently?

-- 
Cheers,

David

      parent reply	other threads:[~2026-09-08 14:12 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-05 11:18 Shivam Kalra via B4 Relay
2026-08-05 11:18 ` [PATCH 1/3] mm/huge_memory: allow " Shivam Kalra via B4 Relay
2026-08-05 11:18 ` [PATCH 2/3] mm: add KUnit coverage for " Shivam Kalra via B4 Relay
2026-08-08 11:10   ` Kairui Song
2026-08-08 15:32     ` Shivam Kalra
2026-08-05 11:18 ` [PATCH 3/3] selftests/mm: test hwpoison recovery of mappingless swapcache THPs Shivam Kalra via B4 Relay
2026-08-05 12:03 ` [PATCH 0/3] mm: support splitting mappingless swapcache folios Zi Yan
2026-08-05 15:54   ` Kairui Song
2026-08-07 14:18     ` Zi Yan
2026-08-07 21:22       ` Kairui Song
2026-08-08 17:02         ` Zi Yan
2026-08-09 22:19           ` Shivam Kalra
2026-09-08 14:12         ` David Hildenbrand (Arm) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9bc5787d-6106-4d0f-816e-cdf5a308abd6@kernel.org \
    --to=david@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=baohua@kernel.org \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=dev.jain@arm.com \
    --cc=kasong@tencent.com \
    --cc=lance.yang@linux.dev \
    --cc=liam@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ljs@kernel.org \
    --cc=mhocko@suse.com \
    --cc=nico.pache@linux.dev \
    --cc=rppt@kernel.org \
    --cc=ryan.roberts@arm.com \
    --cc=ryncsn@gmail.com \
    --cc=shivamkalra98@zohomail.in \
    --cc=shuah@kernel.org \
    --cc=surenb@google.com \
    --cc=usama.arif@linux.dev \
    --cc=vbabka@kernel.org \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®