From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 72E3620B7FF for ; Thu, 13 Feb 2025 12:59:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739451574; cv=none; b=Bq9dCSJ66W5uoKcSK3TK2YKmYdlD/wY0e1udjEgWhE4M1iVR+ifaZ24BusJFx70zJ3OT7jsqn0PLd7OeupbhEUXdPilLnSpiNJCmtnI1Z9B/tqb8iknkLA8hamInas8jUqxoyABvAcMbejGPOojwnPe7tML4NIQzTDmFZCe2sos= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739451574; c=relaxed/simple; bh=lQmPl/pLM1Yy9NviILg+c8UabZAvRokQJuAve8rSh4U=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=UFNlZCd1pnREImk7r7oWsnTN0EZYzPVXxiuXv9AVzdYbAP5bD+6GsPRWrVF0nE7n8A1v4tKKcd+5OdYt3zhTMonbPB3PJPqpaQ9LHjnpnf+pui3ckI2b6+nj7mIt5H3IcQs52wRBcs8jlkGTWttk0MkT7dPTQ3+EJzl4mGW6bPY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=e5YN3H1K; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="e5YN3H1K" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739451571; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=fujQcuDo9J87ofsx+TLKXGXGbfi37HBSQ8k+8GDOCTs=; b=e5YN3H1KdGGSUbcBKDMDd9m1psWtoR16nZemgOznRRZU3/oDue0QZj3aJrsgKEiHV+Xzr3 oxegIzP6m0QqXrv4tmV0pWlmnEBK21obI38jfo5A2hAFUYJLhtiCT12S46+VgqlyU+lkX2 vQNqEDzy7nxd3Q2nmV10YylzbFgIT8o= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-284-TYJ-aqIPOLmhAWZQzKhmcA-1; Thu, 13 Feb 2025 07:59:30 -0500 X-MC-Unique: TYJ-aqIPOLmhAWZQzKhmcA-1 X-Mimecast-MFC-AGG-ID: TYJ-aqIPOLmhAWZQzKhmcA_1739451569 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-38dd0265d97so536901f8f.0 for ; Thu, 13 Feb 2025 04:59:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739451569; x=1740056369; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=fujQcuDo9J87ofsx+TLKXGXGbfi37HBSQ8k+8GDOCTs=; b=B1mELL4x3tahCNAZG1P9hbwcMQqFndkT/ldBOiUBNYJT7UKtCIkuDnexq8fowKvfBW qXB4ywcz42sxK4tBFsRwbE6Dx4NV3iLYA6tlYtpIzHIRVZJFCYiQE9FCdZ+dP2bSnk/0 GidxmOLuMy3W+bPvVeA5HdFDS4OtfDcyToAXVCx4geIqpDoZNGf13rp70d0B3zCLHDv8 0m42ZoXRyREy1mrO7T7tKP/5qSD8lkVH048gzJ6WEsAISuI7bWLaPLNPuCTHqYjjI8lB XBTdYJmfPMIwY8rlc4Wh2ZdPJFIzRqyw/YMRUDzSI4/SJum+Jd27di6k03+TZ2VVuggl u2iw== X-Forwarded-Encrypted: i=1; AJvYcCW6d+qgqktQf8gsgA9EwL08CWpXDSeQfQNYrXLxiF9d5tUT5nqb9+LYuc9tMWAOqvMxiL+ipK87ElO9B5I=@vger.kernel.org X-Gm-Message-State: AOJu0Yy8+LX8hYmisnTmgfB938o+favCn53lF0dqROqB/Duy0YI9oMfT op9CYI1g/PLVSVdL95s0pcCCGpdOWEMlPkhdVtCOtPsSyOTaDQvzsQJI4HdwaFZ9/0zRWMKL5+P n7pkeSVitiVDaAQqVL0ZhJd0jhENrGGvy2GD0AB32ekaTY5kzde9ShaXDKl8R+A== X-Gm-Gg: ASbGncvFDwBk3PV62L/AtfNB3GPWYwZcT+g9WbYCGrj7qOkL28lYLwyGPqGtWR+3lfW vs6DpHuU5k8gb+i9hhWQEiND4YS7GeAK78F4xS3gKpLBD2sSzwQ19Rasq8JyBKQ2e37WXzjldBg NezbnZZ2o4dpwSgqXRTmwt49Yjf24fbGX5Ljn8b31AmFvx/AY8IPK1EbIbeUaVdNIGXW8C4CLL0 HwOqlwIMY5br4SS2FRZZMjEmMlCWoPwKEHeBVVG/z3IOZ0c6NE7HWPCcEypdQosDDapoHIJGCi4 KefWKXsIcPZKUWkYdC9ZGMn6dpBmm0gcRceKzg7rkDOIvc33Q65hXzLO2pIWefcTD+ok4v+toEj 6kZ/jN8UVBz4ktLZpblqcEeju5937JA== X-Received: by 2002:a5d:448f:0:b0:38d:b28f:566e with SMTP id ffacd0b85a97d-38dea271a35mr6486124f8f.21.1739451568899; Thu, 13 Feb 2025 04:59:28 -0800 (PST) X-Google-Smtp-Source: AGHT+IHxZ8Mqp3ocRrEcmNJLaftIa8GhH9BoSzacpHhP8FrLdFX3M0pWiywCH3wHnjAaCJoFenB1+Q== X-Received: by 2002:a5d:448f:0:b0:38d:b28f:566e with SMTP id ffacd0b85a97d-38dea271a35mr6486103f8f.21.1739451568547; Thu, 13 Feb 2025 04:59:28 -0800 (PST) Received: from ?IPV6:2003:cb:c718:100:347d:db94:161d:398f? (p200300cbc7180100347ddb94161d398f.dip0.t-ipconnect.de. [2003:cb:c718:100:347d:db94:161d:398f]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4396180f7d6sm17145955e9.17.2025.02.13.04.59.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Feb 2025 04:59:27 -0800 (PST) Message-ID: <9bc91fe3-c590-48e2-b29f-736d0b056c34@redhat.com> Date: Thu, 13 Feb 2025 13:59:25 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6] arm64: mm: Populate vmemmap/linear at the page level for hotplugged sections To: Zhenhua Huang , anshuman.khandual@arm.com, catalin.marinas@arm.com Cc: will@kernel.org, ardb@kernel.org, ryan.roberts@arm.com, mark.rutland@arm.com, joey.gouly@arm.com, dave.hansen@linux.intel.com, akpm@linux-foundation.org, chenfeiyang@loongson.cn, chenhuacai@kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, quic_tingweiz@quicinc.com, stable@vger.kernel.org References: <20250213075703.1270713-1-quic_zhenhuah@quicinc.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250213075703.1270713-1-quic_zhenhuah@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 13.02.25 08:57, Zhenhua Huang wrote: > On the arm64 platform with 4K base page config, SECTION_SIZE_BITS is set > to 27, making one section 128M. The related page struct which vmemmap > points to is 2M then. > Commit c1cc1552616d ("arm64: MMU initialisation") optimizes the > vmemmap to populate at the PMD section level which was suitable > initially since hot plug granule is always one section(128M). However, > commit ba72b4c8cf60 ("mm/sparsemem: support sub-section hotplug") > introduced a 2M(SUBSECTION_SIZE) hot plug granule, which disrupted the > existing arm64 assumptions. > > Considering the vmemmap_free -> unmap_hotplug_pmd_range path, when > pmd_sect() is true, the entire PMD section is cleared, even if there is > other effective subsection. For example page_struct_map1 and > page_strcut_map2 are part of a single PMD entry and they are hot-added > sequentially. Then page_struct_map1 is removed, vmemmap_free() will clear > the entire PMD entry freeing the struct page map for the whole section, > even though page_struct_map2 is still active. Similar problem exists > with linear mapping as well, for 16K base page(PMD size = 32M) or 64K > base page(PMD = 512M), their block mappings exceed SUBSECTION_SIZE. > Tearing down the entire PMD mapping too will leave other subsections > unmapped in the linear mapping. > > To address the issue, we need to prevent PMD/PUD/CONT mappings for both > linear and vmemmap for non-boot sections if corresponding size on the > given base page exceeds SUBSECTION_SIZE(2MB now). > > Cc: # v5.4+ > Fixes: ba72b4c8cf60 ("mm/sparsemem: support sub-section hotplug") > Reviewed-by: Catalin Marinas > Signed-off-by: Zhenhua Huang Just so I understand correctly: for ordinary memory-sections-size hotplug (NVDIMM, virtio-mem), we still get a large mapping where possible? -- Cheers, David / dhildenb