From: Randy Dunlap <rdunlap@infradead.org>
To: Alok Tiwari <alok.a.tiwari@oracle.com>,
linux-nvme@lists.infradead.org, kbusch@kernel.org,
axboe@kernel.dk, hch@lst.de, sagi@grimberg.me, kch@nvidia.com,
nilay@linux.ibm.com, corbet@lwn.net
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] nvme: Fix incorrect variable in io cqes error message
Date: Mon, 23 Jun 2025 13:44:58 -0700 [thread overview]
Message-ID: <9bcc6786-772f-4298-928f-34f3c6dc64d6@infradead.org> (raw)
In-Reply-To: <20250623064036.4187788-3-alok.a.tiwari@oracle.com>
On 6/22/25 11:40 PM, Alok Tiwari wrote:
> Corrected the error log to print ctrl->io_cqes instead of
> incorrectly using ctrl->io_sqes for the io cqes size check.
>
> Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
> ---
> drivers/nvme/target/pci-epf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvme/target/pci-epf.c b/drivers/nvme/target/pci-epf.c
> index a4295a5b8d280..44288d8f5aa11 100644
> --- a/drivers/nvme/target/pci-epf.c
> +++ b/drivers/nvme/target/pci-epf.c
> @@ -1860,7 +1860,7 @@ static int nvmet_pci_epf_enable_ctrl(struct nvmet_pci_epf_ctrl *ctrl)
> ctrl->io_cqes = 1UL << nvmet_cc_iocqes(ctrl->cc);
> if (ctrl->io_cqes < sizeof(struct nvme_completion)) {
> dev_err(ctrl->dev, "Unsupported I/O CQES %zu (need %zu)\n",
> - ctrl->io_sqes, sizeof(struct nvme_completion));
> + ctrl->io_cqes, sizeof(struct nvme_completion));
> goto err;
> }
>
--
~Randy
next prev parent reply other threads:[~2025-06-23 20:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-23 6:40 [PATCH 1/5] nvme: Fix multiple spelling and grammar issues in host drivers Alok Tiwari
2025-06-23 6:40 ` [PATCH 2/5] nvme: Fix incorrect variable in io cqes error message Alok Tiwari
2025-06-23 20:44 ` Randy Dunlap [this message]
2025-06-23 6:40 ` [PATCH 3/5] nvmet: Remove redundant assignment of error code in nvmet_ns_enable() Alok Tiwari
2025-06-23 20:45 ` Randy Dunlap
2025-06-23 6:40 ` [PATCH 4/5] nvme: Fix typo in status code constant for self-test in progress Alok Tiwari
2025-06-23 20:46 ` Randy Dunlap
2025-06-23 6:40 ` [PATCH 5/5] docs: nvme: fix grammar in nvme-pci-endpoint-target.rst Alok Tiwari
2025-06-23 20:39 ` Randy Dunlap
2025-06-23 20:44 ` [PATCH 1/5] nvme: Fix multiple spelling and grammar issues in host drivers Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9bcc6786-772f-4298-928f-34f3c6dc64d6@infradead.org \
--to=rdunlap@infradead.org \
--cc=alok.a.tiwari@oracle.com \
--cc=axboe@kernel.dk \
--cc=corbet@lwn.net \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=nilay@linux.ibm.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®