From: Andrzej Hajda <a.hajda@samsung.com>
To: Hariprasad Kelam <hariprasad.kelam@gmail.com>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Sam Ravnborg <sam@ravnborg.org>,
Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Marc Zyngier <marc.zyngier@arm.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/bridge: analogix_dp: possible condition with no effect (if == else)
Date: Thu, 13 Jun 2019 15:09:37 +0200 [thread overview]
Message-ID: <9bcf16dd-c064-27eb-3749-c3933b4b605f@samsung.com> (raw)
In-Reply-To: <20190525175937.GA29368@hari-Inspiron-1545>
On 25.05.2019 19:59, Hariprasad Kelam wrote:
> fix below warning reported by coccicheck
>
> ./drivers/gpu/drm/bridge/analogix/analogix_dp_core.c:1414:6-8: WARNING:
> possible condition with no effect (if == else)
>
> Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
Mixed feelings about it, but:
Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>
I will queue it to drm-misc-next.
--
Regards
Andrzej
> ---
> drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> index 257d69b..cfcd159 100644
> --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> @@ -1411,8 +1411,6 @@ static void analogix_dp_bridge_mode_set(struct drm_bridge *bridge,
> video->color_space = COLOR_YCBCR444;
> else if (display_info->color_formats & DRM_COLOR_FORMAT_YCRCB422)
> video->color_space = COLOR_YCBCR422;
> - else if (display_info->color_formats & DRM_COLOR_FORMAT_RGB444)
> - video->color_space = COLOR_RGB;
> else
> video->color_space = COLOR_RGB;
>
prev parent reply other threads:[~2019-06-13 15:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190525175948epcas2p31156b3ec2ee712634558e04faa42b342@epcas2p3.samsung.com>
2019-05-25 17:59 ` Hariprasad Kelam
2019-06-13 13:09 ` Andrzej Hajda [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9bcf16dd-c064-27eb-3749-c3933b4b605f@samsung.com \
--to=a.hajda@samsung.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=enric.balletbo@collabora.com \
--cc=gwan-gyeong.mun@intel.com \
--cc=hariprasad.kelam@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=marc.zyngier@arm.com \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®