From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8158E3B19AA for ; Thu, 18 Jun 2026 08:55:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781772921; cv=none; b=N/DPdJJQsjq/C0N2I3PeiyZU9JMaA8DJwrCkmgCC8eKYkqu89Ui7Q9J1lbRyGsOyqv5IVm1UsbbuLTfcXvFSpwxNJlgUGL/x0ydjXG0wMIs9mckv03znninl3rj9JI2D2sHwKn36IgNH0oka1B8jhkpzljTr1gXU/DI831JZPaA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781772921; c=relaxed/simple; bh=lnICbhLhzotstOZ8ZJozhEPKb2XQoYhegRFC/4ln0HM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hoF7uj1jtqf7LaseKeHfZ15UQGKENF1Hu1setUIJ28rZdQfApKeg+8WEfe2if4iW4Bgqn8k8g0xjr9Awg3kjN8HbtUNtqUR4j7OpR0mB9DJcKqJlOF181xu4wKtvZbomtZW5mKiM7bXwET4cXLTU6iNGGeOGAj56VCp/91r3WyY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=XwG4iIMK; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=iBnEonaQ; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="XwG4iIMK"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="iBnEonaQ" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65I8Gh7b1245046 for ; Thu, 18 Jun 2026 08:55:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 5ogJB9t+p0KYYyOrWxZJxz3yT2aITfrtM/qLnmUX6xo=; b=XwG4iIMKJeZ2D+Hz CKfKP+DHGqgj+Ue79HLYNl9b1uAnxAyVTsqGpS+ZYY6H6+hAsJiLGFM1ZFPc5Tbb NBfO2vCD0dAsDs7w6wuEArzY3SV/QITueh556KeyMZJ5l3JLmZ1Ql96dKdNatZSK old3Go6fSNOhonoI9JnR/xj55iXWG3df+alv/cfHEMNdz/eUDMprOoqR46iaKgOs FNc8bX++hZjuU3fRdeKOFz00+ZhtMAwMAHBHmLmOi2+eDybolD2/04eErECuIYsz e3/5kuiLxcKNk8mkXCWywCZHHUlJpeJ+cHEHlgwIFbSHdohakIet0i+2JmNZ9QJv U11AfQ== Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eux2jusea-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 18 Jun 2026 08:55:19 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-8dc4536d42cso2228536d6.3 for ; Thu, 18 Jun 2026 01:55:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781772919; x=1782377719; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=5ogJB9t+p0KYYyOrWxZJxz3yT2aITfrtM/qLnmUX6xo=; b=iBnEonaQR2w4BB3skIo30HZlN0FbjN/C8fuZh6UbSyus8eiCMIDjZtZYsA4dqfwJUH U7QSnmAnGvBlNVCl9zKhl2kTswQKNgR+/rV6qKymwgg4cg4S0re80mjqe76XDRzNAD2w OLZbZGIGy2tY08dPoaSjaI4k/oWmyVvVh0X92m4WCDJ9VrcTbbYizmquZfFS8tqTMJUh jE6PgnsudZRnc1d2lDHKsNN+Um6mvQ1v840n5Dhrmm4enBlPIjYtuRB9osDygL95U3kQ w2R8nEAOG0vo2P8tdcDj+zHbIMHA3UMCKG3torfhH1f+gf4DyF8MCvZRVBXjHkvA+UmH wEbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781772919; x=1782377719; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5ogJB9t+p0KYYyOrWxZJxz3yT2aITfrtM/qLnmUX6xo=; b=rxg82CUAqMaIy+K77NHAwBLeI+cvogQXps70tVRt/OAl1rmi5BMux8QiU/Cp/hVab/ R8hVThouYaqyseLXudi2DLCRGI3IpOtD3rqzUnmJcjcah20qk6AV8wxobKdqHPn5cxs5 iO37TvWRzZwCsJC5+H+8SMrj5tgTaKwGcNgL6vOOSL1F6TP6pbdeqiyyIJQ+K4YCjuWL mEtzqA0eznIZ4wbwPboJPTJb8ILKZtm4UAEaPpItpCRizR/zIt3mheSCevWytmT+2lVF tlYl6Gu4d6EUQW0GM+Cwz552FkI/IxIb3QFHoKzvZ497kBb/6H1CU4prkS6t6tHpRKuk bLMA== X-Gm-Message-State: AOJu0YxCgf9NSlTTAUQWG8JJEgo2zlPp7jVMJYnu5xFssK2jQ1f0vAk2 PQ1Rn/oSynLMUAwTneIeJVfJgft+UAlqu+FaE+shi20N4Mx8ywJXKONeaMTzy0fx2df1V1l4+Cz uLZTfCR0UffybgReGDda+j0L+5LYVCIDsq2rDCsBGjfCXyOj4PSOkCQKAQrC751kGjZw= X-Gm-Gg: Acq92OHrWuaQpcxsFDPCgSw4nlcgMa6wW50es2woqYwbkCzGsLITmX3g/c1blEiHZIh OBVz1Awy/lzLYItaKTi3r4MwbG9p68x049tCJwGf+aLq+bPa3naTULNxrHe+KQqfhvIwwrbjoo/ l8gYAerlo6bPk4/U1uXuDbxj1a4EFnDBXy+SDNYQIK5TMQhT2qmhkHKlfiR9JKzDzGGY+lKiZFZ zF5EkcFFgX3HnLPuDwlyE532UxMCkXCgotWQ+CSAJbEdo1/F95iR9CCRhGZDFmnzHU3TyYfiaUq v2x0TVrrziyd6Gn6wWxwRz4gzi7B2nIBxbCe0bTenfI6XFw/ACkr3ttlyxfKHeFjJ/qsGocNAZc 8r/0ic+Z6MfyA8ZbkKog6cpYr2kFqz8jxP5I= X-Received: by 2002:a05:620a:19a7:b0:8f3:5988:f97c with SMTP id af79cd13be357-91dbb8439b9mr682170385a.3.1781772918876; Thu, 18 Jun 2026 01:55:18 -0700 (PDT) X-Received: by 2002:a05:620a:19a7:b0:8f3:5988:f97c with SMTP id af79cd13be357-91dbb8439b9mr682167685a.3.1781772918343; Thu, 18 Jun 2026 01:55:18 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c0463a2d1f4sm407481066b.51.2026.06.18.01.55.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Jun 2026 01:55:17 -0700 (PDT) Message-ID: <9bd02660-c6d4-4c3f-bea3-95b87eaf57fe@oss.qualcomm.com> Date: Thu, 18 Jun 2026 10:55:15 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 1/2] serial: qcom-geni: trace: Drop redundant len field from geni_serial_data To: Praveen Talari , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Greg Kroah-Hartman , Jiri Slaby Cc: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org, mukesh.savaliya@oss.qualcomm.com, aniket.randive@oss.qualcomm.com, chandana.chiluveru@oss.qualcomm.com References: <20260615-add-tracepoints-for-qcom-geni-serial-v5-0-2efa4c97e0e2@oss.qualcomm.com> <20260615-add-tracepoints-for-qcom-geni-serial-v5-1-2efa4c97e0e2@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260615-add-tracepoints-for-qcom-geni-serial-v5-1-2efa4c97e0e2@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE4MDA4MSBTYWx0ZWRfX+HJvoiYo2niB bAq1js/Is4H6Hdg4aeWRd2211NeZKijqyqGpodUPhe74utb41G+dhn0VULSEEOZcMglgCq5gZbB yhtZYJsCV9+SPrf+nbmZ3fGzluHWxWRNfJ0SDieJJl08vvBtHhENh7FlAMourvr4dWCPR286Ouf bxpu+V6sh5lhgwogkKPiNJr/ZC7jmoNk6lrA2lFKp8GCwAChxupJgmgvlqxF3RpV2XrCW3iWeQp 8T/eZA1RVp11VOdaIQQ+ZZIF6UqJNFuRFBIBIFOmMnOcrg+Fo2G8v6DRnK7BFw/i+YuMlMVerbe ND2P90hWw4tA1aq0Pio2YSUHEsamUslX3OteMpUPTmVGPyeWgp9xX8/gNdXjOsERS7tr3hbUP2c 70qEx2BnYjgJZqwTCXzuhpUrvlwok4UWN9odSjh9/v31JhlxChiMjWvIBdVEjkhkU/fizEE2DOP QPQ6rxq40P4+TZ4fJTg== X-Authority-Analysis: v=2.4 cv=Fsg1OWrq c=1 sm=1 tr=0 ts=6a33b277 cx=c_pps a=7E5Bxpl4vBhpaufnMqZlrw==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=meVymXHHAAAA:8 a=FD2fNTgVWL2COFQd-LoA:9 a=QEXdDO2ut3YA:10 a=pJ04lnu7RYOZP9TFuWaZ:22 a=2JgSa4NbpEOStq-L5dxp:22 X-Proofpoint-ORIG-GUID: v6cwvs5VVMFglaxtdrmJvwIZlbS4OzsE X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE4MDA4MSBTYWx0ZWRfX2PI3IOp2JZPd jb1pLteVKCuw8kn1H2f+/UWCkAs29xapGZGPxnF5QU58qNeiMnYryYrJ04GVpDlhZJERnqqQSdj t34VCbSBRcrK0iOb+zd26bhSdYEykm8= X-Proofpoint-GUID: v6cwvs5VVMFglaxtdrmJvwIZlbS4OzsE X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-18_01,2026-06-17_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 bulkscore=0 suspectscore=0 spamscore=0 phishscore=0 lowpriorityscore=0 malwarescore=0 adultscore=0 priorityscore=1501 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606180081 On 6/15/26 4:16 PM, Praveen Talari wrote: > The dynamic array stored in the ring buffer already carries its own > length in the array metadata. There is no need to also store it as a > separate scalar field in the entry struct. > > Drop __field(unsigned int, len) and the corresponding __entry->len > assignment, and use __get_dynamic_array_len(data) in the TP_printk for > both the len=%u format argument and the __print_hex() size argument. > This saves 4 bytes per event on the ring buffer. > > Signed-off-by: Praveen Talari > --- Suggested-by: Steven Rostedt Reviewed-by: Konrad Dybcio Konrad