From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A5A57212EF0 for ; Thu, 7 Nov 2024 14:47:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730990867; cv=none; b=ss7CzG9fr0iZSqI2QA/vQsfsxXUh7ilItJXF9I8efLs0ZkoOXyLWOXWc7n4lx2OhhBtmpsENr/h6XVkOU4mjSFCHEvJ4qniaDbaa+WjcIcjFvBtwk3+Q+vYQRE50eL3Gq0OxFnPVKwXLc976AcHkSmagTpCtj+dXteuyxs2g7Dg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730990867; c=relaxed/simple; bh=ibu2RSkOtegzXegdPneOrz9OnjOT7hzMRGrzeeSwskU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=iTTB4/TsCO2cdVDoQ5cNsiYyV/HOzazC8+7xmuRQ9nUsFpAWZp4x4ThZSVN+PtWepQbZ5he92s5NX9zEwU8bAju9mHjEfy4orB43BOGiohVyGIwYajxHyMsoPMLs6XiImg5/gpBA7C/lJ754PusoumIxt3xtGYoPpPnhPV+KAQE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=fail smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=pYsKAIp2; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="pYsKAIp2" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4A7D2YoM012968 for ; Thu, 7 Nov 2024 14:47:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= xbDNBEZF+ivxTJrlQcBDGbzMiej5Dmf5hJPNwms2OQ8=; b=pYsKAIp2GMvy17lb er+1YLkbGiRK/G+W6pw8GjSprmC0eGZ3dQtboU6D+crepbVW9SDpxS1CKf+ahq8O Mck8LaK5lJEri+ViusI+pxrUeaIolgQslr1nT2rNyeZECxkYZQlvarVztrBtgEtl pVANzNhJBDXodMVF1iRiZU/nIEwWO8tvcNj+xOph8GFceAdVeTQo1mESgQ4kq0dM aOXhrQnnXdaEMDaHu2G6S1TauWnuUoWHIy0z5Ue/3mM/10x1p7Ye7P7YDtRSm3mv BeMyiSptgYUFtJGlFHoB08NXGU7o2fluHZuSvmWgjrBlG0l/E80CcwTloHyBFOwt MotClw== Received: from mail-ua1-f70.google.com (mail-ua1-f70.google.com [209.85.222.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 42r3c1cnvu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 07 Nov 2024 14:47:44 +0000 (GMT) Received: by mail-ua1-f70.google.com with SMTP id a1e0cc1a2514c-855de9f8e7eso29442241.1 for ; Thu, 07 Nov 2024 06:47:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730990864; x=1731595664; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xbDNBEZF+ivxTJrlQcBDGbzMiej5Dmf5hJPNwms2OQ8=; b=Z5ovXk/bAZsCSY9MlnbFUQaL+4RXen6rLTtqde5sFikesC8CK5rV2wNk/6HjDTuQS0 uXQdBFV8kydr9qadwAizm5ZdK1DMIai7lrl3drpSUDr+f71EwCyyV720++ZKiFfSEVCf seZ2blM/Y0009DojHPKTAjG1A/0NSE+hWVIS6H0Cok9QJBzhcUmpx8Ppar9gvPdbQ6KE iPAbhZiG5cSp9pEMomf5fWBuAYoQLHUQiv1I8xpC7BFss7k1l4dgSO1nD9C0ZF7IrZk0 OdKuNkOEI/Jq00AJNkPs42FBdYtPGBVo96kkvAHWeO2o/OptBAaVeqHliJOoLNITeXQo GQKw== X-Forwarded-Encrypted: i=1; AJvYcCW3A+BByCSAczDDpMsIpn7TDCAqCDmqey6fPyvKATrgu0miTN25PlMmNwxmWvKgxLfsXfYldMMTe1M3gsc=@vger.kernel.org X-Gm-Message-State: AOJu0Yx3oLQZT0jo5/qua9ZXX5sxLOpxq+gEBs7hoJXthYIuctQh9mWe vI7+PKZrsSn/VNslSYqTzrBzYG4XTGY/ULg60okjsST4jL6PlUsUCyMbsHTqjfr1x4zLWds65OK 57hbKHAhwXARLaH7TiHgQnBEvc5ztBLLiOh4VlUA6TbBoMzy/uV8M0c68d7OphCs= X-Received: by 2002:a05:6102:3c94:b0:49b:ba74:f7d0 with SMTP id ada2fe7eead31-4aadebc2f6fmr164478137.4.1730990863722; Thu, 07 Nov 2024 06:47:43 -0800 (PST) X-Google-Smtp-Source: AGHT+IFFnySNUt52yfwbYGtiZv6pMalDbRXaP/F5VF0eyl6nq8yvshxs/YJIBsx+RY4YtpLEbZPyUA== X-Received: by 2002:a05:6102:3c94:b0:49b:ba74:f7d0 with SMTP id ada2fe7eead31-4aadebc2f6fmr164457137.4.1730990863224; Thu, 07 Nov 2024 06:47:43 -0800 (PST) Received: from [192.168.212.120] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9ee0a4c3f5sm103014066b.76.2024.11.07.06.47.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Nov 2024 06:47:42 -0800 (PST) Message-ID: <9bd3d4e2-aba1-423c-946a-f5c60da71497@oss.qualcomm.com> Date: Thu, 7 Nov 2024 15:47:39 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 7/7] arm64: dts: qcom: ipq5424: Add thermal zone nodes To: Manikanta Mylavarapu , Konrad Dybcio , srinivas.kandagatla@linaro.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, amitk@kernel.org, thara.gopinath@gmail.com, rafael@kernel.org, daniel.lezcano@linaro.org, rui.zhang@intel.com, lukasz.luba@arm.com, andersson@kernel.org, konradybcio@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Cc: quic_srichara@quicinc.com, quic_varada@quicinc.com References: <20241104124413.2012794-1-quic_mmanikan@quicinc.com> <20241104124413.2012794-8-quic_mmanikan@quicinc.com> <91ea0f03-9bbe-491d-9056-ebd9fdc73bfa@oss.qualcomm.com> <8cb665f5-4885-4853-804a-7313decc719c@quicinc.com> <2c7ece9d-95e8-4d01-a9da-c1d5d7388771@gmail.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: VKV-9ku855RtMNeeJXaTilBJP5ndigqp X-Proofpoint-ORIG-GUID: VKV-9ku855RtMNeeJXaTilBJP5ndigqp X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 suspectscore=0 lowpriorityscore=0 impostorscore=0 mlxlogscore=999 clxscore=1015 spamscore=0 phishscore=0 priorityscore=1501 adultscore=0 malwarescore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2409260000 definitions=main-2411070115 On 6.11.2024 11:25 AM, Manikanta Mylavarapu wrote: > > > On 11/6/2024 2:42 PM, Konrad Dybcio wrote: >> >> >> On 11/6/24 09:47, Manikanta Mylavarapu wrote: >>> >>> >>> On 11/4/2024 7:21 PM, Konrad Dybcio wrote: >>>> On 4.11.2024 1:44 PM, Manikanta Mylavarapu wrote: >>>>> Add thermal zone nodes for sensors present in IPQ5424. >>>>> >>>>> Signed-off-by: Manikanta Mylavarapu >>>>> --- >>>> [...] >>>> >>>>> + >>>>> +        cpu3-thermal { >>>>> +            polling-delay-passive = <0>; >>>>> +            polling-delay = <0>; >>>>> +            thermal-sensors = <&tsens 13>; >>>>> + >>>>> +            trips { >>>>> +                cpu-critical { >>>>> +                    temperature = <120000>; >>>>> +                    hysteresis = <9000>; >>>>> +                    type = "critical"; >>>>> +                }; >>>>> + >>>>> +                cpu-passive { >>>>> +                    temperature = <110000>; >>>>> +                    hysteresis = <9000>; >>>>> +                    type = "passive"; >>>> >>>> You have a passive trip point without passive polling >>>> >>> >>> Okay, will remove this. >> >> You most likely want to preserve it, while keeping a sensible >> polling frequency, so that userspace will be aware of the current >> CPU temperature. <100> sounds like a sensible value here. >> >> Konrad > > Temperature sensor's present in IPQ5424 supports interrupts. Correct. > Hence no need to configure polling frequency. No, that interrupt firing signifies crossing the temp threshold (meaning no updates beyond that) or the tsens watchdog barking. Konrad