From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout-p-102.mailbox.org (mout-p-102.mailbox.org [80.241.56.152]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 205733E5579; Mon, 29 Jun 2026 10:16:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=80.241.56.152 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782728174; cv=none; b=kjjnHPC6BfyFI00/jLX4OgxQmnVtcChuN8VfNZgv6UeWI/NQ0QF90aGO+Ancz55SJz4vRkY6st+ibS3lbJxjMGiRxzmOl2Ku/t6BABjtm7/rs2aVfXOlLGxvuu46iS1thKmrpsjQqokipSVHCCbvEu7Gnjd3kB7H4bbP1dru9wE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782728174; c=relaxed/simple; bh=HW+BWg1JW9BNHOp4E3b5w+CbOMquiIMjz4qFrzocohs=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=MJVOyTPk6Jl8zz+cWpS4iB2H/zhLyKqyHxbh+uIYS7jHS6rpz+Wm1HQ7rEg8KH12CRblOcBovcgUNfxHz1TER2ZzefuR5ZhrE7xGLXtmy5DRUvtB3WgFPHM9YfuIg86y/odYKDQY5OOnzL3/8WXIBUVcGqZ893noHiKVzE8O5Vk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=mailbox.org; spf=pass smtp.mailfrom=mailbox.org; dkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org header.b=jK/op6iK; arc=none smtp.client-ip=80.241.56.152 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=mailbox.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mailbox.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org header.b="jK/op6iK" Received: from smtp202.mailbox.org (smtp202.mailbox.org [10.196.197.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-102.mailbox.org (Postfix) with ESMTPS id 4gphxz4gTyz9v8L; Mon, 29 Jun 2026 12:16:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1782728167; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HW+BWg1JW9BNHOp4E3b5w+CbOMquiIMjz4qFrzocohs=; b=jK/op6iKOf1vTXFwaDd/0zgNygsmmHaCv3tMcFv5+iH3+DDblF/MSPxD75wLznpekMTSWv Lkph52uqTDvIzBN7QoROOJsWOa0bM2mNUwancglKHe4kvMs0AMBGipFw3WO6SCQ4XpP1Oz J6FRq/PVuGdEDCt4R9MR8AQkulWZpqkuSFiMRTHCT1U7ndySQz0gR/Ab1/yWTGuZqBZhE+ GlMM+rDgzf9LYeGob4ZWgqvdZDb/lwmMjjuT4UhPPlaAsFYN6Iz95DnUcFhHtT63qhytxT J5F12TJTLxeXcYfkQ3TOF4iqZWES9oywB7+vht13SmcJYV49gsGwE43V0jqEYg== Message-ID: <9bd4bd923eacca9da25b6b9fda33057455d084c3.camel@mailbox.org> Subject: Re: [PATCH] dma-fence: Make dma_fence_dedup_array() robust against 0-count input From: Philipp Stanner Reply-To: phasta@kernel.org To: Christian =?ISO-8859-1?Q?K=F6nig?= , phasta@kernel.org, Baineng Shou , Sumit Semwal Cc: Tvrtko Ursulin , Akash Goel , linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Date: Mon, 29 Jun 2026 12:16:02 +0200 In-Reply-To: <349ada65-c788-4c5e-9992-0278cf1382dd@amd.com> References: <20260629031346.3875683-1-shoubaineng@gmail.com> <058f4bb261e408cf17deca9ff7354460675eacbf.camel@mailbox.org> <66344c20-ea97-4dfa-ac42-c9d6e061eb95@amd.com> <7dc78d8ae9903c215ec492ee39b27cc504da8307.camel@mailbox.org> <349ada65-c788-4c5e-9992-0278cf1382dd@amd.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MBO-RS-ID: a61e13d958b385de307 X-MBO-RS-META: zr99d7yz1wiidqwq7p49y3w987uhfuxh On Mon, 2026-06-29 at 11:52 +0200, Christian K=C3=B6nig wrote: > On 6/29/26 11:06, Philipp Stanner wrote: > > On Mon, 2026-06-29 at 10:52 +0200, Christian K=C3=B6nig wrote: > > > On 6/29/26 10:49, Philipp Stanner wrote: > > > > >=20 > > > > > I will add a CC stable before pushing to drm-misc-fixes. > > > >=20 > > > > No offense intended or taken, but don't the DRM rules say that > > > > things > > > > do not get merged while there are outstanding concerns or > > > > significant > > > > points in review feedback? > > >=20 > > > I haven't seen that before writing the response. > > >=20 > > > I usually go over my mails till the end and wait a couple of > > > hours before pushing anything. > > >=20 > > > > What about my comments? > > >=20 > > > Looks valid to me as well, but I think that is a separate issue. > >=20 > > But if we keep it an integer for now, and if that check is added, > > and > > it most certainly should also catch negative integers, shouldn't > > it? >=20 > Maybe with a WARN_ON(), but not as regular code path. >=20 > The thing is I think we need to backport this fix to stable kernels, > but switching from signed to unsigned is only a minor cleanup when no > real users are currently affected. Fine by me. P.