From: Romain Gantois <romain.gantois@bootlin.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "Romain Gantois" <romain.gantois@bootlin.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Magnus Damm" <magnus.damm@gmail.com>,
"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
"Jose Abreu" <joabreu@synopsys.com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Russell King" <linux@armlinux.org.uk>,
"Clément Léger" <clement.leger@bootlin.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net-next v2 4/5] net: stmmac: add support for RZ/N1 GMAC
Date: Wed, 10 Apr 2024 14:25:18 +0200 (CEST) [thread overview]
Message-ID: <9bd8eee4-952d-d5b2-c462-45c1466c54d6@bootlin.com> (raw)
In-Reply-To: <CAMuHMdX-F8LXWx=Ras4f+Dt_r485HKjRDLydDXZsnZBW8HJzxw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 810 bytes --]
Hi Geert,
On Tue, 9 Apr 2024, Geert Uytterhoeven wrote:
> > +config DWMAC_RZN1
> > + tristate "Renesas RZ/N1 dwmac support"
> > + default ARCH_RZN1
>
> Why default to enabled?
>
> > + depends on OF && (ARCH_RZN1 || COMPILE_TEST)
The kernel doc states this as one of the possible cases where setting default
y/m makes sense:
```
Sub-driver behavior or similar options for a driver that is “default n”. This
allows you to provide sane defaults.
```
In the case of DWMAC_RZN1, it is a suboption of stmmac which is "default n", and
I think it makes sense to enable the RZN1 ethernet controller driver if both the
stmmac driver and the RZN1 architecture were explicitely selected.
Best Regards,
--
Romain Gantois, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2024-04-10 12:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-09 9:21 [PATCH net-next v2 0/5] net: stmmac: Add support for RZN1 GMAC devices Romain Gantois
2024-04-09 9:21 ` [PATCH net-next v2 1/5] dt-bindings: net: renesas,rzn1-gmac: Document RZ/N1 GMAC support Romain Gantois
2024-04-10 18:58 ` Rob Herring
2024-04-09 9:21 ` [PATCH net-next v2 2/5] net: stmmac: introduce pcs_init/pcs_exit stmmac operations Romain Gantois
2024-04-09 9:21 ` [PATCH net-next v2 3/5] net: stmmac: dwmac-socfpga: use pcs_init/pcs_exit Romain Gantois
2024-04-10 1:34 ` Jakub Kicinski
2024-04-10 19:19 ` Russell King (Oracle)
2024-04-11 6:49 ` Romain Gantois
2024-04-09 9:21 ` [PATCH net-next v2 4/5] net: stmmac: add support for RZ/N1 GMAC Romain Gantois
2024-04-09 15:27 ` Geert Uytterhoeven
2024-04-10 12:25 ` Romain Gantois [this message]
2024-04-11 7:45 ` Geert Uytterhoeven
2024-04-09 9:21 ` [PATCH net-next v2 5/5] ARM: dts: r9a06g032: describe GMAC1 Romain Gantois
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9bd8eee4-952d-d5b2-c462-45c1466c54d6@bootlin.com \
--to=romain.gantois@bootlin.com \
--cc=alexandre.torgue@foss.st.com \
--cc=clement.leger@bootlin.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=joabreu@synopsys.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux@armlinux.org.uk \
--cc=magnus.damm@gmail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®