From: "Shah, Tanmay" <tanmays@amd.com>
To: Tanmay Shah <tanmay.shah@amd.com>, <andersson@kernel.org>,
<mathieu.poirier@linaro.org>
Cc: <linux-remoteproc@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] remoteproc: xlnx: do not send new mailbox notification
Date: Wed, 11 Mar 2026 14:43:46 -0500 [thread overview]
Message-ID: <9bd9b628-7af4-47fe-9c83-ef9a9220f6ea@amd.com> (raw)
In-Reply-To: <20260219224329.3475032-1-tanmay.shah@amd.com>
Hi Mathieu,
On 2/19/2026 4:43 PM, Tanmay Shah wrote:
> Only write a new message to the tx mbox queue if slot is available in
> the tx queue. If queue is full, then do not send new mbox notification.
>
> Signed-off-by: Tanmay Shah <tanmay.shah@amd.com>
> ---
>
> Depends on: https://lore.kernel.org/linux-remoteproc/20260209234430.512492-1-jassisinghbrar@gmail.com/T/#u
>
This dependency is now merged in the linux-next branch.
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/drivers/mailbox?id=57df858a46f0a4cc104716e0ec88864e5c386ca4
I don't know what's the process, but can we merge this patch and
dependency both in the for-next branch?
Thanks,
Tanmay
> drivers/remoteproc/xlnx_r5_remoteproc.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/remoteproc/xlnx_r5_remoteproc.c b/drivers/remoteproc/xlnx_r5_remoteproc.c
> index bd619a6c42aa..622de733c929 100644
> --- a/drivers/remoteproc/xlnx_r5_remoteproc.c
> +++ b/drivers/remoteproc/xlnx_r5_remoteproc.c
> @@ -332,7 +332,10 @@ static void zynqmp_r5_rproc_kick(struct rproc *rproc, int vqid)
> int ret;
>
> ipi = r5_core->ipi;
> - if (!ipi)
> + if (!ipi || !ipi->tx_chan)
> + return;
> +
> + if (mbox_chan_tx_slots_available(ipi->tx_chan) == 0)
> return;
>
> mb_msg = (struct zynqmp_ipi_message *)ipi->tx_mc_buf;
>
> base-commit: 462799c088e71b2b8a511c2a9649420fcb569ab7
next prev parent reply other threads:[~2026-03-11 19:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-19 22:43 Tanmay Shah
2026-03-11 19:43 ` Shah, Tanmay [this message]
2026-03-16 15:18 ` Mathieu Poirier
2026-03-16 16:29 ` Shah, Tanmay
2026-03-17 15:14 ` Mathieu Poirier
2026-03-17 16:17 ` Shah, Tanmay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9bd9b628-7af4-47fe-9c83-ef9a9220f6ea@amd.com \
--to=tanmays@amd.com \
--cc=andersson@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=tanmay.shah@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®