mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ping-Ke Shih <pkshih@realtek.com>
To: Hungyu Lin <dennylin0707@gmail.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"reza1234khan1234@gmail.com" <reza1234khan1234@gmail.com>
Subject: RE: [PATCH] wifi: rtw88: allow key removal when the CAM table is full
Date: Tue, 20 Oct 2026 02:07:39 +0000	[thread overview]
Message-ID: <9bde49a2e7794e4fb6bc3ae104eef87e@realtek.com> (raw)
In-Reply-To: <20261019165103.5990-1-dennylin0707@gmail.com>


Hungyu Lin <dennylin0707@gmail.com> wrote:
> rtw_ops_set_key() looks for a free CAM entry before checking the
> command. When all pairwise entries are in use, DISABLE_KEY returns
> -ENOSPC without clearing the existing entry.

Is this the actual case you met?

> 
> Move the allocation and bounds check into SET_KEY. DISABLE_KEY uses
> the existing key->hw_key_idx.
> 
> Fixes: 10d58823cb44 ("wifi: rtw88: fix out-of-bounds CAM write when key table is full")

Should it be ?

Fixes: e3037485c68e ("rtw88: new Realtek 802.11ac driver")

> Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>

Then, 

Acked-by: Ping-Ke Shih <pkshih@realtek.com>




  parent reply	other threads:[~2026-10-20  2:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-19 16:51 Hungyu Lin
2026-10-19 19:01 ` Luka Gejak
2026-10-20  2:07 ` Ping-Ke Shih [this message]
2026-10-20  4:43   ` Luka Gejak
2026-10-20  5:29     ` Ping-Ke Shih

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9bde49a2e7794e4fb6bc3ae104eef87e@realtek.com \
    --to=pkshih@realtek.com \
    --cc=dennylin0707@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=reza1234khan1234@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®