From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24A2614D2BD for ; Tue, 14 Jan 2025 14:51:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736866278; cv=none; b=Fkq1yxqY+HfOcbMawkhn5hyAHCRB67Cw4ip6O1YBuRpP/kO+btOBQmJwYIGo1HWm6O7XHqXvUaJrvgwTRnwlWWKLY1E1H6EPiz3v0maJOH3wJiFtIMBPd4/LUyp+kSr2hJ4b39LY/nrojesAzSDBLrMGIdwJ+MtuEQ6+q21Y6oU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736866278; c=relaxed/simple; bh=JbOAtelmJcbWUE7Ixh33K3ATanb//ICHOjpdXdNz9mM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=AbvxLFqIuv2SI7oRhc7/AqYXuvUbu5eJJ/+bx8RMWqZk8y01sMTPSSgzriaDmeXroSGrYVVn0oOYKHgHD9L6GUzVfEqCnRA/x2tXESlA+uOjrbGgaYbsAhoxDR5fLIH40bZ3bSgzmLjrDYt0sLBi6ccgk7LaBTJiGkpl9OCyitc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Pe6O64TA; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Pe6O64TA" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736866276; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=frCMXuewTKaMxoSv5HkrB79R79VgidnpZu3s0YCdJnw=; b=Pe6O64TAiyXRzO3JHRI9A/JmvDvgsDZ/qroMHXsYbmmloK9cFbk9ePnJdsUtQBnHzX0frJ IZsNMbmSWNDZ8pg8jLqW52HqqsClhizBI+9c+jxkXZyoFbcLTYsXHCKEuwicWDaIzVedot nsglb4lg6+j1lWefmtVErF3IXDB4ARc= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-490-w799t0njPXK6LYrwf-HqnA-1; Tue, 14 Jan 2025 09:51:13 -0500 X-MC-Unique: w799t0njPXK6LYrwf-HqnA-1 X-Mimecast-MFC-AGG-ID: w799t0njPXK6LYrwf-HqnA Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-43628594d34so31299805e9.2 for ; Tue, 14 Jan 2025 06:51:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736866272; x=1737471072; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=frCMXuewTKaMxoSv5HkrB79R79VgidnpZu3s0YCdJnw=; b=CBl2X/aJzATtrwf1jFiJP8QB4hSz2EbD+n2TRYLoUpKnJ6BEqs/AaZAHgBP1TnXlo5 Z8V8+oZVSIWu2CGjIzxVIYc+FSjr/j5HzT/WOVBibNLGLUvM01O8iYnCpLmQoLIMs92i ci7FTBMIy6YQT8/7DwPV2V5KlAXFvMUByJBAGNCzLlwG1h+GSJeQp0SAm/u3bkquwow7 SmD6ruGeEH8DhG64vv7eCpO6vW8IcWMRs+Il3DLK3XoBjdatg4lgbVU+Aw1Q72DgZe8n 42GZvvmneCcxYX1z+VVDozcMJWq3my4Z5QgQ4hVNh2GnQ6LLab/14o3/hoO5DGCtmaqd sGrA== X-Forwarded-Encrypted: i=1; AJvYcCVlWbPrktO1ldZ9UvJpCBHxRhoKm+TQBnHpbCJrJNIHn1MtCEC4S+9kuJdKrMkbqxYpa0fM0Z5dxXO2nfo=@vger.kernel.org X-Gm-Message-State: AOJu0YxzSHxYsDb9xpa3P/ZpAAwaCnYR9VOlNAmGR5KIWZWme5PBi7eR FTQmws/wIHYP3ZIGm57Fq4ghMfSUSXDvhRsgl19Nl/ZgWfGi39vRLXs+e70Brck0QehKSifSIhG r06wGAjEmRoCINKfo+O0FTflGR4WmM2ae4F3Z3ZMdKkrH/xVEG3XKvw402C9vnQ== X-Gm-Gg: ASbGnctwFdhmnjzp7AoziIudeOqvN9HVkInnBCancz8PZsuuwFKo1V/RBIbmOiGxQqN 1Hp+LagBmPHFG0m6rbLduMpjFZvGpHOV/QcGNRbpp9lR/GPwPE7qz77Ofo3Sbo8s/VVMMAs5VbP sGqpVvSiTIuAnNMWQboFfmqS8BXx6BhMLuUtXVCBQb5jPX3lBOB73BDN4eeGdDeK0W7ReH7NtMQ 8iYaiBLZDQGiYKsoTAh769tC9intVy9AXvIz3K666Aa1mXf1E/MsOXV0jnFoELi4xNHrPEWHtX5 VsKcXduBTiFPkU9WckMQrQBZnkDS6fwwJlaUPIid92a+Qni+AyNZz3BDOvQ7FGU+2MsEcJjZVTS h5fJga8g/ X-Received: by 2002:a05:6000:18a2:b0:382:49f9:74bb with SMTP id ffacd0b85a97d-38a872f3202mr24489631f8f.35.1736866272079; Tue, 14 Jan 2025 06:51:12 -0800 (PST) X-Google-Smtp-Source: AGHT+IE7GJ1+W/uNTlLNM/+qMUx1r19EPlEDmBQ7z7UMM/B1+0DtBI15xOV7jFVV7enwVcHppl6EyQ== X-Received: by 2002:a05:6000:18a2:b0:382:49f9:74bb with SMTP id ffacd0b85a97d-38a872f3202mr24489568f8f.35.1736866271639; Tue, 14 Jan 2025 06:51:11 -0800 (PST) Received: from ?IPV6:2003:cb:c738:3100:8133:26cf:7877:94aa? (p200300cbc7383100813326cf787794aa.dip0.t-ipconnect.de. [2003:cb:c738:3100:8133:26cf:7877:94aa]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a8e38c6dbsm15361588f8f.55.2025.01.14.06.51.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Jan 2025 06:51:11 -0800 (PST) Message-ID: <9be14739-82cc-42fb-bb38-a868231cdda6@redhat.com> Date: Tue, 14 Jan 2025 15:51:09 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 10/26] mm/mm_init: Move p2pdma page refcount initialisation to p2pdma To: Alistair Popple , akpm@linux-foundation.org, dan.j.williams@intel.com, linux-mm@kvack.org Cc: alison.schofield@intel.com, lina@asahilina.net, zhang.lyra@gmail.com, gerald.schaefer@linux.ibm.com, vishal.l.verma@intel.com, dave.jiang@intel.com, logang@deltatee.com, bhelgaas@google.com, jack@suse.cz, jgg@ziepe.ca, catalin.marinas@arm.com, will@kernel.org, mpe@ellerman.id.au, npiggin@gmail.com, dave.hansen@linux.intel.com, ira.weiny@intel.com, willy@infradead.org, djwong@kernel.org, tytso@mit.edu, linmiaohe@huawei.com, peterx@redhat.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, jhubbard@nvidia.com, hch@lst.de, david@fromorbit.com, chenhuacai@kernel.org, kernel@xen0n.name, loongarch@lists.linux.dev References: <4f3fa1bb9cf4402d6131d0902472d8e9bae52f88.1736488799.git-series.apopple@nvidia.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <4f3fa1bb9cf4402d6131d0902472d8e9bae52f88.1736488799.git-series.apopple@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10.01.25 07:00, Alistair Popple wrote: > Currently ZONE_DEVICE page reference counts are initialised by core > memory management code in __init_zone_device_page() as part of the > memremap() call which driver modules make to obtain ZONE_DEVICE > pages. This initialises page refcounts to 1 before returning them to > the driver. > > This was presumably done because it drivers had a reference of sorts > on the page. It also ensured the page could always be mapped with > vm_insert_page() for example and would never get freed (ie. have a > zero refcount), freeing drivers of manipulating page reference counts. > > However it complicates figuring out whether or not a page is free from > the mm perspective because it is no longer possible to just look at > the refcount. Instead the page type must be known and if GUP is used a > secondary pgmap reference is also sometimes needed. > > To simplify this it is desirable to remove the page reference count > for the driver, so core mm can just use the refcount without having to > account for page type or do other types of tracking. This is possible > because drivers can always assume the page is valid as core kernel > will never offline or remove the struct page. > > This means it is now up to drivers to initialise the page refcount as > required. P2PDMA uses vm_insert_page() to map the page, and that > requires a non-zero reference count when initialising the page so set > that when the page is first mapped. > > Signed-off-by: Alistair Popple > Reviewed-by: Dan Williams > LGTM Acked-by: David Hildenbrand -- Cheers, David / dhildenb