From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E2D45C2EA for ; Wed, 1 Jul 2026 11:08:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782904095; cv=none; b=TKCp7EsczISnB40Up2tfZsN+dJL4i3/RxPDsYySkbjNBzCu1ddkYlddV8AV2WY2Mq6OpcFxZy7n68BNfd0UyPCbbfhwdrEsEmsRa4L0vqNYDIwD6/VCenGtEZ/Jan7wEqTZ1Dd8XqI3v8WmRWIRN8bmqQ3r85KLU0KzpBrTN6e4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782904095; c=relaxed/simple; bh=KSQIz1fNUhB2X/hNtVqkCE+xnBUwd8Iva20T8hHTVsk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pK7YkW73nhBn6tCP+v7rddVXF2CAzTI/Bb1q/6RyCClylC+AH7wH/W6JC5NXds2SwnWLRF4evpAzkDf2+o8zMzPwElw2wKeVdO/tfPxGvteOeBGgDgZkDBYXGfy1y5ujGiSGAfpZX1O9A4ww72vsPSe05iDz4iASdKfvFXpSlmU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=YWxLfVhS; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=keccVJbi; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=YWxLfVhS; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=keccVJbi; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="YWxLfVhS"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="keccVJbi"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="YWxLfVhS"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="keccVJbi" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id AF24B75B80; Wed, 1 Jul 2026 11:08:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1782904090; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=I+W01JOsngTzL+rKSPgK1XPvUG8PHglRzJrrMSkzbPc=; b=YWxLfVhS7ZP67BmU3uQ2r6ERwWCsgfWAX06Zh2ZMDRt90ckTVnMl+0nma/GCHHIY6coDNg 3puOjsDaJxfaaWYDOKGL+ZF0DhrQu6ci2XiqN4NfsAWVYT4wetLTwDIU6/xYgBJ+WVc30n /r43VMjsNu+DFpLhek3e8AagRMIACoc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1782904090; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=I+W01JOsngTzL+rKSPgK1XPvUG8PHglRzJrrMSkzbPc=; b=keccVJbifdqwoVAsHojtwJSH3p+kDj+122DDhkDIxvNNUVH8f51KVSI72b79Vuuf81MSfH c8VKdiqtmBk71YCw== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=YWxLfVhS; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=keccVJbi DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1782904090; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=I+W01JOsngTzL+rKSPgK1XPvUG8PHglRzJrrMSkzbPc=; b=YWxLfVhS7ZP67BmU3uQ2r6ERwWCsgfWAX06Zh2ZMDRt90ckTVnMl+0nma/GCHHIY6coDNg 3puOjsDaJxfaaWYDOKGL+ZF0DhrQu6ci2XiqN4NfsAWVYT4wetLTwDIU6/xYgBJ+WVc30n /r43VMjsNu+DFpLhek3e8AagRMIACoc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1782904090; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=I+W01JOsngTzL+rKSPgK1XPvUG8PHglRzJrrMSkzbPc=; b=keccVJbifdqwoVAsHojtwJSH3p+kDj+122DDhkDIxvNNUVH8f51KVSI72b79Vuuf81MSfH c8VKdiqtmBk71YCw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 55AB2779AA; Wed, 1 Jul 2026 11:08:10 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 4WoEExr1RGoreAAAD6G6ig (envelope-from ); Wed, 01 Jul 2026 11:08:10 +0000 Message-ID: <9be94be1-2831-4973-b571-47bcd1c023aa@suse.de> Date: Wed, 1 Jul 2026 13:08:09 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 0/2] nvme-rdma: parallelize I/O queue setup To: Surabhi Gogte , Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, mkhalfella@purestorage.com, randyj@purestorage.com, adailey@purestorage.com References: <20260625212722.1302344-1-sgogte@purestorage.com> Content-Language: en-US From: Hannes Reinecke In-Reply-To: <20260625212722.1302344-1-sgogte@purestorage.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Action: no action X-Rspamd-Queue-Id: AF24B75B80 X-Spam-Flag: NO X-Spam-Score: -4.51 X-Spam-Level: X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_TLS_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; MID_RHS_MATCH_FROM(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_SEVEN(0.00)[10]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:email,suse.de:mid,imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org On 6/25/26 11:27 PM, Surabhi Gogte wrote: > This patch series parallelizes nvme-rdma connection and reconnection by > setting up I/O queues in parallel instead of sequentially. Allocation and > startup of each queue are combined into a single per-queue async work > item, so per-queue connection latency overlaps across all queues. This > matters most on high-core-count hosts with many I/O queues, where serial > setup dominates connect time. > > Patch 1 is a preparatory refactor: nvme_rdma_alloc_queue() takes a queue > pointer so allocation and startup can be folded into a single async > worker. > > Patch 2 contains the implementation for async setup of I/O queues. > > Testing on a 64-core host with 64 I/O queues shows nvme-rdma connection > time reduced from ~1.4s to 416ms. > > Signed-off-by: Surabhi Gogte > --- > Changes from v2->v3: > - Split the series into two patches: extract the nvme_rdma_alloc_queue() > refactor into a separate preparatory patch. > - Replace the atomic error flag in struct nvme_rdma_ctrl with a per-work > nvme_rdma_setup_ctx { queue, err } struct. > - Fix formatting changes regarding line overflow indentation and nesting. > > Changes from v1->v2: > - Remove separate workqueue and use the async API instead. > > Previous versions: > v1: https://lore.kernel.org/all/20260529001354.1003640-1-sgogte@purestorage.com/ > v2: https://lore.kernel.org/all/20260604195321.2232838-1-sgogte@purestorage.com/ > > Surabhi Gogte (2): > nvme-rdma: refactor nvme_rdma_alloc_queue() to take a queue pointer > nvme-rdma: parallelize I/O queue allocation and startup > > drivers/nvme/host/rdma.c | 135 ++++++++++++++++++++++++--------------- > 1 file changed, 82 insertions(+), 53 deletions(-) > I would think that the same argument holds for nvme-tcp as the drivers are pretty similar. Can you update nvme-tcp, too, to take advantage of parallel I/O queue setup? Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich