From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96A89437872 for ; Wed, 8 Jul 2026 11:59:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783511997; cv=none; b=m+a+tOgutfduvOM+KXcytAtNKHOXQlS1JeGBATA3UdpnqYeOMPnfTOdHhsjZpUtf43IecFQwJuE6b0TKFewanogrj012aK3kk31CGPx43PuopuCTDLOLdRQG5FJrqDtMlE2kWjLE2cj1IwAmmWOvv7rLU4fqp3aayvpTNsH3urQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783511997; c=relaxed/simple; bh=C/m2/DbdCHnrhUblL9Kivv0lGj6MVoPArDQSKZ+UMn4=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=j+kNr5A8LnS+AHQBhBtB+T0wuZJQPvJsqfjT+p+7SYuB16HPdjhaa4QcGwGhzTCJfmhRjm6iviQhB03jxBO0PtXe8R7tE5YEOztSIStyIKRedNl2ufa8LuooJO8RfmEmtayRKr1VMCqjbwmr2t4UbfJrIRdl67NnDmK3TCbCXRo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=LqvCUEx5; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=PpkH4SzX; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="LqvCUEx5"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="PpkH4SzX" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 668BT0dB2637774 for ; Wed, 8 Jul 2026 11:59:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= TcJSnD72t3bjrI67zk7M3+keJ/xu3I6eDgTZ0AvcGpE=; b=LqvCUEx5cZNuz+bM 1++j4xfPGr7Ff9+DdMQ6+EoQM08KPMo1uWoC06Sh32SRnqvgrrcjPeh4ZYN2PdKL xMYEmx26D1DepoIlUCr3hQ5NArAA4vGF+HRXiO7Fl0TGpXqPXN2MuDALmPOgTCda 0QJQWPvqThMvMcRcWXcHsp7uMl9Y8wuQibRXJ1GtL8l81qr9G85oaIGFCX1Mc82S 6fW9PwUCxn+9yd8AEsIg+YBGYDBhkNH5LOgoyqQpb4Bfrr7Jm7AyQ0pboPTn70Is /Q0VED095sS5hmNXQuc1wv84xKAe3qOOmg9n+djGK9DJvS4t/pZyfMWDBeiw2Cc6 SQjZ5g== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f95fd49ux-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 08 Jul 2026 11:59:55 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2c804e38c65so15914405ad.2 for ; Wed, 08 Jul 2026 04:59:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783511995; x=1784116795; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=TcJSnD72t3bjrI67zk7M3+keJ/xu3I6eDgTZ0AvcGpE=; b=PpkH4SzXWaTAbADt0MZmtTXI/ggxl60DvHx4mhjHgOSTLDGHg9C/VH42KARY17qeJ9 J4/0aYcv3EF0f4z4rnbdXRlg3UkRyOR5420g9GphBK+r4B+uzEiEpT98O8hBrDB6g93L XrIgycFFKP60OP4J7ESaM5KwBXxspGt+mbydAuAJaxMxvLbqYkepx2ZSq5I5Ml+62DW9 Ep3fUvECWFFwtFL+02NFXzQnICzNxarh2El3V3/Vh1AHATzGPenewBrWGY2yukfxhPKM b94tX3VmotIlm3pAmNmmbjlV82PqbHPlZoPZuYJ6uW6EMAp+01ZsQZS2HinYhd8NWddm UAZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783511995; x=1784116795; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=TcJSnD72t3bjrI67zk7M3+keJ/xu3I6eDgTZ0AvcGpE=; b=eE0VwJ6JWAc7ULEREVu1aFaddfX4mbHJ1weXV+3Q16LtrLLmhW9cJCzM4jC7wjDG7H 78hYtrjJzf7ff3L2DN0geh30k/mcWYjTo+wQvxR6Y7Sa/NCmOtWDLf0sqXYTBzjzR+Qg UJdfUrTE8syUvdqrUoNp+0bzECuJE0VJ7Om4lUxZRD/rzke8i59ZCufgJqAYUzZCzLB+ FiugtPSuD4mafp2auAyhtuvlRAJ1x2j1KO2yLmrSMhyKuNBrS7CBgFLpm1CAqE4Mdnun yvTX8iiu13VpyX4O5/LQOB3yBxGLzWSfanU6Q/F4J0GcoJOgdkJ1lkST8Fm0Gxgzdmc5 +1uQ== X-Forwarded-Encrypted: i=1; AHgh+RoDie8hYJAeDWgzVsp+1Qobrk4KoPhZxe7NNfa1xRRwRHduqLsj/+CB2M7h7+xZYYScYYGvpf25i4tRR0U=@vger.kernel.org X-Gm-Message-State: AOJu0YzOqJgR0FvGuZoZUcDEqqhserSQIAzIs7VX8k6DL0ydoF0VEeRd quL38VcyEYpxNclUu2RYISeRH54nv/kVWFJHP2Pb7Yed3MuhnHJVmf7vCyR/qBkdz0ZlemuarVN +S0JabmbkT0RuKYF/2WrixLlFMF8Ur5XrYVXrtpPQh5eQaPXl6GPMUJ7XhxuozzBUPe0= X-Gm-Gg: AfdE7cl7wGrqa85yMzCma6zZ+hdzmHteCan7lv1BfWBhe/v4ojLBX1H3OHbITFUzzmS OTWsA1TGVUksa67R1nqMsMaKQctTW72dsTReM/6KB3ZyxUtqLKIBHb7iH27uykZHOfNSILbQnTV 7kHCor+JsUF0Hb6BOBqMZnBw02OEKBBk4xTnb+5h/butAHK3caoSlKkzR0ubYwd0SBZSbvbMXKZ g8mDoJslH+vUuOCWNJvrht5C/pgElldqGMHMyIZM9H/4gonlpstADjuhpZ5Dnt+CWLhXAtvVdnM 0ckfi5ohCN/qYI0WJQ/yK7NHLe1vNuQADgq86ehztLaTJZOFKe2fDl2FO/DzAMT+fsud7MS9z3k dJDUAMJQ4YE0IYXcz0x/G/MeYkmqZEpWgpmc11POfz43qZGxXBn6/KSufyp8C4Q== X-Received: by 2002:a17:902:fda5:b0:2c9:cb1b:64d6 with SMTP id d9443c01a7336-2ccea3a8001mr21827905ad.19.1783511994566; Wed, 08 Jul 2026 04:59:54 -0700 (PDT) X-Received: by 2002:a17:902:fda5:b0:2c9:cb1b:64d6 with SMTP id d9443c01a7336-2ccea3a8001mr21827515ad.19.1783511994089; Wed, 08 Jul 2026 04:59:54 -0700 (PDT) Received: from [10.168.91.130] ([223.185.219.139]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ccc9bdb7e9sm27836995ad.10.2026.07.08.04.59.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Jul 2026 04:59:53 -0700 (PDT) Message-ID: <9bea0cef-e6c5-4810-8b79-f90ac731906d@oss.qualcomm.com> Date: Wed, 8 Jul 2026 17:29:49 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] wifi: ath12k: release QMI handle on late init failures To: Guangshuo Li , Jeff Johnson , Baochen Qiang , linux-wireless@vger.kernel.org, ath12k@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260708100924.744386-1-lgs201920130244@gmail.com> Content-Language: en-US From: Vasanthakumar Thiagarajan In-Reply-To: <20260708100924.744386-1-lgs201920130244@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA4MDExNiBTYWx0ZWRfX6hOu0ISbNUzc Mt1FCSCv5K6GMAS+gHCHEZwKFibn/Yu/eTfZVw4kAUHcb4e21YKcgL1cQC6EoMQ/sggkCYQf78E dwTr1/dRburpGIaGyJbjb+GMKTFttglxGgCRqARFvbyno/q49o2WrvQ4IjhHGLQtc7a/c/0j2X8 tRQdDtzPDiDYCrKU4ilnV+11XtfLL6Ag6+/jsQE9B9w5rQA3Sqd6nKA31AcCaZxvDpcWHq1tSOK 7pMktZLzS6gr8yaFH50XKpJXmcH2Kx4BA+SNn5M42iTd92ZFrVYOeoEcmtQvg25HUiLoqggaZB9 wjZ6BNeLEQxu8/q+oXzIrZu+V0oT+hSuu4K9DerU5QVZt1Civr600oudABnFsx1No2CR2MUqLKF raFY5uNvlgEt7wGL5XgRDeNHQkHGbwMBcShtWj4lJ1FRB081GOJ53Lwp4oXU1Rsmq1s4IKIzaJU lBd4e9lsjcP7MoJRy2Q== X-Authority-Analysis: v=2.4 cv=VZLH+lp9 c=1 sm=1 tr=0 ts=6a4e3bbb cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=ziM92C7oNnnlFgKtw0sKeA==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=pGLkceISAAAA:8 a=EUspDBNiAAAA:8 a=JK7btWPRm8zbeGui-XMA:9 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-ORIG-GUID: cxJewRar6VceaVXSgWaMTSQzU7UWLkB0 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA4MDExNiBTYWx0ZWRfX4IZ3LG13RVIT Bp0yAvc8ANwLlJV5g8i7mFNYwY5WO3y00P1qlSu1Sie9iJAYs0VBfxovf0wcsxpCaq1thzeZD1+ ARn8ToQdF4xjh9NaI8h9q8NQeIYk08c= X-Proofpoint-GUID: cxJewRar6VceaVXSgWaMTSQzU7UWLkB0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-08_01,2026-07-08_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 bulkscore=0 priorityscore=1501 suspectscore=0 lowpriorityscore=0 spamscore=0 malwarescore=0 adultscore=0 clxscore=1015 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607080116 On 7/8/2026 3:39 PM, Guangshuo Li wrote: > The change referenced by the Fixes tag makes hardware group creation > skip the device whose ath12k_core_soc_create() failed, and only destroys > devices that were created successfully before it. > > That avoids releasing an uninitialized QMI handle when qmi_handle_init() > fails, but it also means that ath12k_qmi_init_service() must clean up any > resources it has already acquired before returning an error. > > qmi_handle_init() can succeed before later initialization steps fail. If > the QMI event workqueue allocation fails, or qmi_add_lookup() fails, the > function returns an error without releasing the already initialized QMI > handle. Since the failed device is now skipped by the hardware group > rollback path, that handle is leaked. > > Release the QMI handle on those late failure paths and clear ab->qmi.ab > so the failed device is left in the same state as the qmi_handle_init() > failure path. > > Fixes: 088a099690e4 ("wifi: ath12k: fix error handling in creating hardware group") > Signed-off-by: Guangshuo Li Reviewed-by: Vasanthakumar Thiagarajan btw, similar leak may be there in ath11k also, care to fix that as well?