From: Michael Riesch <michael.riesch@collabora.com>
To: Aleksandr Chubuchnyi <chubuchnyi@gmail.com>,
sakari.ailus@linux.intel.com, laurent.pinchart@ideasonboard.com,
mchehab@kernel.org, mani@kernel.org,
jacopo.mondi@ideasonboard.com, nicholas@rothemail.net,
benjamin.mugnier@foss.st.com, sylvain.petinot@foss.st.com
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH 2/5] media: i2c: imx415: Add missing v4l2_subdev_cleanup() call
Date: Fri, 18 Sep 2026 23:30:47 +0200 [thread overview]
Message-ID: <9bf16301-ab58-4d55-bd32-b807bef1f53b@collabora.com> (raw)
In-Reply-To: <6a7bc243c8cab077de57fc9c3d6a3d005c110f64.1788940469.git.chubuchnyi@gmail.com>
Hi Aleksandr,
Thanks for the patch, LGTM!
On 9/9/26 10:02, Aleksandr Chubuchnyi wrote:
> The subdev active state allocated by v4l2_subdev_init_finalize() is leaked
> on unbind.
>
> Fixes: 14cd15e7a1e2 ("media: i2c: add imx415 cmos image sensor driver")
> Cc: stable@vger.kernel.org
> Signed-off-by: Aleksandr Chubuchnyi <chubuchnyi@gmail.com>
Reviewed-by: Michael Riesch <michael.riesch@collabora.com>
Best regards,
Michael
> ---
> drivers/media/i2c/imx415.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/i2c/imx415.c b/drivers/media/i2c/imx415.c
> index c3b22b238..12c2f3df6 100644
> --- a/drivers/media/i2c/imx415.c
> +++ b/drivers/media/i2c/imx415.c
> @@ -1125,6 +1125,7 @@ static int imx415_subdev_init(struct imx415 *sensor)
>
> static void imx415_subdev_cleanup(struct imx415 *sensor)
> {
> + v4l2_subdev_cleanup(&sensor->subdev);
> media_entity_cleanup(&sensor->subdev.entity);
> v4l2_ctrl_handler_free(&sensor->ctrls);
> }
next prev parent reply other threads:[~2026-09-18 21:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-09 8:02 [PATCH 0/5] media: i2c: Add missing v4l2_subdev_cleanup() calls Aleksandr Chubuchnyi
2026-09-09 8:02 ` [PATCH 1/5] media: i2c: imx296: Add missing v4l2_subdev_cleanup() call Aleksandr Chubuchnyi
2026-09-09 8:02 ` [PATCH 2/5] media: i2c: imx415: " Aleksandr Chubuchnyi
2026-09-18 21:30 ` Michael Riesch [this message]
2026-09-09 8:02 ` [PATCH 3/5] media: i2c: mt9m114: Add missing v4l2_subdev_cleanup() calls Aleksandr Chubuchnyi
2026-09-09 8:02 ` [PATCH 4/5] media: i2c: ov8858: Add missing v4l2_subdev_cleanup() call Aleksandr Chubuchnyi
2026-09-09 8:02 ` [PATCH 5/5] media: i2c: st-mipid02: " Aleksandr Chubuchnyi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9bf16301-ab58-4d55-bd32-b807bef1f53b@collabora.com \
--to=michael.riesch@collabora.com \
--cc=benjamin.mugnier@foss.st.com \
--cc=chubuchnyi@gmail.com \
--cc=jacopo.mondi@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mani@kernel.org \
--cc=mchehab@kernel.org \
--cc=nicholas@rothemail.net \
--cc=sakari.ailus@linux.intel.com \
--cc=stable@vger.kernel.org \
--cc=sylvain.petinot@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®