From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E09F02D2398 for ; Fri, 25 Jul 2025 09:40:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753436438; cv=none; b=V/AHarG9U9hQxbKp3oYwCKkLsIa1DDEMnFW8e/+r/eki2zN02ayU+0kVVaXGTjp9cK4gCYtM0Tj914hQv1Tvf8wsI10aOZhwyC1jUdAePw/2PX0tJoQCRVN356jASN7s39fsokGTYW84pTmSBs6NcZyVB25anGkFfAgj34Zd8yg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753436438; c=relaxed/simple; bh=P1J3icjYc/2BNbZQCJB5BZ80qJIDCLFPNqRomdxH39I=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=fRv3d29kYf9qLJDKgnXik/YpRZAQxiT32HOOym7uaQq11wP9/K0Z8FWorsx+ELg5P5os3Rf1DHSpFumZG7c5X4nVM1XGqEvphBi7uJPFj+WW24kiBwruTv1gNsgu20SpNhL6RFF/FbCxewB9KEPUMy6BTIjMjSVnmTQQTAU690w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=BWtgYzlZ; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="BWtgYzlZ" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4561514c7f0so19464495e9.0 for ; Fri, 25 Jul 2025 02:40:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1753436435; x=1754041235; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=44ssHbdRXCrYyyAtxyTkKDOjXtvAc5bmAzGl6tF02xI=; b=BWtgYzlZ7yxZicUP4cMA+wGGzRRsuB10b+T/9j2trGZMZid5WVHhMghbAD2Eqop+Q3 Kctq8uHUxVVw5VfSARivTa/K/IeXDEVIuzs2PAriGh4nS8SPA1TqAr+znl4YGinlvAAs u4+8ui1aFGckuV5ACkXVLGVZn93vsgI87Z4mtudaFuABLkKG6I3ow2t3m+nTrCac6x8j SeeX0YktUSn+Ia7DN8R0mF8nQHBlciKp4CdPRURITOQwn7wxE66D1Q6NalbhNLk13Z2E 2CRpbYw8HcngLu38+aJBMjn70rGwnMveP8RNxFTByVYNurUCsZ0d/NVkFNUrEozAuU5D xBag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753436435; x=1754041235; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=44ssHbdRXCrYyyAtxyTkKDOjXtvAc5bmAzGl6tF02xI=; b=QPEQIMVWBeVTkzOEOHeACprkUHh6CAqH+om/hrCK51IzrsrwB2FaENaJMRqfUe8FZw 4OhOLPBFWZjQN25k63a5+v8r1UIgo69LY4KCvQBZe/0yNKjVi8U3aTAfyfDodLhnUfJS b9WAvExYDpC1USYVImMZR+3n4PmzHqBS4vGV8WpmrMlHjWyruSE7q1ZiEAcxjFrWp8Pw DsIfdtf+Tt7kcEAJaAW2NDZVQeCIAUlXfFvRds/mszZ7ti4l898jdKDqoNkMxMT/IL5Q Y4ePNzkMVVksIp+6k5OJpIWruEZNyoJfMmQdPNPfFdxY0Nji7phRSZh61/ED4E0N0KrS oY5Q== X-Forwarded-Encrypted: i=1; AJvYcCXAv3sPXA3P/7S+a5F2vUHSADUwOJbbEGkEhS9sc7wOFxVZYiHii2/wrX0/5zZ7xLp9UV/RogD+lNoYrOo=@vger.kernel.org X-Gm-Message-State: AOJu0YzxhcirPRq2Uax7TMNQ75PR7cZfbTsVWSCchrOAwaSEwnbtjLt4 d5K+rcgbnQiRcVukO3xZayizmp7agrgiGItnWHo9d2RFpeafxHGGlRcwZz5m1vU14CI= X-Gm-Gg: ASbGnct6r8uaOYpXI+UtrcNqGh3lv2GrMp0Fst4Kv0wb3tc8DjZGZjnJv4gDnTtpjVr hfm027mHZYDUMWNivkN9JVZ4F4mIiZy7RZ6IOlvkBUk1q22RipZsj6pLENzTUnmqkuEAW5/iqjI BZ3fUcgPIxZj5K3mBPoNPlU7iVCGRBxd8ihPn4bZx0qLvkuwGF6PDQPk5ZjtGieuKV9H26ULPxo mfwNttAXW+NUiI/bcAwF9c7pKqnuQZ3nMXMqkYIJtqqVc+3T3fJAkf49HTjCL4imshV6Rha/RGK DDlbLYeKz/olkug/pXi/8k9OsrKqb78nNmnv04bISADmQCJRQVia+IL1O5ItRqG0BK3k12DepyF 0qApdEO6uLrBw17v3kSXdqCCvNXbRXRzX8j5V7Iz7tqGfop3PU7OUdyK6hsONT4I1QSNc/gry X-Google-Smtp-Source: AGHT+IGOE4MKcXHWjyTgJ7GhAdYKgzZsFBV6lx5kihfphiDuGxCqQM/cXPB8xKXyeFvG0Uyggh7qPg== X-Received: by 2002:a05:600c:628f:b0:455:f59e:fd9b with SMTP id 5b1f17b1804b1-45876549a91mr10063115e9.24.1753436435188; Fri, 25 Jul 2025 02:40:35 -0700 (PDT) Received: from [192.168.10.46] (146725694.box.freepro.com. [130.180.211.218]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-3b76fc604bcsm4595223f8f.17.2025.07.25.02.40.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Jul 2025 02:40:34 -0700 (PDT) Message-ID: <9bf2899f-8981-4b66-8cf0-b7dd0d617747@linaro.org> Date: Fri, 25 Jul 2025 11:40:33 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 5/6] clocksource/drivers/exynos_mct: Add module support To: Will McVicker , Catalin Marinas , Will Deacon , Thomas Gleixner , Krzysztof Kozlowski , Alim Akhtar , Rob Herring , Saravana Kannan Cc: Donghoon Yu , Hosung Kim , kernel-team@android.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, John Stultz , Youngmin Nam , Peter Griffin , Tudor Ambarus , =?UTF-8?Q?Andr=C3=A9_Draszik?= , Conor Dooley , linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org References: <20250620181719.1399856-1-willmcvicker@google.com> <20250620181719.1399856-6-willmcvicker@google.com> Content-Language: en-US From: Daniel Lezcano In-Reply-To: <20250620181719.1399856-6-willmcvicker@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Will, On 20/06/2025 20:17, Will McVicker wrote: [ ... ] > -TIMER_OF_DECLARE(exynos4210, "samsung,exynos4210-mct", mct_init_spi); > -TIMER_OF_DECLARE(exynos4412, "samsung,exynos4412-mct", mct_init_ppi); Was these changes tested on the ARM32 Exynos platforms ? Especially did you check if there is no boot time regression ? > +static int exynos4_mct_probe(struct platform_device *pdev) > +{ > + struct device *dev = &pdev->dev; > + int (*mct_init)(struct device_node *np); > + > + mct_init = of_device_get_match_data(dev); > + if (!mct_init) > + return -EINVAL; > + > + return mct_init(dev->of_node); > +} > + > +static const struct of_device_id exynos4_mct_match_table[] = { > + { .compatible = "samsung,exynos4210-mct", .data = &mct_init_spi, }, > + { .compatible = "samsung,exynos4412-mct", .data = &mct_init_ppi, }, > + {} > +}; > +MODULE_DEVICE_TABLE(of, exynos4_mct_match_table); > + > +static struct platform_driver exynos4_mct_driver = { > + .probe = exynos4_mct_probe, > + .driver = { > + .name = "exynos-mct", > + .of_match_table = exynos4_mct_match_table, > + }, > +}; > +module_platform_driver(exynos4_mct_driver); > + > +MODULE_DESCRIPTION("Exynos Multi Core Timer Driver"); > +MODULE_LICENSE("GPL"); -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog