From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: zhengkang huang <zkhuang@hust.edu.cn>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: Dongliang Mu <dzm91@hust.edu.cn>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] soc: mdediatek: devapc: use devm_platform_ioremap_resource() instead of of_iomap()
Date: Tue, 18 Apr 2023 12:09:17 +0200 [thread overview]
Message-ID: <9bfd1641-3f58-ca6e-1e80-13acea834ea5@collabora.com> (raw)
In-Reply-To: <20230414092113.64514-1-zkhuang@hust.edu.cn>
Il 14/04/23 11:21, zhengkang huang ha scritto:
> In mtk_devapc_probe(), if of_iomap succeeds and any following error occurs,
> it needs to deallocate the resource.
>
> Fix this by repalcing of_iomap with devm_platform_ioremap_resource, which
> automatically self-manages the resource. This can avoid modifying error
> handling code.
>
> Signed-off-by: zhengkang huang <zkhuang@hust.edu.cn>
> Reviewed-by: Dongliang Mu <dzm91@hust.edu.cn>
You haven't tested this patch on any MediaTek SoC, have you?
This will break devapc.
Regards,
Angelo
next prev parent reply other threads:[~2023-04-18 10:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-14 9:21 zhengkang huang
2023-04-18 10:09 ` AngeloGioacchino Del Regno [this message]
2023-04-18 11:49 ` Dongliang Mu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9bfd1641-3f58-ca6e-1e80-13acea834ea5@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=dzm91@hust.edu.cn \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=zkhuang@hust.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®