Re: [PATCH 0/6] genirq/test: Platform/architecture fixes

[Guenter Roeck <linux@roeck-us.net>]

On Mon, Aug 18, 2025 at 12:27:37PM -0700, Brian Norris wrote:
> The new kunit tests at kernel/irq/irq_test.c were primarily tested on
> x86_64, with QEMU and with ARCH=um builds. Naturally, there are other
> architectures that throw complications in the mix, with various CPU
> hotplug and IRQ implementation choices.
> 
> Guenter has been dutifully noticing and reporting these errors, in
> places like:
> https://lore.kernel.org/all/b4cf04ea-d398-473f-bf11-d36643aa50dd@roeck-us.net/
> 
> I hope I've addressed all the failures, but it's hard to tell when I
> don't have cross-compilers and QEMU setups for all of these
> architectures.
> 
> I've tested what I could on arm, powerpc, x86_64, and um ARCH.
> 
> This series is based on David's patch for these tests:
> 
> [PATCH] genirq/test: Fix depth tests on architectures with NOREQUEST by default.
> https://lore.kernel.org/all/20250816094528.3560222-2-davidgow@google.com/
> 
Looks pretty good.

Build results:
	total: 162 pass: 162 fail: 0
Qemu test results:
	total: 637 pass: 637 fail: 0
Unit test results:
	pass: 640616 fail: 13
Failed unit tests:
	arm64:imx8mp-evk:irq_cpuhotplug_test
	arm64:imx8mp-evk:irq_test_cases
	m68k:q800:irq_test_cases
	m68k:virt:irq_test_cases

Individual failures:

[   32.613761]     # irq_cpuhotplug_test: EXPECTATION FAILED at kernel/irq/irq_test.c:210
[   32.613761]     Expected remove_cpu(1) == 0, but
[   32.613761]         remove_cpu(1) == -16 (0xfffffffffffffff0)
[   32.621522]     # irq_cpuhotplug_test: EXPECTATION FAILED at kernel/irq/irq_test.c:212
[   32.621522]     Expected add_cpu(1) == 0, but
[   32.621522]         add_cpu(1) == 1 (0x1)
[   32.630930]     # irq_cpuhotplug_test: pass:0 fail:1 skip:0 total:1

    # irq_disable_depth_test: ASSERTION FAILED at kernel/irq/irq_test.c:53
    Expected virq >= 0, but
        virq == -12 (0xfffffffffffffff4)
    # irq_disable_depth_test: pass:0 fail:1 skip:0 total:1
    not ok 1 irq_disable_depth_test
    # irq_free_disabled_test: ASSERTION FAILED at kernel/irq/irq_test.c:53
    Expected virq >= 0, but
        virq == -12 (0xfffffffffffffff4)
    # irq_free_disabled_test: pass:0 fail:1 skip:0 total:1

Guenter