From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lf-2-58.ptr.blmpb.com (lf-2-58.ptr.blmpb.com [101.36.218.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 365FD3EDAC7 for ; Wed, 15 Jul 2026 09:11:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=101.36.218.58 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784106692; cv=none; b=mD0bpsZzMKl6/NF6V5xfAlVxQAZ+DIBaJ+0pemgAa3iyc0mBc/mry2BiWmrO9DqN7ocJA9RC7TDl7LzC9DFIwnczpHk9wDg2qsEWAq4pXWnMNyjwKYqqpGzjDUVpNbYL3YgeFkhs/VS1tX7hbKoCixYzWzunqyCuecDyQbHH+kA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784106692; c=relaxed/simple; bh=btqayxoqiXiqpQXBkVDNPPHzll/Lc3vmjofDfeui+zs=; h=Cc:From:References:To:Message-Id:Mime-Version:In-Reply-To:Subject: Date:Content-Type; b=A8k30mpgRhxnNJ+siU4uqkhGeWgUsaJ6YMScUmwbxapJTUW3TCSnHAS4+i/K0+Hu8F4zRBWaNCo2mBj/6Qpq7bSkoeSITbCB1uZAbx615VUoOIyRdkwQMkNbpf67QOAo/Uz1p1o1UbsDZUFUXmZyBbUOUePhGDuhYlyOw0Bfzrw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fygo.io; spf=pass smtp.mailfrom=fygo.io; dkim=pass (2048-bit key) header.d=fygo-io.20200929.dkim.larksuite.com header.i=@fygo-io.20200929.dkim.larksuite.com header.b=h6zflTCj; arc=none smtp.client-ip=101.36.218.58 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fygo.io Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fygo.io Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fygo-io.20200929.dkim.larksuite.com header.i=@fygo-io.20200929.dkim.larksuite.com header.b="h6zflTCj" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=s1; d=fygo-io.20200929.dkim.larksuite.com; t=1784106636; h=from:subject:mime-version:from:date:message-id:subject:to:cc: reply-to:content-type:mime-version:in-reply-to:message-id; bh=69sbYCT1PNe8Uf6rkuJM+T+srtrVJzzUw1N+k0bSBHE=; b=h6zflTCj9zFYWlcpPgjnY8nhUw14302JcvX3Zyf00FnwVYsxryCF7Fj68xPTivHPfzBM6J rmlHv7SYac9yAkHUWioPZpP6liPpikQysS8ZamurfODGlSwgxjOXBkNJjYXpkYRWUXWHKW fZ5+zFTRk0na+f1k5xEUUU8tiHvOeHNzSnSYF0HYXfRE7qLt+XhWNCQFtHYQRPV+LZvDQH MAVqU21bXG+RlH7pGUDNpzG/DkQ2RGt75iJtnek4Dgh3Od/OzyHY8BqYy3XEJkegmd1BsU 5KdogMfoCLq0tYQS4B0d2py6jF9u//18WoLK4epbgslslg7PNvr0LNB8yLszpA== Cc: From: "yu kuai" References: <20260710101521.1714-1-abd.masalkhi@gmail.com> <20260710101521.1714-4-abd.masalkhi@gmail.com> Received: from [192.168.1.104] ([39.182.0.157]) by smtp.larksuite.com with ESMTPS; Wed, 15 Jul 2026 09:10:35 +0000 Reply-To: yukuai@fygo.io To: "Abd-Alrhman Masalkhi" , , , , , , , , , "yu kuai" Content-Transfer-Encoding: quoted-printable User-Agent: Mozilla Thunderbird Message-Id: <9c000a0f-9c83-48a3-be78-e08aefb16db2@fygo.io> X-Lms-Return-Path: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Original-From: yu kuai In-Reply-To: <20260710101521.1714-4-abd.masalkhi@gmail.com> Subject: Re: [PATCH v4 3/7] md/raid10: consistently fail atomic writes that require splitting Date: Wed, 15 Jul 2026 17:10:31 +0800 Content-Type: text/plain; charset=UTF-8 =E5=9C=A8 2026/7/10 18:15, Abd-Alrhman Masalkhi =E5=86=99=E9=81=93: > RAID10 currently handles one badblock path explicitly by failing atomic > writes with EIO. However, another badblock path can also reduce the > writable range and force the bio through bio_submit_split_bioset(), > which implicitly completes the bio with EINVAL. > > Fix this by handling atomic writes in the common split check. If RAID10 > determines that an atomic write would require splitting, complete the > bio with EIO. > > Fixes: a1d9b4fd42d9 ("md/raid10: Atomic write support") > Signed-off-by: Abd-Alrhman Masalkhi > --- > Changes in v4: > - No changes. > - Link to v3:https://lore.kernel.org/linux-raid/20260708101341.473750-4= -abd.masalkhi@gmail.com/ > > Changes in v3: > - No changes. > - Link to v2:https://lore.kernel.org/linux-raid/20260628142420.1051027-= 4-abd.masalkhi@gmail.com/ > > Changes in v2: > - Drop the early atomic write split check from raid10_write_request() > and rely on queue limits instead. > - Link to v1:https://lore.kernel.org/linux-raid/20260623072456.333437-4= -abd.masalkhi@gmail.com/ > --- > drivers/md/raid10.c | 14 ++++---------- > 1 file changed, 4 insertions(+), 10 deletions(-) Reviewed-by: Yu Kuai --=20 Thanks, Kuai