From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BCC9121D59C for ; Wed, 26 Feb 2025 16:20:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740586832; cv=none; b=qg39O2n+Bjc/wWbC12sItqeq1gHM8L0eNoW5HrLM+EsAS+1HTAqzfvIrkb3OkiZaRPA7KYg8bxxZwO8l9907f52VBxR3n1a53sjw0XOg/tnVn1Uzd445o1cpY17XYkEzSyjhx5wnNClpd4V1hJ9VbbWfifFmEgvl6ga82LctlU8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740586832; c=relaxed/simple; bh=2nqyqqx0MAd0AgGyAucIaH6EREOxVYygyrAHK6YBIr0=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=GvNJdkshRlNfdobuYQJYuVF47XOnoiUCnVj+zps8E0ywZzrxsyi3kolDeENmrvoy8EGW1yJM0cRCS3vIZ3PuGPDBySzrttuKoY+YKFwmtjSg56fyAIcCSMWyuByBlCzIRRJ9UVAUZnsEhqbDFI+H8orh6E2Xa1vlLXzpHgBTdME= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=cjAWEtEI; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="cjAWEtEI" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-4397dff185fso61639135e9.2 for ; Wed, 26 Feb 2025 08:20:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740586829; x=1741191629; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=2nqyqqx0MAd0AgGyAucIaH6EREOxVYygyrAHK6YBIr0=; b=cjAWEtEIQJuRE+iO7QUUI0CmBcQ0wqiHs6+i10oD8iO72pb+fWE2t39588F8JZswbN on7rSesWbFZORTfzrbkpr3UfLJJE2GjgB9maoRu2QDFnTVAAxAofdbTLuVXtaiv8rHmT b6I4P2LzCDJGlwlUSgn5wywJBWpXFJ/iQ51BnSVFOa49eGkIhPLDpdpG+f7n1WsUJm0T h6rvst4XE46ao1yzxxsZhGte4VdZfsRMeWiR8iw1to9ybOn2rVAFF75CsyZJ5OsDQt3H AZD7wYO2gJAcy6mVYp++MNXkYwAyUkxcC0sQLR/3s9DX2VQD69cVi9VO7RX/Js1vqsOJ ggfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740586829; x=1741191629; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=2nqyqqx0MAd0AgGyAucIaH6EREOxVYygyrAHK6YBIr0=; b=Jkr2Rew7Pr+AMSjosjAk2tVQK2RqHOdx7Rdgh1yclbqFjmmsn0hRkHDePa3FVlHv3U 8HvEvA5KtwBTb/vRskIvuqJRDypMFjLoMOkus+DBErM0lJUgwOTrf17b/KxdEDYYvlr0 /1gPSep+HbTGLW2jLGOf22Sg0Q/rX7IuBfJ15ITcVJ7Zjcym7K31m50ueAE0MifNYyN5 T9nescL/nSCkHUTDduRbjS11zBAPO3oq/W0xQfpLNPW1MNKPBSyjLR9zaXQEVaH2UVzD LM1dNt5rLIarT9iPJdi019SX960buCfImuCFsrnqEV2Ug+eG536H4TpqJ1A+Z5nyxcnw wJ2g== X-Forwarded-Encrypted: i=1; AJvYcCVn/t81WxRSPN/N2ChfkZMd1PKlQ28dGWb67mXtxPASFVOa7FyoeNNGHvM8K5sbqpiuZCY48bLaKpRgg4M=@vger.kernel.org X-Gm-Message-State: AOJu0Yw22JRDMw/4cWqzxYmIXJjwwZlEK8X77UCrP8Cpu9uyRDQLS2eL tFCSiLURyasuau/vDi4ibQeW5qE0SFVPHEsIb05zUgTM1r4OXScLcziajFQJRn0= X-Gm-Gg: ASbGncuzk3Ux4FWyLc0tbw+CAJ5xGXBzMCjJXJuAG+rbBvAZCv+fUb0U7p9yJ39s8M/ Gm450qhbk3fZANB9N+r0lzRuSF7lpHeM+32P1nS36jk34uyiKaLMrV42Q1VZBQt8P21pFSuYn9n O00NAUlJyE0Ohwjnjxu+jj553VGLwZcxRFAeuAZ/ZaEcTfsSN8kSZRACDbLNdw7vsNc1IO2i4aP Y11b6MPtygCuAkM/11yspnEGxFJB0dvBptVkVoe9jlN8DNN+cSOnKzpe7hlhf9s129NE0gmVx7f zp7wldYv5uMhwwIxZc7N9Oh6bJrrOw== X-Google-Smtp-Source: AGHT+IE0+iJG+B7XOAyijX1v1ZMsbEkcNx8hqjN7umdi3u8zQQME8o/j8N4tXvKdeHCV0Qi8VsGsyA== X-Received: by 2002:a05:6000:400f:b0:38d:dc57:855d with SMTP id ffacd0b85a97d-390d4f8d921mr3807666f8f.35.1740586829046; Wed, 26 Feb 2025 08:20:29 -0800 (PST) Received: from draszik.lan ([80.111.64.44]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-390dd12c30asm1923141f8f.71.2025.02.26.08.20.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Feb 2025 08:20:28 -0800 (PST) Message-ID: <9c013c053b8677ee6bb2a37bc48e90a25fa16d7e.camel@linaro.org> Subject: Re: [PATCH 1/2] dt-bindings: reset: syscon-reboot: support reset modes From: =?ISO-8859-1?Q?Andr=E9?= Draszik To: "Rob Herring (Arm)" Cc: Tudor Ambarus , devicetree@vger.kernel.org, linux-pm@vger.kernel.org, Peter Griffin , Conor Dooley , Will McVicker , linux-kernel@vger.kernel.org, kernel-team@android.com, Krzysztof Kozlowski , Sebastian Reichel Date: Wed, 26 Feb 2025 16:20:27 +0000 In-Reply-To: References: <20250226-syscon-reboot-reset-mode-v1-0-91c1b62166ae@linaro.org> <20250226-syscon-reboot-reset-mode-v1-1-91c1b62166ae@linaro.org> <174058375994.2463209.9948592153423144239.robh@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.53.2-1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Wed, 2025-02-26 at 15:42 +0000, Andr=C3=A9 Draszik wrote: > On Wed, 2025-02-26 at 09:29 -0600, Rob Herring (Arm) wrote: > >=20 > > On Wed, 26 Feb 2025 14:08:20 +0000, Andr=C3=A9 Draszik wrote: > > > Add support for specifying different register/mask/value combinations > > > for different types of reset. > > >=20 > > > In particular, update the binding to allow platforms to specify the > > > following reset modes: soft, warm, cold, hard. > > >=20 > > > Linux can perform different types of reset using its reboot=3D kernel > > > command line argument, and some platforms also wish to reset > > > differently based on whether or not e.g. contents of RAM should be > > > retained across the reboot. > > >=20 > > > The new properties match the existing properties, just prefixed with > > > one of the reset modes mentioned above. > > >=20 > > > Signed-off-by: Andr=C3=A9 Draszik > > > --- > > > =C2=A0.../bindings/power/reset/syscon-reboot.yaml=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 | 74 ++++++++++++++++++++++ > > > =C2=A01 file changed, 74 insertions(+) > > >=20 > >=20 > > My bot found errors running 'make dt_binding_check' on your patch: >=20 > oops, sorry - the script we usually run didn't cover this binding, BTW, we did that, because it's easy to miss warnings due to the amount of bindings and text scrolling past. Ideally make would exit with !=3D 0 in case of binding errors. I can see in commit 3e95dfb315de ("dt-bindings: Don't error out on yamllint and dt-doc-validate errors"), warnings are never treated as errors. Is that still relevant, can that commit be revert? Don't we want the build to fail loudly on binding errors, so that people don't even submit erroneous bindings in the first place? Cheers, Andre'