From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39E83C3A5A7 for ; Tue, 6 Dec 2022 08:29:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233646AbiLFI3W (ORCPT ); Tue, 6 Dec 2022 03:29:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55898 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233178AbiLFI3S (ORCPT ); Tue, 6 Dec 2022 03:29:18 -0500 Received: from mail.3ffe.de (0001.3ffe.de [IPv6:2a01:4f8:c0c:9d57::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F6426315; Tue, 6 Dec 2022 00:29:17 -0800 (PST) Received: from 3ffe.de (0001.3ffe.de [IPv6:2a01:4f8:c0c:9d57::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.3ffe.de (Postfix) with ESMTPSA id 54BAB125C; Tue, 6 Dec 2022 09:29:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2022082101; t=1670315355; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6x7SqeU7DjKi4snpIda9gKwYIWf96Kgh9HxDpXGjY7s=; b=IF4UQKpEORyOoN+79mglJzGWZAK8gvJOd1Np/Ao/oIgdB0VPjWuwumcaI7MBzAOMQ8udYU 1AuyCoAIBg84DTLguD7+59ZR2MONJ/HxDtPifciKYixccbeoctBB7Q3QUVv945WGErVU7T EbK+hGg5Dfh1WyljNINJ47R1bfeJZcpIwg3DPi1wu7x+dTr2p+IN5Se2S/xI0y5P/LbVj8 SvdPrsgsB4mSHURR0M2hyWGNPDPMyPT3MntgVHEb17XU+B0u+XXMh4z7jRZUG+cqmmtY9c AQjixZ1+ns7sG/OJ5DrwfOZPQmhph7r+7EfstzRwMW0XpatmQ2QKUusVKr8tuA== MIME-Version: 1.0 Date: Tue, 06 Dec 2022 09:29:15 +0100 From: Michael Walle To: Rob Herring Cc: Xu Liang , Andrew Lunn , Heiner Kallweit , Russell King , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Krzysztof Kozlowski , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH net-next v1 3/4] dt-bindings: net: phy: add MaxLinear GPY2xx bindings In-Reply-To: <99d4f476d4e0ce5945fa7e1823d9824a@walle.cc> References: <20221202151204.3318592-1-michael@walle.cc> <20221202151204.3318592-4-michael@walle.cc> <20221205212924.GA2638223-robh@kernel.org> <99d4f476d4e0ce5945fa7e1823d9824a@walle.cc> User-Agent: Roundcube Webmail/1.4.13 Message-ID: <9c0506a6f654f72ea62fed864c1b2a26@walle.cc> X-Sender: michael@walle.cc Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 2022-12-05 22:53, schrieb Michael Walle: > Am 2022-12-05 22:29, schrieb Rob Herring: >> On Fri, Dec 02, 2022 at 04:12:03PM +0100, Michael Walle wrote: >>> Add the device tree bindings for the MaxLinear GPY2xx PHYs. >>> >>> Signed-off-by: Michael Walle >>> --- >>> >>> Is the filename ok? I was unsure because that flag is only for the >>> GPY215 >>> for now. But it might also apply to others. Also there is no >>> compatible >>> string, so.. >>> >>> .../bindings/net/maxlinear,gpy2xx.yaml | 47 >>> +++++++++++++++++++ >>> 1 file changed, 47 insertions(+) >>> create mode 100644 >>> Documentation/devicetree/bindings/net/maxlinear,gpy2xx.yaml >>> >>> diff --git >>> a/Documentation/devicetree/bindings/net/maxlinear,gpy2xx.yaml >>> b/Documentation/devicetree/bindings/net/maxlinear,gpy2xx.yaml >>> new file mode 100644 >>> index 000000000000..d71fa9de2b64 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/net/maxlinear,gpy2xx.yaml >>> @@ -0,0 +1,47 @@ >>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/net/maxlinear,gpy2xx.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: MaxLinear GPY2xx PHY >>> + >>> +maintainers: >>> + - Andrew Lunn >>> + - Michael Walle >>> + >>> +allOf: >>> + - $ref: ethernet-phy.yaml# >>> + >>> +properties: >>> + maxlinear,use-broken-interrupts: >>> + description: | >>> + Interrupts are broken on some GPY2xx PHYs in that they keep >>> the >>> + interrupt line asserted even after the interrupt status >>> register is >>> + cleared. Thus it is blocking the interrupt line which is >>> usually bad >>> + for shared lines. By default interrupts are disabled for this >>> PHY and >>> + polling mode is used. If one can live with the consequences, >>> this >>> + property can be used to enable interrupt handling. >> >> Just omit the interrupt property if you don't want interrupts and add >> it >> if you do. > > How does that work together with "the device tree describes > the hardware and not the configuration". The interrupt line > is there, its just broken sometimes and thus it's disabled > by default for these PHY revisions/firmwares. With this > flag the user can say, "hey on this hardware it is not > relevant because we don't have shared interrupts or because > I know what I'm doing". Specifically you can't do the following: Have the same device tree and still being able to use it with a future PHY firmware update/revision. Because according to your suggestion, this won't have the interrupt property set. With this flag you can have the following cases: (1) the interrupt information is there and can be used in the future by non-broken PHY revisions, (2) broken PHYs will ignore the interrupt line (3) except the system designer opts-in with this flag (because maybe this is the only PHY on the interrupt line etc). -michael