From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F27F020E334 for ; Thu, 18 Jun 2026 21:55:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781819741; cv=none; b=CLZvMFJC09cTPz3rKmBA9CpUv9Xf55bpq11BYRumc8vcQi+2vNB9JGRmkDmTqW3QVycMfQFdlnFEaYR0ycuMunUY0eicx7lJpA31kbmuRiLw5NoPy33JSGV7turkWl5AHHMWAiVl7IykccHtcGWtaxchw74u4xVZSQ+d8Ok8Y5Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781819741; c=relaxed/simple; bh=Cbh7yMu02gWFAqvQBXkQS/CSLQG0i/YKJpQqxJfzxhU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=tWnnBfAKMKoljI8CXhgLakqTeDEm155fjzwKLTXrjjEsA0vqdLLGZU036VEXA/qKrEy1nwcbBvyQv03d9axibex4+n/yECWnsMHV9c+GUvn/OEzCWqSb2f+uuCEiu3aTO1J9nmUNPx8LWw3LyQ3neFgukXNXGsIqIndzInI4Aq0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=X07FYeW5; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=RG5Z0gnS; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="X07FYeW5"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="RG5Z0gnS" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65ILsla22988666 for ; Thu, 18 Jun 2026 21:55:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= mNsa7I9Vt4mc8undy3jW445YkhGT6jOLPD/WUCSW4VM=; b=X07FYeW5m4O3SVUq WI47OZK6qiwRiKZZCu+Yw0gLudL5lMuG2kga/jxOph4Wcg9LC/QUIuT33n9OHuPy oMzv7ECaULszW2NIPyszKZ6mvf9t8U7/zwwodcmYaEG3tNd+XJN8GTiYe31B/RH0 m411CCbRsImHcxRgavJtXyReEJUh+1SbxG/7s30AobH8oEaIpES3MaIE3GxlrGzC RNWwHCJfXqxZ/d55xrckgI7DAwLCKSVqVq0R26AreKm72ovgyO64YeJFr+E7hnWh 6dFVKCpegglsP0UmMU71t5jCthlcIexoxqAxzdOxoevcJEtqUo1EmKIA4iEXvI2n JQksGw== Received: from mail-dl1-f70.google.com (mail-dl1-f70.google.com [74.125.82.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4evm20hfuv-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 18 Jun 2026 21:55:38 +0000 (GMT) Received: by mail-dl1-f70.google.com with SMTP id a92af1059eb24-138455d7e20so2729686c88.1 for ; Thu, 18 Jun 2026 14:55:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781819738; x=1782424538; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=mNsa7I9Vt4mc8undy3jW445YkhGT6jOLPD/WUCSW4VM=; b=RG5Z0gnS6xIgsbITVQNEecPTtQadPfwIXAnCbYGo5YoXZL1K65Bz5+JR4B7OtfE8XS fEncI/IGpGcAfJQLsMCgDRZajH7rp2JMKjGGUMtKbKa+cy/sV1dIfV+5XGaIKY4e5GK1 cS1NlbYSat4qQOxfgmofdbe4rvanO2zhiPPcnu87jpmpDGJAD2T8azCIM25spDgHn/Ns 7sW9JT6e2y+ySlGUnfQpuharM2ntqhvZKgWvwaW03RjME3ygMgViIlvFfGjA+jER8Cmb Kb5wAAz/AbVkA2oYapCCQB+AO+vx6y5MEYixENyCM4zxaLHEovxN/RJkffnyfpE9s09z UUuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781819738; x=1782424538; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=mNsa7I9Vt4mc8undy3jW445YkhGT6jOLPD/WUCSW4VM=; b=gv1WjmgVxjVxBn9n5P23fkJo+8dj4nxjRi0v1nQC1KHikyGGZr0d2PVTQZDqM0pID/ 0hklHzNo7IYSPg6jcaZ2lQtjym++MZCA/efWNUuGqwgD7O8nWrRzE8DJ8/7c8Xp2UQ1z T5I8iIwMfMMZ7kNzBorFfDs/kqlEYeLeH9sg5CyAbtruqGmG5jTKfoK7YDPCLk93gL5f WH42aYaTlVdz/IRkiZMOVTPKXMdYgJNgfXfoYvT9zORUKnktNMX/b3lgPRvrR9STlvsE F7u5dJyy7/ldRnomgdRWKflY/hUce7GneBcdikCAqEMVEZAjb6FL/1EV/bZEHmMwhbFY /KNA== X-Forwarded-Encrypted: i=1; AFNElJ/KwSClGhXFqjde+Z3+2Q5WczW+iPc0RMiIhA05YSKNDJ3NWb9MwVPituMF2ZkM3hsITsoekKwo8nj0lmg=@vger.kernel.org X-Gm-Message-State: AOJu0YzmqNykY/dMGAB9+SK1Ik/31iMfNY0qfkTtP2/3vCW3v6UkxT8P bk8t84/tKiRxsarrEgo+tYHEpCzo3qzCRUsEMbj+d14YT2kabRXmyCcQM+ZW/PgxNQ1EfPUh1Zm oOFS4co/j512p+mP/cWyOP4yUsUmNtGRGZm6XZQA1AyuR4su6hY3gt11HxlSXh5Rx+mw= X-Gm-Gg: AfdE7cncruml/OwSWSAYp025ng37zlWl1Gv8lm+LVGHIEmVI2ylO/4G5TV8I0FxhDMC S18gZrarmWSTY9V8lQOEormDJ8aWeDzKeNsNI2DGAGrajpl4rDRTJ32wIhBC/v/gT8dPADlFYNT lac6vYd2KEv7fn0JmvQ0rjlLcQmN6jcQGucopqX4ncW4G8qgg7OdBLtQBBVJ9JXv2fhKfkYqly5 Z231O8PDJFx4H3l3hizQTWGvg8MyUdE5Y2A5KH7ZU6USpH9167JHYIPKMDIpm6dKyPNkqeM+ykn 7nWjZpzwU3FmIt7ikDEnEo6k18wy4nwcxbHBxLVlYIwet7oInqm4qd7wwLJ6Bab5D5feeyroE5H VRuYwRX1nA0HFh2oXONexIIKOB0sc1Ax68c9evhGmfUNXDnX5exQXVEnJ97mnWlfGV4rA1+M11k kVZKU= X-Received: by 2002:a05:7022:41a2:b0:136:e639:9c05 with SMTP id a92af1059eb24-139a217155dmr1087418c88.31.1781819737734; Thu, 18 Jun 2026 14:55:37 -0700 (PDT) X-Received: by 2002:a05:7022:41a2:b0:136:e639:9c05 with SMTP id a92af1059eb24-139a217155dmr1087398c88.31.1781819737185; Thu, 18 Jun 2026 14:55:37 -0700 (PDT) Received: from [192.168.1.31] (c-24-130-122-79.hsd1.ca.comcast.net. [24.130.122.79]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-139a367f73asm312545c88.15.2026.06.18.14.55.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Jun 2026 14:55:36 -0700 (PDT) Message-ID: <9c08b419-7180-4ecf-8a9d-026a80cbb98a@oss.qualcomm.com> Date: Thu, 18 Jun 2026 14:55:35 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH ath-next] wifi: ath9k: mark PN9Data as const To: Rosen Penev , linux-wireless@vger.kernel.org Cc: =?UTF-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= , open list References: <20260616030652.635121-1-rosenp@gmail.com> From: Jeff Johnson Content-Language: en-US In-Reply-To: <20260616030652.635121-1-rosenp@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE4MDIwMCBTYWx0ZWRfX9ht3XS5FENff Cs0ruXLZ8BpYpWM0pu8L3a3PFyWWp73lrV1nENsWLdARGJ/jeYIDiqqYTkq2pu0PtAfVpQ+O5Dl 32FD/jtz8Fk3qym2Aq09dhFoHMvxl11qx8hRnWaWscLwphpgsiOEKCSCC8hMtVZva75pJuHrWVm R0+cot+aItFxsiFroRRcVc6zaO9nV3LPfn5f+erds5RnUv7nUL5jngVQnXxmDDckUwchSBsG8V2 5ey8nl7ke9ERTjnpHb14lGE65rfOMczsCemvf2w7TCLWlrHut/xbUp35i7Fl6GxIouCXwgH6dmJ 1xdZx8us1y6teRANnVgraBRfdbcJi0vKBNK5d3z3NAqjGQGkjGrss9tEe57K6o49pUnJoj/CH7n KpzFFHT/zCOXdvC7I3GVvbw2BBun39skqwNpIlSir3rYny+H/HcZvlH2QQol4vi1FZqUWZpOHGe 5Yn8NNqZ7VlN5UArnzQ== X-Authority-Analysis: v=2.4 cv=GKw41ONK c=1 sm=1 tr=0 ts=6a34695a cx=c_pps a=SvEPeNj+VMjHSW//kvnxuw==:117 a=Tg7Z00WN3eLgNEO9NLUKUQ==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=pGLkceISAAAA:8 a=xOomHs3cNmDTsBMdfcEA:9 a=QEXdDO2ut3YA:10 a=Kq8ClHjjuc5pcCNDwlU0:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE4MDIwMCBTYWx0ZWRfXzTFWJv0ssWtI jfgrtxcke4wItYT+oe6n8G+MB0O3XPu5/9WFqWXwdeyYRIi1ydfC3ppguQzNe3R8MO62JIY0fA/ bkXnRCwO5oLNglhNkP/gp6yVChYo4Vw= X-Proofpoint-GUID: NMT3MNMrVGJe2s-XN8tmRtVLzYQHd9Po X-Proofpoint-ORIG-GUID: NMT3MNMrVGJe2s-XN8tmRtVLzYQHd9Po X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-18_04,2026-06-18_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 lowpriorityscore=0 clxscore=1015 adultscore=0 priorityscore=1501 bulkscore=0 impostorscore=0 phishscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606180200 On 6/15/2026 8:06 PM, Rosen Penev wrote: > PN9Data is a read-only lookup table and is never modified. Adding const > lets the compiler place it in .rodata and prevents accidental writes. > > Assisted-by: opencode:big-pickle > Signed-off-by: Rosen Penev > --- > drivers/net/wireless/ath/ath9k/tx99.c | 16 ++++++++-------- > drivers/net/wireless/ath/ath9k/xmit.c | 2 +- > 2 files changed, 9 insertions(+), 9 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath9k/tx99.c b/drivers/net/wireless/ath/ath9k/tx99.c > index f2144fd39093..b52d84f6cbc9 100644 > --- a/drivers/net/wireless/ath/ath9k/tx99.c > +++ b/drivers/net/wireless/ath/ath9k/tx99.c > @@ -39,14 +39,14 @@ static void ath9k_tx99_stop(struct ath_softc *sc) > > static struct sk_buff *ath9k_build_tx99_skb(struct ath_softc *sc) > { > - static u8 PN9Data[] = {0xff, 0x87, 0xb8, 0x59, 0xb7, 0xa1, 0xcc, 0x24, > - 0x57, 0x5e, 0x4b, 0x9c, 0x0e, 0xe9, 0xea, 0x50, > - 0x2a, 0xbe, 0xb4, 0x1b, 0xb6, 0xb0, 0x5d, 0xf1, > - 0xe6, 0x9a, 0xe3, 0x45, 0xfd, 0x2c, 0x53, 0x18, > - 0x0c, 0xca, 0xc9, 0xfb, 0x49, 0x37, 0xe5, 0xa8, > - 0x51, 0x3b, 0x2f, 0x61, 0xaa, 0x72, 0x18, 0x84, > - 0x02, 0x23, 0x23, 0xab, 0x63, 0x89, 0x51, 0xb3, > - 0xe7, 0x8b, 0x72, 0x90, 0x4c, 0xe8, 0xfb, 0xc0}; > + static const u8 PN9Data[] = {0xff, 0x87, 0xb8, 0x59, 0xb7, 0xa1, 0xcc, 0x24, > + 0x57, 0x5e, 0x4b, 0x9c, 0x0e, 0xe9, 0xea, 0x50, > + 0x2a, 0xbe, 0xb4, 0x1b, 0xb6, 0xb0, 0x5d, 0xf1, > + 0xe6, 0x9a, 0xe3, 0x45, 0xfd, 0x2c, 0x53, 0x18, > + 0x0c, 0xca, 0xc9, 0xfb, 0x49, 0x37, 0xe5, 0xa8, > + 0x51, 0x3b, 0x2f, 0x61, 0xaa, 0x72, 0x18, 0x84, > + 0x02, 0x23, 0x23, 0xab, 0x63, 0x89, 0x51, 0xb3, > + 0xe7, 0x8b, 0x72, 0x90, 0x4c, 0xe8, 0xfb, 0xc0}; > u32 len = 1200; > struct ieee80211_tx_rate *rate; > struct ieee80211_hw *hw = sc->hw; > diff --git a/drivers/net/wireless/ath/ath9k/xmit.c b/drivers/net/wireless/ath/ath9k/xmit.c > index 89d8b3178784..57e451548958 100644 > --- a/drivers/net/wireless/ath/ath9k/xmit.c > +++ b/drivers/net/wireless/ath/ath9k/xmit.c > @@ -41,7 +41,7 @@ > #define ATH9K_PWRTBL_11NG_HT_SHIFT 12 > > > -static u16 bits_per_symbol[][2] = { > +static const u16 bits_per_symbol[][2] = { unrelated change not mentioned in the commit text? > /* 20MHz 40MHz */ > { 26, 54 }, /* 0: BPSK */ > { 52, 108 }, /* 1: QPSK 1/2 */ > -- > 2.54.0