From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754857AbcGEKTF (ORCPT ); Tue, 5 Jul 2016 06:19:05 -0400 Received: from zencphosting06.zen.co.uk ([82.71.204.9]:50737 "EHLO zencphosting06.zen.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754834AbcGEKTA (ORCPT ); Tue, 5 Jul 2016 06:19:00 -0400 Subject: Re: [PATCH v2 6/8] Input: synaptics-rmi4: Remove unneeded variable To: Andrew Duggan , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org References: <1466813960-15987-1-git-send-email-aduggan@synaptics.com> Cc: Dmitry Torokhov , Linus Walleij , Jiri Kosina , Benjamin Tissoires , Vincent Huang From: Nick Dyer Message-ID: <9c09766e-17c1-4a6d-93ce-d03f42f3f365@itdev.co.uk> Date: Tue, 5 Jul 2016 11:18:42 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <1466813960-15987-1-git-send-email-aduggan@synaptics.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-OutGoing-Spam-Status: No, score=-1.4 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - zencphosting06.zen.co.uk X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - itdev.co.uk X-Get-Message-Sender-Via: zencphosting06.zen.co.uk: authenticated_id: nick.dyer@itdev.co.uk X-Authenticated-Sender: zencphosting06.zen.co.uk: nick.dyer@itdev.co.uk Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25/06/2016 01:19, Andrew Duggan wrote: > Remove the data_base_addr_offset variable in rmi_f11_attention(). The > f11 data is read as a single block so there is no need to store an offset > to the data address. > > Signed-off-by: Andrew Duggan Reviewed-by: Nick Dyer > --- > drivers/input/rmi4/rmi_f11.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/input/rmi4/rmi_f11.c b/drivers/input/rmi4/rmi_f11.c > index e691432..688e604 100644 > --- a/drivers/input/rmi4/rmi_f11.c > +++ b/drivers/input/rmi4/rmi_f11.c > @@ -1265,7 +1265,6 @@ static int rmi_f11_attention(struct rmi_function *fn, unsigned long *irq_bits) > struct rmi_driver_data *drvdata = dev_get_drvdata(&rmi_dev->dev); > struct f11_data *f11 = dev_get_drvdata(&fn->dev); > u16 data_base_addr = fn->fd.data_base_addr; > - u16 data_base_addr_offset = 0; > int error; > > if (rmi_dev->xport->attn_data) { > @@ -1275,8 +1274,7 @@ static int rmi_f11_attention(struct rmi_function *fn, unsigned long *irq_bits) > rmi_dev->xport->attn_size -= f11->sensor.attn_size; > } else { > error = rmi_read_block(rmi_dev, > - data_base_addr + data_base_addr_offset, > - f11->sensor.data_pkt, > + data_base_addr, f11->sensor.data_pkt, > f11->sensor.pkt_size); > if (error < 0) > return error; > @@ -1284,7 +1282,6 @@ static int rmi_f11_attention(struct rmi_function *fn, unsigned long *irq_bits) > > rmi_f11_finger_handler(f11, &f11->sensor, irq_bits, > drvdata->num_of_irq_regs); > - data_base_addr_offset += f11->sensor.pkt_size; > > return 0; > } >