From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEC29C48BD5 for ; Tue, 25 Jun 2019 17:49:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AA68020663 for ; Tue, 25 Jun 2019 17:49:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731594AbfFYRtG (ORCPT ); Tue, 25 Jun 2019 13:49:06 -0400 Received: from smtprelay0009.hostedemail.com ([216.40.44.9]:48564 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726791AbfFYRtG (ORCPT ); Tue, 25 Jun 2019 13:49:06 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay04.hostedemail.com (Postfix) with ESMTP id 368CB180A8142; Tue, 25 Jun 2019 17:49:04 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: mask89_8921d5caef211 X-Filterd-Recvd-Size: 1887 Received: from XPS-9350.home (cpe-23-242-196-136.socal.res.rr.com [23.242.196.136]) (Authenticated sender: joe@perches.com) by omf17.hostedemail.com (Postfix) with ESMTPA; Tue, 25 Jun 2019 17:49:02 +0000 (UTC) Message-ID: <9c0d4ed622d6b8e47e040d398f764d52a9ac396d.camel@perches.com> Subject: Re: [PATCH] video: fbdev: s3c-fb: Mark expected switch fall-throughs From: Joe Perches To: Kees Cook Cc: "Gustavo A. R. Silva" , Jingoo Han , Bartlomiej Zolnierkiewicz , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Masahiro Yamada , Michal Marek , linux-kbuild Date: Tue, 25 Jun 2019 10:49:01 -0700 In-Reply-To: <201906251029.08B862130@keescook> References: <20190625160103.GA13133@embeddedor> <2bdbbd7909c5c4ad96d32c0c5be4690292132a34.camel@perches.com> <201906251029.08B862130@keescook> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.30.5-0ubuntu0.18.10.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2019-06-25 at 10:31 -0700, Kees Cook wrote: > On Tue, Jun 25, 2019 at 09:52:23AM -0700, Joe Perches wrote: > > On Tue, 2019-06-25 at 11:01 -0500, Gustavo A. R. Silva wrote: > > > In preparation to enabling -Wimplicit-fallthrough, mark switch > > > cases where we are expecting to fall through. > > [] > > > This patch is part of the ongoing efforts to enable > > > -Wimplicit-fallthrough. > > > > Just enable the thing already. > > Linus has been pretty clear about not wanting warning options enabled > without first fixing all the cases it warns about first. Hey Kees. I don't recall that particular tidbit. Got a link? cheers, Joe