From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: James Tai <james.tai@realtek.com>,
Thomas Gleixner <tglx@linutronix.de>,
Marc Zyngier <maz@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v4 1/6] dt-bindings: interrupt-controller: Add support for Realtek DHC SoCs
Date: Thu, 28 Dec 2023 08:41:20 +0100 [thread overview]
Message-ID: <9c0fdb52-6312-4b3a-9ed8-ca8f38d1010d@linaro.org> (raw)
In-Reply-To: <20231228060825.1380439-2-james.tai@realtek.com>
On 28/12/2023 07:08, James Tai wrote:
> Add the YAML documentation for Realtek DHC (Digital Home Center) SoCs.
>
> Signed-off-by: James Tai <james.tai@realtek.com>
Thank you for your patch. There is something to discuss/improve.
> + interrupts:
> + minItems: 1
> + maxItems: 3
> + description:
> + Contains the GIC SPI IRQs mapped to the external interrupt lines.
> +
> +required:
> + - compatible
> + - reg
> + - interrupt-controller
> + - '#interrupt-cells'
> + - '#address-cells'
> + - interrupts
> +
> +additionalProperties: false
> +
> +allOf:
If there is going to be new version/resend, allOf: block goes before
additionalProperties:.
> + - $ref: /schemas/interrupt-controller.yaml#
> + - if:
> + properties:
> + compatible:
> + enum:
> + - realtek,rtd1319-intc-iso
> + then:
> + properties:
> + interrupts:
> + minItems: 1
Why the second interrupt is optional? It's a SoC, the pins are not
configurable usually. Same question for other cases.
> +...
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-12-28 7:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-28 6:08 [PATCH v4 0/6] Initial support for the Realtek interrupt controller James Tai
2023-12-28 6:08 ` [PATCH v4 1/6] dt-bindings: interrupt-controller: Add support for Realtek DHC SoCs James Tai
2023-12-28 7:41 ` Krzysztof Kozlowski [this message]
2023-12-29 15:59 ` James Tai [戴志峰]
2023-12-28 6:08 ` [PATCH v4 2/6] irqchip: Add interrupt controller " James Tai
2023-12-28 6:08 ` [PATCH v4 3/6] irqchip: Introduce RTD1319 support using the Realtek common interrupt controller driver James Tai
2023-12-28 6:08 ` [PATCH v4 4/6] irqchip: Introduce RTD1319D " James Tai
2024-01-09 4:45 ` kernel test robot
2023-12-28 6:08 ` [PATCH v4 5/6] irqchip: Introduce RTD1325 " James Tai
2023-12-28 6:08 ` [PATCH v4 6/6] irqchip: Introduce RTD1619B " James Tai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c0fdb52-6312-4b3a-9ed8-ca8f38d1010d@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=james.tai@realtek.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®