Re: [PATCH 0/2] io_uring/cancel: futex and waitid cancel results

[Jens Axboe <axboe@kernel.dk>]

On 10/24/26 10:31 AM, agxr wrote:
> io_futex_cancel() and io_waitid_cancel() return the number of requests
> they canceled, where the rest of what io_try_cancel() calls returns 0.
> Commit c74193430feb ("io_uring/timeout: don't end a linked timeout with
> 1") took care of what that did to a linked timeout.
> 
> liburing's futex, waitid, io-cancel, sync-cancel, poll-cancel-all,
> cancel-race, futex-kill, link-timeout, timeout and poll-cancel tests
> pass on both patched kernels. Unchanged liburing tests pass with patch
> 1 and fail with patch 2, where they check for the 1.
> 
> agxr (2):
>   io_uring/cancel: count all canceled futex and waitid requests on
>     CANCEL_ALL
>   io_uring/cancel: complete single futex or waitid cancel with 0
> 
>  io_uring/cancel.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

I'll take a look at these - but please note, that:

Signed-off-by: agxr <agxr@disroot.org>

is not going to be adequate for the kernel, we generally ask for
a known identity. That's either a real name or at least a well
known identity, above is neither of those.

-- 
Jens Axboe