From: Lech Perczak <lech.perczak@camlingroup.com>
To: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Hugo Villeneuve" <hvilleneuve@dimonoff.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Krzysztof Drobiński" <k.drobinski@camlintechnologies.com>,
"Pawel Lenkow" <p.lenkow@camlintechnologies.com>,
"Kirill Yatsenko" <kirill.yatsenko@camlingroup.com>
Subject: [PATCH v4 0/3] serial: sc16is7xx: cosmetic cleanup
Date: Mon, 26 Aug 2024 17:40:28 +0200 [thread overview]
Message-ID: <9c1f8fd4-a2a5-4f92-9e86-2cf0103b1908@camlingroup.com> (raw)
When submitting previous, functional fixes, Tomasz Moń omitted those
two cosmetic patches, that kept lurking in our company tree - likely
by oversight. Let's submit them.
Signed-off-by: Lech Perczak <lech.perczak@camlingroup.com>
---
v4:
No changes to patch 1 and 2.
- Fix typo in commit message in patch 3.
- Revert interrupt source constants back to numerical representation.
- Add a line break to SC16IS7XX_LSR_BRK_ERROR_MASK definition.
v3:
No code changes in patches 1 and 2.
- Pick up Reviewed-by from Andy in patch 1
- Adjust commit message in patch 2
- Perform further cleanup in bit constants,
use GENMASK for SC16IS7XX_IIR_* and reuse bit definitions in
SC16IS7XX_LSR_BRK_ERROR_MASK in patch 3.
v2:
- Converted bitmask definitions to use BIT macro
(thanks Jiri Slaby for the idea)
- Removed redundant comments in patch 2 altogether
- Fixed commit messages (thanks Andy Shevchenko for
thorough review)
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jirislaby@kernel.org>
Cc: Hugo Villeneuve <hvilleneuve@dimonoff.com>
Cc: Andy Shevchenko <andy@kernel.org>
Lech Perczak (3):
serial: sc16is7xx: remove SC16IS7XX_MSR_DELTA_MASK
serial: sc16is7xx: fix copy-paste errors in EFR_SWFLOWx_BIT constants
serial: sc16is7xx: convert bitmask definitions to use BIT() macro
drivers/tty/serial/sc16is7xx.c | 183 +++++++++++++++++----------------
1 file changed, 94 insertions(+), 89 deletions(-)
base-commit: 0c3836482481200ead7b416ca80c68a29cfdaabd
--
2.34.1
next reply other threads:[~2024-08-26 15:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-26 15:40 Lech Perczak [this message]
2024-08-26 15:41 ` [PATCH v4 1/3] serial: sc16is7xx: remove SC16IS7XX_MSR_DELTA_MASK Lech Perczak
2024-08-26 15:42 ` [PATCH v4 2/3] serial: sc16is7xx: fix copy-paste errors in EFR_SWFLOWx_BIT constants Lech Perczak
2024-08-26 15:42 ` [PATCH v4 3/3] serial: sc16is7xx: convert bitmask definitions to use BIT() macro Lech Perczak
2024-08-26 17:40 ` [PATCH v4 0/3] serial: sc16is7xx: cosmetic cleanup Andy Shevchenko
[not found] <Zsy998mgOAyJa2xn () smile ! fi ! intel ! com>
2024-08-27 15:38 ` Lech Perczak
2024-08-28 4:35 ` Jiri Slaby
[not found] <19c7e2b8-7f74-4138-b366-758b65da998b () kernel ! org>
2024-09-04 14:18 ` Lech Perczak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c1f8fd4-a2a5-4f92-9e86-2cf0103b1908@camlingroup.com \
--to=lech.perczak@camlingroup.com \
--cc=andy@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hvilleneuve@dimonoff.com \
--cc=jirislaby@kernel.org \
--cc=k.drobinski@camlintechnologies.com \
--cc=kirill.yatsenko@camlingroup.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=p.lenkow@camlintechnologies.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®